Details about package tinymux
Package uploads
Upload #4
Information
Changelog
tinymux (2.12.0.10-2) unstable; urgency=medium
.
* Add explicit Build-Depends on libcrypt-dev.
This package uses crypt functionality via crypt.h and -lcrypt,
but previously relied on a transitive dependency through libc6-dev.
That dependency is being dropped from the build-essential set in the
forky cycle. This change ensures continued successful builds.
(Closes: #1107061)
* Added debian/README.source to document embedded PCRE3 copy in 2.12 series.
* Bumped Standards-Version to 4.7.2. No changes needed.
* Switched to debhelper-compat 13.
* Removed unintended executable permissions on static game data files
under /usr/share/tinymux/game. These files are not scripts or binaries.
Comments
-
Stephen,
Nice work and many thanks for looking into many things.
I think it is plenty for this release and further work can be done in future uploads.
If you do not have a sponsor, you can file an RFS[1] so we can get the package in front of more Debian Developers eyes.
[1] https://mentors.debian.net/sponsors/rfs-howto/
Regards
Phil
Ready
Phil Wyett at Aug. 7, 2025, 5:24 a.m.
Upload #3
Information
Changelog
tinymux (2.12.0.10-2) unstable; urgency=medium
.
* Add explicit Build-Depends on libcrypt-dev.
This package uses crypt functionality via crypt.h and -lcrypt,
but previously relied on a transitive dependency through libc6-dev.
That dependency is being dropped from the build-essential set in the
forky cycle. This change ensures continued successful builds.
(Closes: #1107061)
* Added debian/README.source to document embedded PCRE3 copy in 2.12 series.
* Bumped Standards-Version to 4.7.2. No changes needed.
* Switched to debhelper-compat 13.
Comments
-
Stephen,
For the moment I am going mention one lintian issue, minor.
P: tinymux source: trailing-whitespace [debian/changelog:11]
N:
N: This file contains lines with trailing whitespace characters.
N:
N: Whilst often harmless and unsightly, such extra whitespaces can also cause
N: tools to interpret the whitespace characters literally. The tool diff(1)
N: does not like them, either. They are best avoided.
N:
N: Some of these problems can be hard to track down.
N:
N: Whitespace at the end of lines may be removed with the following:
N:
N: $ sed -i -e 's@[[:space:]]*$@@g' debian/control debian/changelog
N:
N: If you use Emacs, you can also use "M-x wh-cl" (whitespace-cleanup).
N:
N: However, if you wish to only remove trailing spaces and leave trailing
N: tabs (eg. for Makefiles), you can use the following code snippet:
N:
N: $ sed -i -e 's@[ ]*$@@g' debian/rules
N:
N: To remove empty lines from the end of a file, you can use:
N:
N: $ sed -i -e :a -e '/^\n*$/{$d;N;};/\n$/ba' debian/rules
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/trailing-whitespace
N: Renamed from: file-contains-trailing-whitespace
The below files are executable, is there a particular reason why?
W: tinymux: executable-not-elf-or-script [usr/share/tinymux/game/alias.conf]
N:
N: This executable file is not an ELF format binary, and does not start with
N: the #! sequence that marks interpreted scripts. It might be a sh script
N: that fails to name /bin/sh as its shell, or it may be incorrectly marked
N: as executable. Sometimes upstream files developed on Windows are marked
N: unnecessarily as executable on other systems.
N:
N: If you are using debhelper to build your package, running dh_fixperms will
N: often correct this problem for you.
N:
N: Please refer to Scripts (Section 10.4) in the Debian Policy Manual for
N: details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: executable
N:
N:
W: tinymux: executable-not-elf-or-script [usr/share/tinymux/game/compat.conf]
N:
W: tinymux: executable-not-elf-or-script [usr/share/tinymux/game/data/netmux.db]
N:
W: tinymux: executable-not-elf-or-script [usr/share/tinymux/game/mux.config]
N:
W: tinymux: executable-not-elf-or-script [usr/share/tinymux/game/muxssl.conf]
N:
W: tinymux: executable-not-elf-or-script [usr/share/tinymux/game/text/badsite.txt]
N:
W: tinymux: executable-not-elf-or-script [usr/share/tinymux/game/text/connect.txt]
N:
W: tinymux: executable-not-elf-or-script [usr/share/tinymux/game/text/create_reg.txt]
N:
W: tinymux: executable-not-elf-or-script [usr/share/tinymux/game/text/down.txt]
N:
W: tinymux: executable-not-elf-or-script [usr/share/tinymux/game/text/full.txt]
N:
W: tinymux: executable-not-elf-or-script [usr/share/tinymux/game/text/guest.txt]
N:
W: tinymux: executable-not-elf-or-script [usr/share/tinymux/game/text/help.txt]
N:
W: tinymux: executable-not-elf-or-script [usr/share/tinymux/game/text/motd.txt]
N:
W: tinymux: executable-not-elf-or-script [usr/share/tinymux/game/text/news.txt]
N:
W: tinymux: executable-not-elf-or-script [usr/share/tinymux/game/text/newuser.txt]
N:
W: tinymux: executable-not-elf-or-script [usr/share/tinymux/game/text/plushelp.txt]
N:
W: tinymux: executable-not-elf-or-script [usr/share/tinymux/game/text/quit.txt]
N:
W: tinymux: executable-not-elf-or-script [usr/share/tinymux/game/text/register.txt]
N:
W: tinymux: executable-not-elf-or-script [usr/share/tinymux/game/text/staffhelp.txt]
N:
W: tinymux: executable-not-elf-or-script [usr/share/tinymux/game/text/wizhelp.txt]
N:
W: tinymux: executable-not-elf-or-script [usr/share/tinymux/game/text/wizmotd.txt]
N:
W: tinymux: executable-not-elf-or-script [usr/share/tinymux/game/text/wiznews.txt]
Regards
Phil
Needs work
Phil Wyett at Aug. 6, 2025, 6:16 p.m.
Upload #2
Information
Changelog
tinymux (2.12.0.10-2) unstable; urgency=medium
.
* Add explicit Build-Depends on libcrypt-dev.
This package uses crypt functionality via crypt.h and -lcrypt,
but previously relied on a transitive dependency through libc6-dev.
That dependency is being dropped from the build-essential set in the
forky cycle. This change ensures continued successful builds.
(Closes: #1107061)
Comments
-
Stephen,
Would you document the changes made since the last upload in the 'debian/changelog' please?
Regards
Phil
Phil Wyett at Aug. 6, 2025, 2:50 a.m.
Upload #1
Information
Changelog
tinymux (2.12.0.10-2) unstable; urgency=medium
.
* Add explicit Build-Depends on libcrypt-dev.
This package uses crypt functionality via crypt.h and -lcrypt,
but previously relied on a transitive dependency through libc6-dev.
That dependency is being dropped from the build-essential set in the
forky cycle. This change ensures continued successful builds.
(Closes: #1107061)
Comments
-
he Lintian error about embedded-library pcre3 is expected and explained in debian/README.source. PCRE3 sources are embedded in 2.12.x as a workaround to safely abort regex evaluation by anonymous users who can trigger pathological expressions. This prevents denial-of-service vulnerabilities.
The embedded PCRE was necessary due to TinyMUX's regex usage pattern, and properly isolated in 2.12 (removed in 2.13). Full switch to libpcre2 is in the works.
The .so files flagged for not linking libc are minimal plugins that do not require libc; they are stubs with no standard library calls.
Needs work
Stephen Dennis at Aug. 5, 2025, 12:03 p.m.
-
I am not a Debian Developer (DD) and have no ability to upload your package. All reviews are for your and DD information, there is no requirement by any party to act upon my reviews.
Stephen,
Review of upload: 2025-08-05 11:57
Test 1 (reproducibility): Information only, not a blocker
* Good
Test 2 (pbuilder build): Information only
* Good
Test 3 (pbuilder build --twice): Information only
* Good
Test 4 (sbuild): Information only
Lintian:
I: tinymux source: out-of-date-standards-version 4.6.1 (released 2022-05-11) (current is 4.7.2)
N:
N: The source package refers to a Standards-Version older than the one that
N: was current at the time the package was created (according to the
N: timestamp of the latest debian/changelog entry). Please consider updating
N: the package to current Policy and setting this control field
N: appropriately.
N:
N: If the package is already compliant with the current standards, you don't
N: have to re-upload the package just to adjust the Standards-Version control
N: field. However, please remember to update this field next time you upload
N: the package.
N:
N: See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
N: debian-policy package for a summary of changes in newer versions of
N: Policy.
N:
N: Please refer to
N: https://www.debian.org/doc/debian-policy/upgrading-checklist.html for
N: details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: fields/standards-version
P: tinymux source: package-uses-old-debhelper-compat-version 10
N:
N: This package uses a debhelper compatibility level that is no longer
N: recommended. Please consider using the recommended level.
N:
N: For most packages, the best way to set the compatibility level is to
N: specify debhelper-compat (= X) as a Build-Depends in debian/control. You
N: can also use the debian/compat file or export DH_COMPAT in debian/rules.
N:
N: If no level is selected debhelper defaults to level 1, which is
N: deprecated.
N:
N: Please refer to the debhelper(7) manual page for details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debhelper
P: tinymux source: trailing-whitespace [debian/changelog:134]
N:
N: This file contains lines with trailing whitespace characters.
N:
N: Whilst often harmless and unsightly, such extra whitespaces can also cause
N: tools to interpret the whitespace characters literally. The tool diff(1)
N: does not like them, either. They are best avoided.
N:
N: Some of these problems can be hard to track down.
N:
N: Whitespace at the end of lines may be removed with the following:
N:
N: $ sed -i -e 's@[[:space:]]*$@@g' debian/control debian/changelog
N:
N: If you use Emacs, you can also use "M-x wh-cl" (whitespace-cleanup).
N:
N: However, if you wish to only remove trailing spaces and leave trailing
N: tabs (eg. for Makefiles), you can use the following code snippet:
N:
N: $ sed -i -e 's@[ ]*$@@g' debian/rules
N:
N: To remove empty lines from the end of a file, you can use:
N:
N: $ sed -i -e :a -e '/^\n*$/{$d;N;};/\n$/ba' debian/rules
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/trailing-whitespace
N: Renamed from: file-contains-trailing-whitespace
Need to to be brought up to date.
Test 5 (ratt): Information only, not a blocker
Note: Possible false positives.
* Good
Test 6 (debian/watch): Information only
* Good
Test 7 (licenserecon): Information only
* Good
Some build files you may wish to add to 'debian/lrc.config'.
Summary
=======
Some information for tests 4 and 7. See above.
Regards
Phil
Needs work
Phil Wyett at Aug. 5, 2025, 2:32 p.m.
