Details about package xxkb
Package uploads
Upload #2
Information
Changelog
xxkb (1.11.1-3) unstable; urgency=medium
.
* QA upload.
* Add 0004-fix-ftbfs-on-gcc-14.patch to fix the ftbfs issue.
(Closes: #1075694)
* Set std-ver to 4.7.0.
* Add Rules-Requires-Root on d/control.
* Add doc-base for xxkb.
* Add 0005-fix-gcc-hardening.patch to fix hardening issue.
Comments
No comments
Upload #1
Information
Changelog
xxkb (1.11.1-3) unstable; urgency=medium
.
* QA upload.
* Add 0004-fix-ftbfs-on-gcc-14.patch to fix the ftbfs issue.
(Closes: #1075694)
* Set std-ver to 4.7.0.
* Add Rules-Requires-Root on d/control.
* Add doc-base for xxkb.
Comments
-
Bo,
Preamble...
Thank you for taking the time to prepare this package and your contribution to the Debian project.
The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Information
Running lintian...
N:
W: xxkb: national-encoding [usr/share/doc/xxkb/3gr.html]
N:
N: A file is not valid UTF-8.
N:
N: Debian has used UTF-8 for many years. Support for national encodings is
N: being phased out. This file probably appears to users in mangled
N: characters (also called mojibake).
N:
N: Packaging control files must be encoded in valid UTF-8.
N:
N: Please convert the file to UTF-8 using iconv or a similar tool.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: files/encoding
N: Renamed from: national-encoding-in-text-file
N: debian-changelog-file-uses-obsolete-national-encoding
N: debian-control-file-uses-obsolete-national-encoding
N: debian-copyright-file-uses-obsolete-national-encoding
N: debian-news-file-uses-obsolete-national-encoding
N: debian-tests-control-uses-national-encoding
N: doc-base-file-uses-obsolete-national-encoding
N: national-encoding-in-debconf-template national-encoding-in-manpage
N:
N:
W: xxkb: national-encoding [usr/share/doc/xxkb/README-Linux.koi8]
N:
I: xxkb: hardening-no-bindnow [usr/bin/xxkb]
N:
N: This package provides an ELF binary that lacks the "bindnow" linker flag.
N:
N: This is needed (together with "relro") to make the "Global Offset Table"
N: (GOT) fully read-only. The bindnow feature trades startup time for
N: improved security. Please consider enabling this feature or consider
N: overriding the tag (possibly with a comment about why).
N:
N: If you use dpkg-buildflags, you may have to add hardening=+bindnow or
N: hardening=+all to DEB_BUILD_MAINT_OPTIONS.
N:
N: The relevant compiler flags are set in LDFLAGS.
N:
N: Please refer to https://wiki.debian.org/Hardening for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: binaries/hardening
N:
N:
I: xxkb source: patch-not-forwarded-upstream [debian/patches/0001-debian-patch.patch]
N:
N: According to the DEP-3 headers, this patch has not been forwarded
N: upstream.
N:
N: Please forward the patch and try to have it included in upstream's version
N: control system. If the patch is not suitable for that, please mention
N: not-needed in the Forwarded field of the patch header.
N:
N: Please refer to social contract item 2, Coordination with upstream
N: developers (Section 3.1.4) in the Debian Developer's Reference, Changes to
N: the upstream sources (Section 4.3) in the Debian Policy Manual, and
N: Bug#755153 for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/patches/dep3
N: Renamed from: send-patch
N:
N:
I: xxkb source: patch-not-forwarded-upstream [debian/patches/0002-Fix-manpage-semantics.patch]
N:
I: xxkb source: patch-not-forwarded-upstream [debian/patches/0003-Imakefile-enable-debug-flag.patch]
N:
I: xxkb: typo-in-manual-page "allow to" "allow one to" [usr/share/man/man1/xxkb.1.gz:109]
N:
N: Lintian found a spelling error in a manual page. Lintian has a list of
N: common misspellings that it looks for. It does not have a dictionary like
N: a spelling checker does.
N:
N: If the string containing the spelling error is translated with the help of
N: gettext (with the help of po4a, for example) or a similar tool, please fix
N: the error in the translations as well as the English text to avoid making
N: the translations fuzzy. With gettext, for example, this means you should
N: also fix the spelling mistake in the corresponding msgids in the *.po
N: files.
N:
N: Visibility: info
N: Show-Always: no
N: Check: documentation/manual
N: Renamed from: spelling-error-in-manpage
N:
N:
I: xxkb: typo-in-manual-page "allow to" "allow one to" [usr/share/man/man1/xxkb.1.gz:252]
N:
I: xxkb: typo-in-manual-page "allow to" "allow one to" [usr/share/man/man1/xxkb.1.gz:48]
N:
I: xxkb: typo-in-manual-page "allows to" "allows one to" [usr/share/man/man1/xxkb.1.gz:184]
N:
I: xxkb: typo-in-manual-page "allows to" "allows one to" [usr/share/man/man1/xxkb.1.gz:189]
N:
I: xxkb: typo-in-manual-page "allows to" "allows one to" [usr/share/man/man1/xxkb.1.gz:239]
N:
I: xxkb: typo-in-manual-page "allows to" "allows one to" [usr/share/man/man1/xxkb.1.gz:39]
N:
I: xxkb: typo-in-manual-page "allows to" "allows one to" [usr/share/man/man1/xxkb.1.gz:45]
N:
I: xxkb: typo-in-manual-page "allows to" "allows one to" [usr/share/man/man1/xxkb.1.gz:70]
N:
P: xxkb source: maintainer-desktop-entry [debian/xxkb.desktop]
N:
N: The maintainer keeps a desktop entry in ./debian. Please forward the
N: desktop entry upstream and ask them to include it in their version control
N: system, and in their next release.
N:
N: If the desktop entry was already forwarded or rejected, or the upstream is
N: gone, please override the tag and annotate it with a suitable comment.
N:
N: Please refer to social contract item 2, Coordination with upstream
N: developers (Section 3.1.4) in the Debian Developer's Reference, and
N: Changes to the upstream sources (Section 4.3) in the Debian Policy Manual
N: for details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/desktop-entries
N:
I: Lintian run was successful.
3. Licenses [4]: Good
4. Watch file [uscan --force-download]: Good
5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Good
8. Upgrade [Over previous installs if any]: Good
Summary...
I believe xxkb is ready for review/possible sponsorship. Could a Debian Developer (DD) with available free time, please review this package and upload if you feel it is ready.
Regards
Phil
[1] pbuilder:
* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
Ready
Phil Wyett at Nov. 4, 2024, 5:30 p.m.
-
Thank you, Phil, I have uploaded it with -2 which to fix the hardening issues.
Needs work
Bo YU at Nov. 5, 2024, 2:30 a.m.
