Mateusz,
Preamble...
Thank you for taking the time to prepare this package and your contribution to the Debian project.
The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Issue
Running lintian...
N:
W: xfwm4: incorrect-locale-code hye -> hy [usr/share/locale/hye/]
N:
N: The package appears to ship locales for a language but uses an incorrect
N: locale code as a subdirectory of /usr/share/locale. This usually results
N: in users of the intended target language not finding the locale. The
N: language codes used in the locale directories are those from the ISO 639-1
N: and ISO 639-2 standards, not those usually used as TLDs (which are from
N: the ISO 3166 standard).
N:
N: When both standards define a language code for a given language, the ISO
N: 639-1 code should be used (i.e. the two lettered code).
N:
N: Lintian only knows about some commonly-mistaken set of incorrect locale
N: codes.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: files/locales
N:
N:
I: xfwm4: package-contains-documentation-outside-usr-share-doc [usr/share/themes/Daloa/xfwm4/README]
N:
N: This package ships a documentation file outside /usr/share/doc
N: Documentation files are normally installed inside /usr/share/doc.
N:
N: If this file doesn't describe the contents or purpose of the directory it
N: is in, please consider moving this file to /usr/share/doc/ or maybe even
N: removing it. If this file does describe the contents or purpose of the
N: directory it is in, please add a lintian override.
N:
N: Visibility: info
N: Show-Always: no
N: Check: documentation
N:
N: Screen: python/egg/metadata
N: Advocates: "Scott Kitterman" <debian@kitterman.com>
N: Reason: The folders XXX.dist-info/ and XXX.egg-info/ hold metadata for
N: Python modules. Those files are not documentation even though
N: some of their names carry the .txt file extension.
N:
N: Python modules can be both public and private.
N:
N: Read more in
N: https://www.python.org/dev/peps/pep-0427/#the-dist-info-directory,
N: https://www.python.org/dev/peps/pep-0376/#id16,
N: https://www.python.org/dev/peps/pep-0610/,
N: https://www.python.org/dev/peps/pep-0639/,
N: https://setuptools.pypa.io/en/latest/deprecated/python_eggs.html,
N: and Bug#1003913.
N:
N:
I: xfwm4: package-contains-documentation-outside-usr-share-doc [usr/share/themes/Default-hdpi/xfwm4/README]
N:
I: xfwm4: package-contains-documentation-outside-usr-share-doc [usr/share/themes/Default-xhdpi/xfwm4/README]
N:
I: xfwm4: package-contains-documentation-outside-usr-share-doc [usr/share/themes/Default/xfwm4/README]
N:
I: xfwm4: package-contains-documentation-outside-usr-share-doc [usr/share/themes/Kokodi/xfwm4/README]
N:
I: xfwm4: package-contains-documentation-outside-usr-share-doc [usr/share/themes/Moheli/xfwm4/README]
N:
P: xfwm4: copyright-refers-to-symlink-license usr/share/common-licenses/GPL
N:
N: The copyright file refers to the versionless symlink in
N: /usr/share/common-licenses for the full text of the GPL, LGPL, or GFDL
N: license. This symlink is updated to point to the latest version of the
N: license when a new one is released. The package appears to allow
N: relicensing under later versions of its license, so this is legally
N: consistent, but it implies that Debian will relicense the package under
N: later versions of those licenses as they're released. It is normally
N: better to point to the version of the license the package references in
N: its license statement.
N:
N: For example, if the package says something like "you may redistribute it
N: and/or modify it under the terms of the GNU General Public License as
N: published by the Free Software Foundation; either version 2, or (at your
N: option) any later version", the debian/copyright file should refer to
N: /usr/share/common-licenses/GPL-2, not /GPL.
N:
N: For packages released under the same terms as Perl, Perl references the
N: GPL version 1, so point to /usr/share/common-licenses/GPL-1.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/copyright
N:
N:
P: xfwm4 source: maintainer-manual-page [debian/xfwm4-settings.1]
N:
N: The maintainer keeps a manual page in ./debian. Please forward the manual
N: page upstream and ask them to include in their version control system, and
N: in their next release.
N:
N: If the manual page was already forwarded or rejected, or the upstream is
N: gone, please override the tag and annotate it with a suitable comment.
N:
N: Please refer to social contract item 2, Coordination with upstream
N: developers (Section 3.1.4) in the Debian Developer's Reference, and
N: Changes to the upstream sources (Section 4.3) in the Debian Policy Manual
N: for details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/manual-pages
N: Renamed from: maintainer-manpage
N:
N:
P: xfwm4 source: maintainer-manual-page [debian/xfwm4-tweaks-settings.1]
N:
P: xfwm4 source: maintainer-manual-page [debian/xfwm4-workspace-settings.1]
N:
P: xfwm4 source: maintainer-manual-page [debian/xfwm4.1]
N:
P: xfwm4 source: no-dep5-copyright [debian/copyright]
N:
N: This package does not use a machine-readable debian/copyright file.
N:
N: This format makes it easier to review licenses and can be easily parsed by
N: Lintian.
N:
N: Please refer to
N: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ for
N: details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/copyright/dep5
N:
E: Lintian run failed (runtime error)
3. Licenses [4]: Issue
philwyett@ks-tarkin:~/Development/builder/debian/xfwm4-4.19.0$ lrc
en: Versions: recon 3.2 check 3.3.9-1
Parsing Source Tree ....
Reading d/copyright ....
Invalid DEP-5 header in debian/copyright
Failed to process debian/copyright
4. Watch file [uscan --force-download]: Good
5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Good
8. Upgrade [Over previous installs if any]: Good
Summary...
I believe xfwm4 is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the raised issues.
Regards
Phil
[1] pbuilder:
* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
Needs work
Phil Wyett at Dec. 14, 2024, 7:47 p.m.
