CrypticVerse,
Preamble...
Thank you for taking the time to prepare this package and your contribution to the Debian project.
This review is offered to help package contributors to Debian mentors improve their packages (where needed) prior to possible sponsorship into Debian by a Debian Developer.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Issue
Running lintian...
N:
E: update-hub changes: unreleased-changes
N:
N: The distribution in the Changes field copied from debian/changelog
N: indicates that this package was not intended to be released yet.
N:
N: Please refer to Bug#542747 for details.
N:
N: Visibility: error
N: Show-Always: no
N: Check: fields/distribution
N:
N:
W: update-hub source: no-debian-changes
N:
N: This non-native package makes no changes to the upstream sources in the
N: Debian-related files.
N:
N: Maybe a mistake was made when the upstream tarball was created, or maybe
N: this package is really a native package but was built non-native by
N: mistake.
N:
N: Debian packaging is sometimes maintained as part of upstream, but that is
N: not recommended as best practice. Please make this package native, if the
N: software is only for Debian. Otherwise, please remove the debian directory
N: from upstream releases and add it in the Debian packaging.
N:
N: Format 1.0 packages are subject to the restriction that the diff cannot
N: remove files from the debian directory. For Format 3.0 packages, the
N: debian directory is automatically purged during unpacking.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: files/artifact
N: Renamed from: empty-debian-diff
N:
N:
W: update-hub: no-manual-page [usr/bin/update-hub]
N:
N: Each binary in /usr/bin, /usr/sbin, /bin, /sbin or /usr/games should have
N: a manual page
N:
N: Note that though the man program has the capability to check for several
N: program names in the NAMES section, each of these programs should have its
N: own manual page (a symbolic link to the appropriate manual page is
N: sufficient) because other manual page viewers such as xman or tkman don't
N: support this.
N:
N: If the name of the manual page differs from the binary by case, man may be
N: able to find it anyway; however, it is still best practice to match the
N: exact capitalization of the executable in the manual page.
N:
N: If the manual pages are provided by another package on which this package
N: depends, Lintian may not be able to determine that manual pages are
N: available. In this case, after confirming that all binaries do have manual
N: pages after this package and its dependencies are installed, please add a
N: Lintian override.
N:
N: Please refer to Manual pages (Section 12.1) in the Debian Policy Manual
N: for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: documentation/manual
N: Renamed from: binary-without-manpage
N:
N:
W: update-hub source: syntax-error-in-dep5-copyright Continuation line not in paragraph (line 16). Missing a dot on the previous line? [debian/copyright]
N:
N: The machine-readable copyright file didn't pass Debian control file syntax
N: check.
N:
N: This issue may hide other issues as Lintian skips some checks on the file
N: in this case.
N:
N: Please refer to
N: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ for
N: details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: debian/copyright/dep5
N:
N:
I: update-hub source: debian-watch-file-is-missing
N:
N: This source package is not Debian-native but it does not have a
N: debian/watch file. This file is used for automatic detection of new
N: upstream versions by the Debian External Health Status project and other
N: project infrastructure. If this package is maintained upstream, please
N: consider adding a debian/watch file to detect new releases.
N:
N: If the package is not maintained upstream or if upstream uses a
N: distribution mechanism that cannot be meaningfully monitored by uscan and
N: the Debian External Health Status project, please consider adding a
N: debian/watch file containing only comments documenting the situation.
N:
N: Please refer to Upstream source location: debian/watch (Section 4.11) in
N: the Debian Policy Manual and the uscan(1) manual page for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/watch
N:
N:
P: update-hub source: maintainer-desktop-entry [debian/update-hub.desktop]
N:
N: The maintainer keeps a desktop entry in ./debian. Please forward the
N: desktop entry upstream and ask them to include it in their version control
N: system, and in their next release.
N:
N: If the desktop entry was already forwarded or rejected, or the upstream is
N: gone, please override the tag and annotate it with a suitable comment.
N:
N: Please refer to social contract item 2, Coordination with upstream
N: developers (Section 3.1.4) in the Debian Developer's Reference, and
N: Changes to the upstream sources (Section 4.3) in the Debian Policy Manual
N: for details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/desktop-entries
N:
N:
P: update-hub source: no-homepage-field
N:
N: This non-native package lacks a Homepage field. If the package has an
N: upstream home page that contains useful information or resources for the
N: end user, consider adding a Homepage control field to debian/control.
N:
N: Please refer to Homepage (Section 5.6.23) in the Debian Policy Manual for
N: details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: fields/homepage
N:
N:
P: update-hub source: silent-on-rules-requiring-root [debian/control]
N:
N: The field Rules-Requires-Root is missing from the file debian/control.
N:
N: Over time, Debian has successively narrowed the steps for which elevated
N: privileges are required. It speeds up the building of installation
N: packages in the archive. Eventually, Debian will switch the default
N: archive-wide behaviour to expedite the build process further.
N:
N: Please declare explicitly that the sources do not require root privileges.
N: You can use the setting Rules-Requires-Root: no in the source stanza of
N: debian/control, but please verify with diffoscope(1) that the installation
N: packages produced are in fact identical.
N:
N: Please refer to usr/share/doc/dpkg/spec/rootless-builds.txt, debian/rules
N: and Rules-Requires-Root (Section 4.9.2) in the Debian Policy Manual, and
N: Rules-Requires-Root (Section 5.6.31) in the Debian Policy Manual for
N: details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/control/field/rules-requires-root
N: Renamed from: rules-requires-root-missing
N:
N:
P: update-hub source: trailing-whitespace [debian/changelog:3]
N:
N: This file contains lines with trailing whitespace characters.
N:
N: Whilst often harmless and unsightly, such extra whitespaces can also cause
N: tools to interpret the whitespace characters literally. The tool diff(1)
N: does not like them, either. They are best avoided.
N:
N: Some of these problems can be hard to track down.
N:
N: Whitespace at the end of lines may be removed with the following:
N:
N: $ sed -i -e 's@[[:space:]]*$@@g' debian/control debian/changelog
N:
N: If you use Emacs, you can also use "M-x wh-cl" (whitespace-cleanup).
N:
N: However, if you wish to only remove trailing spaces and leave trailing
N: tabs (eg. for Makefiles), you can use the following code snippet:
N:
N: $ sed -i -e 's@[ ]*$@@g' debian/rules
N:
N: To remove empty lines from the end of a file, you can use:
N:
N: $ sed -i -e :a -e '/^\n*$/{$d;N;};/\n$/ba' debian/rules
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/trailing-whitespace
N: Renamed from: file-contains-trailing-whitespace
N:
N:
P: update-hub source: trailing-whitespace [debian/control:12]
E: Lintian run failed (runtime error)
3. Licenses [4]: Good
Not sure why mentors is flagging here. Adding a 'Files: debian/*' section would be nice.
4. Watch file [uscan --force-download]: Question
No watch file and no homepage for the source. Is this to be added?
5. Build Twice (build source after successful build) [1]: Good
6. Reproducible builds [5]: Good
Note: This test does not block sponsorship and is for information only at this time. It is good if a package passes this test.
7. Tail of the ratt (architecture dependant packages only) [6]: Not performed
Note: This test does not block sponsorship and is for information only at this time. It is good if a package passes this test.
8. Install [No previous installs]: Not performed
9. Upgrade [Over previous installs if any]: N/A
Summary...
Many thanks for the upload. Please see the issues raised. If you need questions answered, please ask on the mentors IRC channel or mailing list.
Please try the below on your packages...
[1] pbuilder:
* Command for 1.: sudo pbuilder build <PACKAGE>.dsc
* Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild -d unstable <PACKAGE>.dsc
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian --display-info --verbose --fail-on error --info --pedantic --show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
Note: Please report false positives as bug reports against 'licenserecon'.
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
[6] ratt
* Command: ratt --dist=<YOUR_DISTRIBUTION> <PACKAGE>_<VERSION>-<DEBIAN_REVISION>_<ARCHITECTURE>.changes
* Document: https://manpages.debian.org/unstable/ratt/ratt.1.en.html
Regards
Phil
Needs work
Phil Wyett at Jan. 28, 2025, 6:34 a.m.
