Mikhail,
Preamble...
Thank you for taking the time to prepare this package and your contribution to the Debian project.
This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Goos
2. Lintian [3]: Issue
Running lintian...
N:
W: sfp-master: initial-upload-closes-no-bugs [usr/share/doc/sfp-master/changelog.Debian.gz:1]
N:
N: This package appears to be the first packaging of a new upstream software
N: package (there is only one changelog entry and the Debian revision is 1),
N: but it does not close any bugs. The initial upload of a new package should
N: close the corresponding ITP bug for that package.
N:
N: This warning can be ignored if the package is not intended for Debian or
N: if it is a split of an existing Debian package.
N:
N: Please refer to New packages (Section 5.1) in the Debian Developer's
N: Reference for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: debian/changelog
N: Renamed from: new-package-should-close-itp-bug
N:
N:
W: sfp-master source: mismatched-override source-is-missing [other/SFP-Master.pdf] [debian/source/lintian-overrides:2]
N:
N: The named tag would have been silenced except the context specified with
N: the override did not match.
N:
N: Lintian may now provide a different context for the tag, or something
N: could have changed in a new version of your package. Either way, overrides
N: work best when you require as little context as needed.
N:
N: You can use wildcards, such as * or ? in the context to make a match more
N: likely.
N:
N: Please remove or adjust the override.
N:
N: Visibility: warning
N: Show-Always: yes
N: Check: lintian
N:
N:
I: sfp-master: spelling-error-in-binary programm program [usr/bin/SFP-Master:1]
N:
N: Lintian found a spelling error in the given binary. Lintian has a list of
N: common misspellings that it looks for. It does not have a dictionary like
N: a spelling checker does.
N:
N: If the string containing the spelling error is translated with the help of
N: gettext or a similar tool, please fix the error in the translations as
N: well as the English text to avoid making the translations fuzzy. With
N: gettext, for example, this means you should also fix the spelling mistake
N: in the corresponding msgids in the *.po files.
N:
N: You can often find the word in the source code by running:
N:
N: grep -rw <word> <source-tree>
N:
N: This tag may produce false positives for words that contain non-ASCII
N: characters due to limitations in strings.
N:
N: Visibility: info
N: Show-Always: no
N: Check: binaries/spelling
N:
N:
P: sfp-master source: trailing-whitespace [debian/control:23]
N:
N: This file contains lines with trailing whitespace characters.
N:
N: Whilst often harmless and unsightly, such extra whitespaces can also cause
N: tools to interpret the whitespace characters literally. The tool diff(1)
N: does not like them, either. They are best avoided.
N:
N: Some of these problems can be hard to track down.
N:
N: Whitespace at the end of lines may be removed with the following:
N:
N: $ sed -i -e 's@[[:space:]]*$@@g' debian/control debian/changelog
N:
N: If you use Emacs, you can also use "M-x wh-cl" (whitespace-cleanup).
N:
N: However, if you wish to only remove trailing spaces and leave trailing
N: tabs (eg. for Makefiles), you can use the following code snippet:
N:
N: $ sed -i -e 's@[ ]*$@@g' debian/rules
N:
N: To remove empty lines from the end of a file, you can use:
N:
N: $ sed -i -e :a -e '/^\n*$/{$d;N;};/\n$/ba' debian/rules
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/trailing-whitespace
N: Renamed from: file-contains-trailing-whitespace
N:
E: Lintian run failed (runtime error)
3. Licenses [4]: Issue, possible false positives
philwyett@ks-tarkin:~/Development/builder/debian/sfp-master-1.0.5$ lrc
en: Versions: recon '3.4' check '3.3.9-1'
Parsing Source Tree ....
Reading d/copyright ....
Missing Files: Paragraph for debian/
Running licensecheck ....
d/copyright | licensecheck
GPL-3+ | GPL-2+ dialogpass.cpp
GPL-3+ | GPL-2 and/or GPL-3+ other/sfp-master.spec
4. Watch file [uscan --force-download]: Issue
philwyett@ks-tarkin:~/Development/builder/debian/sfp-master-1.0.5$ uscan --force-download
uscan warn: In watchfile debian/watch, reading webpage
https://github.com/bigbigmdm/SFP_Master/tags failed: 404 Not Found
5. Build Twice (build source after successful build [1]: Good
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Not performed at this time
8. Upgrade [Over previous installs if any]: Not performed at this time
Summary...
Mikhail, A few things to have a look at.
Please try the below on your packages...
[1] pbuilder:
* Command for 1.: sudo pbuilder build <PACKAGE>.dsc
* Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild -d unstable <PACKAGE>.dsc
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian --display-info --verbose --fail-on error --info --pedantic --show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
Note: Please report false positives as bug reports against 'licenserecon'.
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
Regards
Phil
Needs work
Phil Wyett at Jan. 20, 2025, 8:04 a.m.
