Details about package sff
Package uploads
Upload #3
Information
Changelog
sff (1.1-1) unstable; urgency=medium
.
* Initial release (Closes: #1108135)
Comments
-
Shi Yanling,
Looking really good now and ready for filing an RFS[1].
I took a look at Salsa repository for the package and it is a single branch, not he Debian way[2].
A Debian repository has:
* master
* pristine-tar
* upstream
To create the correct structure, delete your packages repository and recreate using my tutorial[3].
[1] https://mentors.debian.net/sponsors/rfs-howto/
[2] https://salsa.debian.org/debian/rednotebook
[3] https://wiki.debian.org/PhilWyett/DebianImportNewPackageIntoSalsa
Ready
Phil Wyett at June 26, 2025, 12:22 p.m.
-
Hi Phil,
I've recreated the repository on Salsa following your tutorial. Thank you very much for your guidance.
Regards,
Shi Yanling
Ready
Shi Yanling at June 26, 2025, 1:10 p.m.
-
Hi,
Always happy to help.
Regards
Phil
Ready
Phil Wyett at June 26, 2025, 1:20 p.m.
Upload #2
Information
Changelog
sff (1.1-1) unstable; urgency=medium
.
* Initial release (Closes: #1108135)
Comments
-
Shi Yanling,
Many thanks for the changes.
The package is looking really good.
One thing we do need to fix.
I: sff source: quilt-patch-missing-description [debian/patches/fix-manual.patch]
N:
N: quilt patch files should start with a description of patch. All lines
N: before the start of the patch itself are considered part of the
N: description. You can edit the description with quilt header -e when the
N: patch is at the top of the stack.
N:
N: As well as a description of the purpose and function of the patch, the
N: description should ideally contain author information, a URL for the bug
N: report (if any), Debian or upstream bugs fixed by it, upstream status, the
N: Debian version and date the patch was first included, and any other
N: information that would be useful if someone were investigating the patch
N: and underlying problem. Please consider using the DEP 3 format for this
N: information.
N:
N: Please refer to https://dep-team.pages.debian.net/deps/dep3/ for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/patches/quilt
When you create patches in Debian we have a standard i.e. DEP-3.
https://dep-team.pages.debian.net/deps/dep3/
If you could rework the patch header to the standard, that would be great. If all correct the package should then have no lintian issues raised.
Regards
Phil
Needs work
Phil Wyett at June 25, 2025, 6:24 p.m.
-
Hi Phil,
Thank you for your feedback. I've updated the patch headers and reuploaded the package.
Regards,
Shi Yanling
Ready
Shi Yanling at June 26, 2025, 4:02 a.m.
Upload #1
Information
Changelog
sff (1.1-1) unstable; urgency=medium
.
* Add plugins support
* New preview plugin
* Changed sff-extfunc installation path from libexec/ to libexec/sff/
* 'Extract and create archives' now provided as a plugin
* Optimized and simplified prompt text for extension functions
Comments
-
Shi Yanling,
Review of upload: 2025-06-23 10:57
For information about the tests run, see:
https://wiki.debian.org/PhilWyett/DebianMentoring
Test 4 (sbuild): Information only
Lintian:
Running lintian...
N:
I: sff source: debian-watch-file-is-missing
N:
N: This source package is not Debian-native but it does not have a
N: debian/watch file. This file is used for automatic detection of new
N: upstream versions by the Debian External Health Status project and other
N: project infrastructure. If this package is maintained upstream, please
N: consider adding a debian/watch file to detect new releases.
N:
N: If the package is not maintained upstream or if upstream uses a
N: distribution mechanism that cannot be meaningfully monitored by uscan and
N: the Debian External Health Status project, please consider adding a
N: debian/watch file containing only comments documenting the situation.
N:
N: Please refer to Upstream source location: debian/watch (Section 4.11) in
N: the Debian Policy Manual and the uscan(1) manual page for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/watch
N:
N:
I: sff: hardening-no-bindnow [usr/bin/sff]
N:
N: This package provides an ELF binary that lacks the "bindnow" linker flag.
N:
N: This is needed (together with "relro") to make the "Global Offset Table"
N: (GOT) fully read-only. The bindnow feature trades startup time for
N: improved security. Please consider enabling this feature or consider
N: overriding the tag (possibly with a comment about why).
N:
N: If you use dpkg-buildflags, you may have to add hardening=+bindnow or
N: hardening=+all to DEB_BUILD_MAINT_OPTIONS.
N:
N: The relevant compiler flags are set in LDFLAGS.
N:
N: Please refer to https://wiki.debian.org/Hardening for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: binaries/hardening
N:
N:
I: sff: hardening-no-fortify-functions [usr/bin/sff]
N:
N: This package provides an ELF binary that lacks the use of fortified libc
N: functions. Either there are no potentially unfortified functions called by
N: any routines, all unfortified calls have already been fully validated at
N: compile-time, or the package was not built with the default Debian
N: compiler flags defined by dpkg-buildflags. If built using dpkg-buildflags
N: directly, be sure to import CPPFLAGS.
N:
N: NB: Due to false-positives, Lintian ignores some unprotected functions
N: (e.g. memcpy).
N:
N: Please refer to https://wiki.debian.org/Hardening and Bug#673112 for
N: details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: binaries/hardening
N:
N:
I: sff source: out-of-date-standards-version 4.6.2 (released 2022-12-17) (current is 4.7.2)
N:
N: The source package refers to a Standards-Version older than the one that
N: was current at the time the package was created (according to the
N: timestamp of the latest debian/changelog entry). Please consider updating
N: the package to current Policy and setting this control field
N: appropriately.
N:
N: If the package is already compliant with the current standards, you don't
N: have to re-upload the package just to adjust the Standards-Version control
N: field. However, please remember to update this field next time you upload
N: the package.
N:
N: See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
N: debian-policy package for a summary of changes in newer versions of
N: Policy.
N:
N: Please refer to
N: https://www.debian.org/doc/debian-policy/upgrading-checklist.html for
N: details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: fields/standards-version
N:
N:
P: sff source: trailing-whitespace [debian/control:14]
N:
N: This file contains lines with trailing whitespace characters.
N:
N: Whilst often harmless and unsightly, such extra whitespaces can also cause
N: tools to interpret the whitespace characters literally. The tool diff(1)
N: does not like them, either. They are best avoided.
N:
N: Some of these problems can be hard to track down.
N:
N: Whitespace at the end of lines may be removed with the following:
N:
N: $ sed -i -e 's@[[:space:]]*$@@g' debian/control debian/changelog
N:
N: If you use Emacs, you can also use "M-x wh-cl" (whitespace-cleanup).
N:
N: However, if you wish to only remove trailing spaces and leave trailing
N: tabs (eg. for Makefiles), you can use the following code snippet:
N:
N: $ sed -i -e 's@[ ]*$@@g' debian/rules
N:
N: To remove empty lines from the end of a file, you can use:
N:
N: $ sed -i -e :a -e '/^\n*$/{$d;N;};/\n$/ba' debian/rules
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/trailing-whitespace
N: Renamed from: file-contains-trailing-whitespace
N:
N:
P: sff source: trailing-whitespace [debian/control:15]
N:
P: sff source: trailing-whitespace [debian/control:16]
I: Lintian run was successful.
Test 5 (ratt): Information only
Test 6 (debian/watch): Information only
Test 7 (licenserecon): Information only
Test 8 (first run): Information only
Summary
=======
Above issues to be addressed.
A package new to Debian should only have one changelof entry that declares 'Initial release.' and closing the Intent To Package (ITP) bug filed on bts.
Regards
Phil
Needs work
Phil Wyett at June 24, 2025, 12:26 a.m.
-
You may wish to refer to resources, such as https://www.debian.org/devel/
Phil Wyett at June 24, 2025, 12:26 a.m.
-
Hi Phil,
Thank you for your review. I've addressed all the issues and re-uploaded the updated package.
Best regards,
Shi Yanling
Ready
Shi Yanling at June 25, 2025, 3:23 p.m.
