Sign me up Login

Details about package serious-engine

Name: serious-engine
Uploader: Sébastien Noel <sebastien@twolife.be> (Debian QA page)
Description: serious-sam-tfe - Serious Sam - The First Encounter
serious-sam-tse - Serious Sam - The Second Encounter

Package uploads

Upload #3

Information

Version: 0~git20230724+dfsg-1
Uploaded: 2024-05-28 06:54
Source package: serious-engine_0~git20230724+dfsg-1.dsc
Distribution: unstable
Section: contrib/games
Priority: optional
Homepage: https://github.com/ptitSeb/Serious-Engine
Closes bugs: #1034630

Changelog

 serious-engine (0~git20230724+dfsg-1) unstable; urgency=low
 .
   * Initial release. Closes: #1034630

QA information

Comments

  1. Hi Sebastien,

I am unable to find a Request For Sponsorship (RFS) bug filed for this submission though you have indicated you wish sponsorship.

To file an RFS bug, see the below link.

https://mentors.debian.net/sponsors/rfs-howto/

Regards

Phil
    Needs work Phil Wyett at May 30, 2024, 5:05 p.m. 
  2. The RFS is here https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1037098

(almost a year ago...)
    Sébastien Noel at May 30, 2024, 5:23 p.m. 
  3. The bug referenced has been marked as done, archived and was done for a previous revision. I would suggest filing a new one.

Regards

Phil
    Phil Wyett at May 30, 2024, 5:27 p.m. 
  4. But why was it closed :-(

Her is a new one: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1072226

Thanks again for the time you spend on this!

Br,
Sébastien
    Sébastien Noel at May 30, 2024, 6:05 p.m.

Upload #2

Information

Version: 0~git20230724+dfsg-1
Uploaded: 2024-05-27 19:24
Source package: serious-engine_0~git20230724+dfsg-1.dsc
Distribution: unstable
Section: contrib/games
Priority: optional
Homepage: https://github.com/ptitSeb/Serious-Engine
Closes bugs: #1034630

Changelog

 serious-engine (0~git20230724+dfsg-1) unstable; urgency=low
 .
   * Initial release. Closes: #1034630

QA information

Comments

  1. Hi Sebastien,

Package is looking good.

A minor one is 'lrc' reporting possible license/'debian/copyright' issue. See below.

en: Versions: recon 1.10.1  check 3.3.9-1

Parsing Source Tree  ....
Reading copyright    ....
Running licensecheck ....

d/copyright     | licensecheck

GPL-2           | GPL-2+ with Bison-1.24 exception Sources/bison.simple
GPL-2           | GPL-2+ with Bison-1.24 exception Sources/Ecc/bison.simple
GPL-2           | GPL-2+ with Bison-2.2 exception Sources/Ecc/parser.h
GPL-2           | GPL-2+ with Bison-1.24 exception Sources/Engine/Base/bison.simple
GPL-2           | GPL-2+ with Bison-2.2 exception Sources/Engine/Base/parser.h
GPL-2           | GPL-2+ with Bison-1.24 exception Sources/Engine/Ska/bison.simple

Regards

Phil
    Needs work Phil Wyett at May 27, 2024, 8:56 p.m. 
  2. Hi,

Didn't know about 'lrc', thanks !
[fixed]

br,
Sébastien
    Sébastien Noel at May 28, 2024, 7:01 a.m.

Upload #1

Information

Version: 0~git20230724+dfsg-1
Uploaded: 2024-03-09 12:31
Source package: serious-engine_0~git20230724+dfsg-1.dsc
Distribution: unstable
Section: contrib/games
Priority: optional
Closes bugs: #1034630

Changelog

 serious-engine (0~git20230724+dfsg-1) unstable; urgency=low
 .
   * Initial release. Closes: #1034630

QA information

Comments

  1. Hi,

Thanks for taking the time to package this application for Debian.

Could you add the 'VCS' and 'Homepage' fields?

I see 'Homepage' could be: https://github.com/Croteam-official/Serious-Engine

The 'VCS' fields could be your salsa repo[1], once you have done an import of the original sources etc.

[1] https://salsa.debian.org/twolife/serious-engine

Regards

Phil
    Needs work Phil Wyett at May 24, 2024, 5:20 p.m. 
  2. Hi,
thanks for the review!

> Could you add the 'VCS' and 'Homepage' fields?

I just added 'Homepage'

> The 'VCS' fields could be your salsa repo[1], once you have done an import of the original sources etc.

Why should I waste diskspace on Salsa by cloning what is already available elsewhere (github + orig.tar.gz) ?
I have seen plenty of repositories on Salsa that only host the debian/ subdirectory

br,
Sébastien
    Sébastien Noel at May 27, 2024, 7:35 p.m. 
  3. Hi Sebastien,

Thanks for adding the homepage.

If working with just 'debian/' on salsa is your way then that is good. We all have ways we do things and I certainly would not attempt to force a different workflow upon you.

I will have a look at your new upload shortly.

Regards

Phil
    Phil Wyett at May 27, 2024, 8:38 p.m.