I have no decision making athority within the Debian Project. You may reject this review if you wish.
Aryan,
Review of upload: 2025-08-03 03:12
Test 1 (reproducibility): Information only, not a blocker
Not being performed until bug below is fixed and accurate documentation written.
Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1108550
Test 2 (pbuilder build): Information only
* Good
Test 3 (pbuilder build --twice): Information only
* Good
Test 4 (sbuild): Information only
Lintian:
Running lintian...
N:
W: python3-textual-serve: privacy-breach-generic [<link\n rel="stylesheet"\n href="https://fonts.googleapis.com/css?family=roboto%20mono"\n />] (https://fonts.googleapis.com/css?family=roboto%20mono) [usr/lib/python3/dist-packages/textual_serve/templates/app_index.html]
N:
N: This package creates a potential privacy breach by fetching data from an
N: external website at runtime. Please remove these scripts or external HTML
N: resources.
N:
N: Please replace any scripts, images, or other remote resources with
N: non-remote resources. It is preferable to replace them with text and links
N: but local copies of the remote resources are also acceptable as long as
N: they don't also make calls to remote services. Please ensure that the
N: remote resources are suitable for Debian main before making local copies
N: of them.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: files/privacy-breach
N:
N:
I: python3-textual-serve: font-in-non-font-package [usr/lib/python3/dist-packages/textual_serve/static/fonts/RobotoMono-Italic-VariableFont_wght.ttf]
N:
N: This package contains a *.ttf, *.otf, or *.pfb file, file extensions used
N: by TrueType, OpenType, or Type 1 fonts, but the package does not appear to
N: be a dedicated font package. Dedicated font package names should begin
N: with fonts-. (Type 1 fonts are also allowed in packages starting with
N: xfonts-.) If the font is already packaged, you should depend on that
N: package instead. Otherwise, normally the font should be packaged
N: separately, since fonts are usually useful outside of the package that
N: embeds them.
N:
N: Visibility: info
N: Show-Always: no
N: Check: fonts
N:
N:
I: python3-textual-serve: font-in-non-font-package [usr/lib/python3/dist-packages/textual_serve/static/fonts/RobotoMono-VariableFont_wght.ttf]
N:
I: python3-textual-serve: font-outside-font-dir [usr/lib/python3/dist-packages/textual_serve/static/fonts/RobotoMono-Italic-VariableFont_wght.ttf]
N:
N: This package contains a TrueType, OpenType, or Type 1 fonts, but the
N: package does not install this file under /usr/share/fonts/.
N:
N: Please refer to https://wiki.debian.org/Fonts/PackagingPolicy for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: fonts
N:
N:
I: python3-textual-serve: font-outside-font-dir [usr/lib/python3/dist-packages/textual_serve/static/fonts/RobotoMono-VariableFont_wght.ttf]
N:
P: python3-textual-serve: image-file-in-usr-lib [usr/lib/python3/dist-packages/textual_serve/static/images/background.png]
N:
N: This package installs a pixmap or a bitmap within /usr/lib. According to
N: the Filesystem Hierarchy Standard, architecture-independent files should
N: be placed within /usr/share instead.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: images
N:
N:
P: python-textual-serve source: package-does-not-install-examples [examples/]
N:
N: The original source tarball contains the specified examples directory.
N: However, no examples are installed in any binary packages.
N:
N: Please use dh_installexamples to install these to the most relevant
N: package, for example by adding the directory name followed by a wildcard
N: to a debian/pkgname.examples file.
N:
N: Lintian looks for any directory called examples under /usr/share/doc in
N: all binary packages.
N:
N: Please refer to the dh_installexamples(1) manual page for details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: examples
N:
N: Screen: examples/in-tests
N: Advocates: "Scott Kitterman" <debian@kitterman.com>
N: Reason:
N: Some sources like python-tomlkit trigger this tag for tests because of files
N: in ./tests/examples/. They are not examples for tomlkit, however. They are
N: examples of TOML files used in the tests.
N:
N: Overall, the check is probably better off not looking in test
N: directories.
N:
N: Read more in Bug#1005184.
N:
N:
P: python-textual-serve source: source-contains-prebuilt-javascript-object [src/textual_serve/static/js/textual.js]
N:
N: The source tarball contains a prebuilt (minified) JavaScript object. They
N: are usually left by mistake when generating the tarball by not cleaning
N: the source directory first. You may want to report this as an upstream
N: bug, in case there is no sign that this was intended.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: files/source-missing
N:
N:
P: python-textual-serve source: trailing-whitespace [debian/control:33]
N:
N: This file contains lines with trailing whitespace characters.
N:
N: Whilst often harmless and unsightly, such extra whitespaces can also cause
N: tools to interpret the whitespace characters literally. The tool diff(1)
N: does not like them, either. They are best avoided.
N:
N: Some of these problems can be hard to track down.
N:
N: Whitespace at the end of lines may be removed with the following:
N:
N: $ sed -i -e 's@[[:space:]]*$@@g' debian/control debian/changelog
N:
N: If you use Emacs, you can also use "M-x wh-cl" (whitespace-cleanup).
N:
N: However, if you wish to only remove trailing spaces and leave trailing
N: tabs (eg. for Makefiles), you can use the following code snippet:
N:
N: $ sed -i -e 's@[ ]*$@@g' debian/rules
N:
N: To remove empty lines from the end of a file, you can use:
N:
N: $ sed -i -e :a -e '/^\n*$/{$d;N;};/\n$/ba' debian/rules
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/trailing-whitespace
N: Renamed from: file-contains-trailing-whitespace
N:
N:
P: python-textual-serve source: trailing-whitespace [debian/rules:7]
E: Lintian run failed (policy violation)
Test 5 (ratt): Information only, not a blocker
Note: Possible false positives.
Test 6 (debian/watch): Information only
* Good
Test 7 (licenserecon): Information only
philwyett@ks-tarkin:~/build/python-textual-serve-1.1.2$ lrc
en: Versions: licenserecon '6.0' licensecheck '3.3.9-1'
Parsing Source Tree ....
Reading d/copyright ....
Running licensecheck ....
d/copyright | licensecheck
Expat | Apache-2.0 src/textual_serve/static/fonts/RobotoMono-Italic-VariableFont_wght.ttf
Expat | Apache-2.0 src/textual_serve/static/fonts/RobotoMono-VariableFont_wght.ttf
Summary
=======
A few lintian things.
It would be nice to remove the fonts from the package and use debian packaged system fonts.
Regards
Phil
Needs work
Phil Wyett at Aug. 3, 2025, 2:39 p.m.
