Sign me up Login

Details about package python-opower

Name: python-opower
Uploader: Sourav Bhattacharya <souravbhattacharya@tutamail.com> (Debian QA page)
Description: python3-opower - Python library to get usage/cost from utilities

Package uploads

Upload #2

Information

Version: 0.8.3-1
Uploaded: 2024-10-13 06:25
Source package: python-opower_0.8.3-1.dsc
Distribution: unstable
Section: python
Priority: optional
Homepage: https://github.com/tronikos/opower
Vcs-Browser: https://salsa.debian.org/sxctic-54l/python-opower
Vcs-Git: https://salsa.debian.org/sxctic-54l/python-opower.git
Closes bugs: #1084967

Changelog

 python-opower (0.8.3-1) unstable; urgency=medium
 .
   * Initial release. (Closes: #1084967)

QA information

Comments

  1. The lintian override needs to be specific to the html files. The current one is overly broad and risks hiding problems elsewhere detected by future lintian versions or upstream releases.

For an example, see https://salsa.debian.org/jcfp/puremagic/-/blob/ac6ecff7e2e17cdbd00d2538ce984023b150a994/debian/source/lintian-overrides

As you can see, the asterisks in there can be used for globbing. The tricky part is balancing that in a way prevents trivial upstream changes (e.g. the cause of the lintian hit moving to a different line) from invalidating the override, whilst also avoiding making the override so broad that it ends up hiding problems elsewhere (things like keeping filenames in an override is often a good idea).
    Needs work jcfp at Oct. 19, 2024, 4:24 p.m. 
  2. Sourav,

Preamble...

Thank you for taking the time to prepare this package and your contribution to the Debian project.

This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Good

2. Lintian [3]: Good

3. Licenses [4]: Good

4. Watch file [uscan --force-download]: Good

5. Build Twice (build source after successful build [1]: Good

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Good

8. Upgrade [Over previous installs if any]: N/A

Additional...

A. 'debian/sources/lintian-overrides' currently serves no purpose.

Summary...

Package is in good shape, but I would remove the not necessary overrides file.

Please try the below on your packages...

[1] pbuilder:

  * Command for 1.: sudo pbuilder build <PACKAGE>.dsc
  * Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild -d unstable <PACKAGE>.dsc
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian --display-info --verbose --fail-on error --info --pedantic --show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

  Note: Please report false positives as bug reports against 'licenserecon'.

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
  
Regards

Phil
    Needs work Phil Wyett at Jan. 19, 2025, 9:17 a.m.

Upload #1

Information

Version: 0.8.3-1
Uploaded: 2024-10-12 13:10
Source package: python-opower_0.8.3-1.dsc
Distribution: unstable
Section: python
Priority: optional
Homepage: https://github.com/tronikos/opower
Vcs-Browser: https://salsa.debian.org/sxctic-54l/python-opower
Vcs-Git: https://salsa.debian.org/sxctic-54l/python-opower.git
Closes bugs: #1084967

Changelog

 python-opower (0.8.3-1) unstable; urgency=medium
 .
   * Initial release. (Closes: #1084967)

QA information

Comments

  1. I see you're a quick learner! really nice work, I just have one suggestion and found one real issue (apart from the team-related stuff you are already aware of):

* control: in the long description, the standard way for lists seems to use asterisks (see the "codelite" package for an example).

* d/missing-sources lists two HTML files that are identical to the files found under tests/opower/utilities/smud/. Storing an exact copy of files with (supposedly) missing sources obviously isn't the idea behind this directory; rather, it's meant for the actual missing source code. That said, in this particular case the files aren't part of the program's code but only used as test data. In that context, there's nothing missing. Please remove the d/missing-sources directory; if you added this because of a lintian hit, override it with a comment indicating the two files serve no other purpose than test data.
    Needs work jcfp at Oct. 12, 2024, 2:51 p.m.