Details about package python-hepunits
Package uploads
Upload #3
Information
Changelog
python-hepunits (2.3.6-1) unstable; urgency=medium
.
* Initial release. (Closes: #1108844)
Comments
No comments
Upload #2
Information
Changelog
python-hepunits (2.3.6-1) unstable; urgency=medium
.
* Initial release. (Closes: #1108844)
Comments
-
P: python-hepunits source: trailing-whitespace [debian/control:28]
N:
N: This file contains lines with trailing whitespace characters.
N:
N: Whilst often harmless and unsightly, such extra whitespaces can also cause
N: tools to interpret the whitespace characters literally. The tool diff(1)
N: does not like them, either. They are best avoided.
N:
N: Some of these problems can be hard to track down.
N:
N: Whitespace at the end of lines may be removed with the following:
N:
N: $ sed -i -e 's@[[:space:]]*$@@g' debian/control debian/changelog
N:
N: If you use Emacs, you can also use "M-x wh-cl" (whitespace-cleanup).
N:
N: However, if you wish to only remove trailing spaces and leave trailing
N: tabs (eg. for Makefiles), you can use the following code snippet:
N:
N: $ sed -i -e 's@[ ]*$@@g' debian/rules
N:
N: To remove empty lines from the end of a file, you can use:
N:
N: $ sed -i -e :a -e '/^\n*$/{$d;N;};/\n$/ba' debian/rules
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/trailing-whitespace
N: Renamed from: file-contains-trailing-whitespace
Phil Wyett at July 10, 2025, 4:55 a.m.
-
Thanks, I have made another upload fixing the trailing whitespaces in debian/control in upload#3
Aryan Karamtoth at July 10, 2025, 5:18 a.m.
Upload #1
Information
Changelog
python-hepunits (2.3.6-1) unstable; urgency=medium
.
* Initial release. (Closes: #1108844)
Comments
-
Aryan,
Review of upload: 2025-07-10 03:27
For information about the tests run, see:
https://wiki.debian.org/PhilWyett/DebianMentoring
Note: If test line removed, it indicates a test pass.
Test 3 (build twice): Information only
dpkg-source -b .
dpkg-source: info: using options from python-hepunits-2.3.6/debian/source/options: --extend-diff-ignore=^[^/]*[.]egg-info/
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building python-hepunits using existing ./python-hepunits_2.3.6.orig.tar.gz
dpkg-source: info: local changes detected, the modified files are:
python-hepunits-2.3.6/src/hepunits/_version.py
dpkg-source: hint: make sure the version in debian/changelog matches the unpacked source tree
dpkg-source: hint: you can integrate the local changes with dpkg-source --commit
dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/python-hepunits_2.3.6-1.diff._3u2G3
dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
I: copying local configuration
E: Failed autobuilding of package
Test 4 (sbuild): Information only
Lintian:
Running lintian...
N:
P: python-hepunits source: trailing-whitespace [debian/control:28]
N:
N: This file contains lines with trailing whitespace characters.
N:
N: Whilst often harmless and unsightly, such extra whitespaces can also cause
N: tools to interpret the whitespace characters literally. The tool diff(1)
N: does not like them, either. They are best avoided.
N:
N: Some of these problems can be hard to track down.
N:
N: Whitespace at the end of lines may be removed with the following:
N:
N: $ sed -i -e 's@[[:space:]]*$@@g' debian/control debian/changelog
N:
N: If you use Emacs, you can also use "M-x wh-cl" (whitespace-cleanup).
N:
N: However, if you wish to only remove trailing spaces and leave trailing
N: tabs (eg. for Makefiles), you can use the following code snippet:
N:
N: $ sed -i -e 's@[ ]*$@@g' debian/rules
N:
N: To remove empty lines from the end of a file, you can use:
N:
N: $ sed -i -e :a -e '/^\n*$/{$d;N;};/\n$/ba' debian/rules
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/trailing-whitespace
N: Renamed from: file-contains-trailing-whitespace
N:
N:
P: python-hepunits source: trailing-whitespace [debian/control:31]
N:
P: python-hepunits source: trailing-whitespace [debian/control:34]
N:
P: python-hepunits source: trailing-whitespace [debian/control:35]
N:
P: python-hepunits source: trailing-whitespace [debian/control:37]
N:
P: python-hepunits source: trailing-whitespace [debian/control:38]
N:
P: python-hepunits source: trailing-whitespace [debian/control:39]
I: Lintian run was successful.
Summary
=======
Looks promising. A few items above to to reviewed and corrected.
Regards
Phil
Needs work
Phil Wyett at July 10, 2025, 3:44 a.m.
-
Hi, thanks for the review. I noticed that in test 3, it shows that there's changes in a file called _version.py but the file that's actually there in the source folder is _version.pyi and running dpkg-source --commit says there are no changes to commit.
Also I'm adding a new line at the end of debian/control otherwise the lintian test in sbuild fails.
Needs work
Aryan Karamtoth at July 10, 2025, 3:57 a.m.
-
Hi,
The '_version.py' is a generated file that is not cleaned correctly for a double build.
Easy fix:
* Add file 'debian/clean'.
* Add text 'src/hepunits/_version.py' into 'debian/clean'
Regards
Phil
Phil Wyett at July 10, 2025, 4:11 a.m.
-
Hi, thanks for the trick. I have made another upload containing the changes you suggested. I hope everything works fine now.
Also if you have time can you also re-review my package python-googlesearch that you reviewed a few days ago? I have made changes to it.
Needs work
Aryan Karamtoth at July 10, 2025, 4:43 a.m.
-
Hi,
P: python-hepunits source: trailing-whitespace [debian/control:28]
N:
N: This file contains lines with trailing whitespace characters.
N:
N: Whilst often harmless and unsightly, such extra whitespaces can also cause
N: tools to interpret the whitespace characters literally. The tool diff(1)
N: does not like them, either. They are best avoided.
N:
N: Some of these problems can be hard to track down.
N:
N: Whitespace at the end of lines may be removed with the following:
N:
N: $ sed -i -e 's@[[:space:]]*$@@g' debian/control debian/changelog
N:
N: If you use Emacs, you can also use "M-x wh-cl" (whitespace-cleanup).
N:
N: However, if you wish to only remove trailing spaces and leave trailing
N: tabs (eg. for Makefiles), you can use the following code snippet:
N:
N: $ sed -i -e 's@[ ]*$@@g' debian/rules
N:
N: To remove empty lines from the end of a file, you can use:
N:
N: $ sed -i -e :a -e '/^\n*$/{$d;N;};/\n$/ba' debian/rules
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/trailing-whitespace
N: Renamed from: file-contains-trailing-whitespace
Regards
Phil
Needs work
Phil Wyett at July 10, 2025, 4:55 a.m.
