Details about package python-google-api-python-client
| Name: |
python-google-api-python-client
(PTS)
|
| Uploader: |
Don Xu
<me@eipi.fun>
(Debian QA page)
|
| Description: |
python3-google-api-python-client - Google API Client Library for Python - Python 3.x |
Package uploads
Upload #1
Information
Changelog
python-google-api-python-client (2.154.0-1) unstable; urgency=medium
.
* New upstream release v2.154.0
* Declare conflicts (Closes: #1085391)
Comments
-
Don,
Preamble...
Thank you for taking the time to prepare this package and your contribution to the Debian project.
The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Information only
Running lintian...
N:
I: python-google-api-python-client source: patch-not-forwarded-upstream [debian/patches/0001_ignore_tests_requiring_credentials_from_google.patch]
N:
N: According to the DEP-3 headers, this patch has not been forwarded
N: upstream.
N:
N: Please forward the patch and try to have it included in upstream's version
N: control system. If the patch is not suitable for that, please mention
N: not-needed in the Forwarded field of the patch header.
N:
N: Please refer to social contract item 2, Coordination with upstream
N: developers (Section 3.1.4) in the Debian Developer's Reference, Changes to
N: the upstream sources (Section 4.3) in the Debian Policy Manual, and
N: Bug#755153 for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/patches/dep3
N: Renamed from: send-patch
N:
N:
N: masked by screen python/egg/metadata
M: python3-google-api-python-client: package-contains-documentation-outside-usr-share-doc [usr/lib/python3/dist-packages/google_api_python_client-2.154.0.dist-info/top_level.txt]
N:
N: This package ships a documentation file outside /usr/share/doc
N: Documentation files are normally installed inside /usr/share/doc.
N:
N: If this file doesn't describe the contents or purpose of the directory it
N: is in, please consider moving this file to /usr/share/doc/ or maybe even
N: removing it. If this file does describe the contents or purpose of the
N: directory it is in, please add a lintian override.
N:
N: Visibility: info
N: Show-Always: no
N: Check: documentation
N:
N: Screen: python/egg/metadata
N: Advocates: "Scott Kitterman" <debian@kitterman.com>
N: Reason: The folders XXX.dist-info/ and XXX.egg-info/ hold metadata for
N: Python modules. Those files are not documentation even though
N: some of their names carry the .txt file extension.
N:
N: Python modules can be both public and private.
N:
N: Read more in
N: https://www.python.org/dev/peps/pep-0427/#the-dist-info-directory,
N: https://www.python.org/dev/peps/pep-0376/#id16,
N: https://www.python.org/dev/peps/pep-0610/,
N: https://www.python.org/dev/peps/pep-0639/,
N: https://setuptools.pypa.io/en/latest/deprecated/python_eggs.html,
N: and Bug#1003913.
N:
I: Lintian run was successful.
3. Licenses [4]: Issue, false positives possible
philwyett@ks-tarkin:~/Development/builder/debian/python-google-api-python-client-2.154.0$ lrc
en: Versions: recon 3.2 check 3.3.9-1
Parsing Source Tree ....
Reading d/copyright ....
Running licensecheck ....
d/copyright | licensecheck
Apache-2.0 | PostgreSQL googleapiclient/discovery_cache/documents/alloydb.v1alpha.json
Apache-2.0 | PostgreSQL googleapiclient/discovery_cache/documents/alloydb.v1beta.json
Apache-2.0 | PostgreSQL googleapiclient/discovery_cache/documents/alloydb.v1.json
MIT | Expat googleapiclient/mimeparse.py
If false positives, could the issue be reported against 'licenserecon' package please.
4. Watch file [uscan --force-download]: Good
5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Good
8. Upgrade [Over previous installs if any]: Good
Summary...
Looking good. Maybe some license issues to look at.
Regards
Phil
[1] pbuilder:
* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
Needs work
Phil Wyett at Dec. 11, 2024, 9:42 a.m.
-
I confirm that googleapiclient/discovery_cache/documents/alloydb.v1alpha.json is not licensed under PostgreSQL, besides MIT and Expat are nearly the same.
Ready
Don Xu at Dec. 11, 2024, 12:32 p.m.
-
Hi Don,
That being the case, I will mark this as ready. The best way now is to file an RFS and we can get this in front of more DDs that way.
regards
Phil
Ready
Phil Wyett at Dec. 14, 2024, 7:54 p.m.
