Ben,
Preamble...
Thank you for taking the time to prepare this package and your contribution to the Debian project.
This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Good
3. Licenses [4]: Good
4. Watch file [uscan --force-download]: Good
5. Build Twice (build source after successful build [1]: Good
6. Reproducible builds [5]: None blocking. Issue with reprotest you may wish to report
make[1] : on quitte le répertoire « /tmp/reprotest.O17Ojc/const_build_path/const_build_path/obj-x86_64-linux-gnu »
dh_installdocs
dh_installchangelogs
dh_installman
dh_lintian
dh_icons
dh_perl
dh_link
dh_strip_nondeterminism
dh_compress
dh_fixperms
dh_missing
dh_dwz -a
dh_strip -a
dh_makeshlibs -a
dh_shlibdeps -a
dh_installdeb
dh_gencontrol
dh_md5sums
dh_builddeb
dpkg-deb: construction du paquet « prismlauncher-dbgsym » dans « ../prismlauncher-dbgsym_9.2+ds-1_amd64.deb ».
dpkg-deb: construction du paquet « prismlauncher » dans « ../prismlauncher_9.2+ds-1_amd64.deb ».
dpkg-genbuildinfo --build=binary -O../prismlauncher_9.2+ds-1_amd64.buildinfo
dpkg-genchanges --build=binary -O../prismlauncher_9.2+ds-1_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
dpkg-source --after-build .
dpkg-buildpackage: info: binary-only upload (no source included)
sudo: impossible de trouver le nom du terminal pour le périphérique 136, 1
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/reprotest/__init__.py", line 862, in run
return 0 if check_func(*check_args) else 1
^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/reprotest/__init__.py", line 417, in check_auto
if is_reproducible("1", var_x1):
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/reprotest/__init__.py", line 411, in <lambda>
is_reproducible = lambda name, var: test_args.check_reproducible(proc, dist_x0, name, var)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/reprotest/__init__.py", line 353, in check_reproducible
raise RuntimeError("diffoscope exited non-boolean %s, can't continue" % retcode)
RuntimeError: diffoscope exited non-boolean -9, can't continue
7. Install [No previous installs]: Good
8. Upgrade [Over previous installs if any]: N/A
Summary...
I believe 'prismlauncher' is ready for review/possible sponsorship.
If you do not have a sponsor, you can follow the RFS process, link below.
https://mentors.debian.net/sponsors/rfs-howto/
Please try the below on your packages...
[1] pbuilder:
* Command for 1.: sudo pbuilder build <PACKAGE>.dsc
* Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild -d unstable <PACKAGE>.dsc
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian --display-info --verbose --fail-on error --info --pedantic --show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
Note: Please report false positives as bug reports against 'licenserecon'.
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
Regards
Phil
Ready
Phil Wyett at Jan. 20, 2025, 2:30 p.m.
