Details about package molotov
Package uploads
Upload #3
Information
Changelog
molotov (1.3-1) unstable; urgency=medium
.
* Bump standards version to 4.7.0.2
* New upstream release (v1.3)
Comments
-
Cezar,
Preamble...
Thank you for taking the time to prepare this package and your contribution to the Debian project.
This review is offered to help package contributors to Debian mentors improve their packages (where needed) prior to possible sponsorship into Debian by a Debian Developer.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Good
3. Licenses [4]: Good
4. Watch file [uscan --force-download]: Good
5. Build Twice (build source after successful build) [1]: Good
6. Reproducible builds [5]: Good
Note: This test does not block sponsorship and is for information only at this time. It is good if a package passes this test.
7. Tail of the ratt (architecture dependant packages only) [6]: Good
Note: This test does not block sponsorship and is for information only at this time. It is good if a package passes this test.
8. Install [No previous installs]: Good
9. Upgrade [Over previous installs if any]: Good
Summary...
I believe 'molotov' is ready for review/possible sponsorship.
If you do not have upload rights or a regular sponsor. You can follow the RFS process linked to below.
https://mentors.debian.net/sponsors/rfs-howto/
Please try the below on your packages...
[1] pbuilder:
* Command for 1.: sudo pbuilder build <PACKAGE>.dsc
* Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild -d unstable <PACKAGE>.dsc
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian --display-info --verbose --fail-on error --info --pedantic --show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
Note: Please report false positives as bug reports against 'licenserecon'.
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
[6] ratt
* Command: ratt --dist=<YOUR_DISTRIBUTION> <PACKAGE>_<VERSION>-<DEBIAN_REVISION>_<ARCHITECTURE>.changes
* Document: https://manpages.debian.org/unstable/ratt/ratt.1.en.html
Regards
Phil
Ready
Phil Wyett at Jan. 26, 2025, 10:13 p.m.
Upload #2
Information
Changelog
molotov (1.3-1) unstable; urgency=medium
.
* Bump standards version to 4.6.1
* New upstream release (v1.3)
Comments
-
Hi Cezar,
The latest standards version is 4.7.0.2.
https://www.debian.org/doc/debian-policy/
Regards
Phil
Needs work
Phil Wyett at Jan. 24, 2025, 3:47 a.m.
Upload #1
Information
Changelog
molotov (1.3-1) unstable; urgency=medium
.
* Bump standards version to 4.6.1
* New upstream release (v1.3)
Comments
-
Cezar,
Preamble...
Thank you for taking the time to prepare this package and your contribution to the Debian project.
This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Issue
Running lintian...
N:
W: molotov: debian-changelog-has-wrong-day-of-week 2024-11-10 was a Sunday [usr/share/doc/molotov/changelog.Debian.gz:1]
N:
N: The date in the changelog entry is not consistent with the actual day of
N: that week. Either the date is wrong or the day of week is wrong.
N:
N: To avoid problems like this, consider using a tool like dch(1) or date(1)
N: to generate the date. Example:
N:
N: $ date -R -ud '2013-11-05 23:59:59'
N: Tue, 05 Nov 2013 23:59:59 +0000
N:
N: Visibility: warning
N: Show-Always: no
N: Check: debian/changelog
N: Renamed from: debian-changelog-has-wrong-weekday
N:
N:
I: molotov source: out-of-date-standards-version 4.6.1 (released 2022-05-11) (current is 4.7.0)
N:
N: The source package refers to a Standards-Version older than the one that
N: was current at the time the package was created (according to the
N: timestamp of the latest debian/changelog entry). Please consider updating
N: the package to current Policy and setting this control field
N: appropriately.
N:
N: If the package is already compliant with the current standards, you don't
N: have to re-upload the package just to adjust the Standards-Version control
N: field. However, please remember to update this field next time you upload
N: the package.
N:
N: See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
N: debian-policy package for a summary of changes in newer versions of
N: Policy.
N:
N: Please refer to
N: https://www.debian.org/doc/debian-policy/upgrading-checklist.html for
N: details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: fields/standards-version
N:
E: Lintian run failed (runtime error
3. Licenses [4]: Good
4. Watch file [uscan --force-download]: Good
5. Build Twice (build source after successful build [1]: Good
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Good
8. Upgrade [Over previous installs if any]: Good
Summary...
Cezar, Looks good, just two lintian issyes to resolve.
If you do not have a regular sponsor, I would encourage you to use the RFS process linked to below.
https://mentors.debian.net/sponsors/rfs-howto/
Please try the below on your packages...
[1] pbuilder:
* Command for 1.: sudo pbuilder build <PACKAGE>.dsc
* Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild -d unstable <PACKAGE>.dsc
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian --display-info --verbose --fail-on error --info --pedantic --show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
Note: Please report false positives as bug reports against 'licenserecon'.
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
Regards
Phil
Needs work
Phil Wyett at Jan. 22, 2025, 8:39 a.m.