Sign me up Login

Details about package makemkv-oss

Name: makemkv-oss
Uploader: Ben Westover <me@benthetechguy.net> (Debian QA page)
Description: makemkv - Convert video that you own into free format that can be played everywhere
libdriveio0 - LibreDrive access library
libmakemkv1 - MKV multiplexer library
libmmbd0 - MakeMKV Blu-Ray decryption API library

Package uploads

Upload #5

Information

Version: 1.18.1+ds-1
Uploaded: 2025-05-25 21:41
Source package: makemkv-oss_1.18.1+ds-1.dsc
Distribution: unstable
Section: non-free/video
Priority: optional
Homepage: https://makemkv.com/
Vcs-Git: https://salsa.debian.org/benthetechguy/makemkv-oss.git
Vcs-Browser: https://salsa.debian.org/benthetechguy/makemkv-oss
Closes bugs: #1003815

Changelog

 makemkv-oss (1.18.1+ds-1) unstable; urgency=medium
 .
   * Initial Package (Closes: #1003815)

QA information

Comments

  1. Ben,

Looks good here. Not sure if you have a sponsor, if not you can always file an RFS.

Regards

Phil
    Ready Phil Wyett at May 27, 2025, 6:02 a.m.

Upload #4

Information

Version: 1.18.1+ds-1
Uploaded: 2025-05-25 21:27
Source package: makemkv-oss_1.18.1+ds-1.dsc
Distribution: unstable
Section: non-free/video
Priority: optional
Homepage: https://makemkv.com/
Vcs-Git: https://salsa.debian.org/benthetechguy/makemkv-oss.git
Vcs-Browser: https://salsa.debian.org/benthetechguy/makemkv-oss
Closes bugs: #1003815

Changelog

 makemkv-oss (1.18.1+ds-1) unstable; urgency=medium
 .
   * Initial Package (Closes: #1003815)

QA information

Comments

No comments

Upload #3

Information

Version: 1.18.1+ds-1
Uploaded: 2025-05-23 19:41
Source package: makemkv-oss_1.18.1+ds-1.dsc
Distribution: unstable
Section: non-free/video
Priority: optional
Homepage: https://makemkv.com/
Vcs-Git: https://salsa.debian.org/benthetechguy/makemkv-oss.git
Vcs-Browser: https://salsa.debian.org/benthetechguy/makemkv-oss
Closes bugs: #1003815

Changelog

 makemkv-oss (1.18.1+ds-1) unstable; urgency=medium
 .
   * Initial Package (Closes: #1003815)

QA information

Comments

  1. Ben,

Review of upload: 2025-05-23 19:41

For information about the tests run, see:

https://wiki.debian.org/PhilWyett/DebianMentoring

Test 4 (sbuild): Information only

Lintian:

I: libdriveio0: extended-description-is-probably-too-short
N: 
N:   The extended description (the lines after the first line of the
N:   "Description:" field) is only one or two lines long. The extended
N:   description should provide a user with enough information to decide
N:   whether they want to install this package, what it contains, and how it
N:   compares to similar packages. One or two lines is normally not enough to
N:   do this.
N: 
N:   Please refer to General guidelines for package descriptions (Section
N:   6.2.1) in the Debian Developer's Reference and The long description
N:   (Section 6.2.3) in the Debian Developer's Reference for details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: fields/description

Test 7 (licenserecon): Information only

philwyett@ks-tarkin:~/Development/builder/debian/makemkv-oss-1.18.1+ds$ lrc
en: Versions: licenserecon '4.2'  licensecheck '3.3.9-1'

Parsing Source Tree  ....
Reading d/copyright  ....
Running licensecheck ....

d/copyright      | licensecheck

GPL-2+ and X11   | GPL-2+ with Libtool exception autoxxx/ltmain.sh
public-domain    | FSFUL             configure
OpenSSL          | Apache-1.0 and/or OpenSSL libabi/pssl/ecdsa.h
OpenSSL          | Apache-1.0 and/or OpenSSL libabi/pssl/ecs_ossl.c
OpenSSL          | Apache-1.0 and/or OpenSSL libabi/pssl/ecs_sign.c
OpenSSL          | Apache-1.0 and/or OpenSSL libabi/pssl/ecs_vrf.c
MPL-1.1 or GPL-2+ or LGPL-2.1+| GPL-2+ and/or GPL-2+ or LGPL-2.1+ and/or MPL-1.1 libmmbd/src/fakejni.h
GPL-2+           | LGPL-2.1+         mmgpl/dvdread/logger.c
GPL-2+           | LGPL-2.1+         mmgpl/dvdread/logger.h
GPL-2+           | LGPL-2.1+         mmgpl/dvdread/version.h

Summary
=======

A few things to look at.

Also seeing the below at build time.

warning: 'SHA1_Final' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]

cc1plus: warning: '-Werror=' argument '-Werror=implicit-function-declaration' is not valid for C++

Regards

Phil
    Needs work Phil Wyett at May 25, 2025, 10:03 a.m. 
  2. Hi Phil,

Fixed the lintian and license concerns. There are a few files that lrc is just wrong about, for example the OpenSSL files are not dual licensed and the situation for libmmbd/src/fakejni.h was already accurately described.

I also fixed the implicit-function-declaration warnings, turns out the Makefile includes CFLAGS when compiling C++ files for some reason. As for the OpenSSL deprecation warnings, is that my responsibility to fix? My changes removing the deprecated function usages likely wouldn't be accepted upstream anyway; the author doesn't like people looking at his source code in the first place, he only released the source for practical reasons.

Thanks for the review!

--
Ben Westover
    Ready Ben Westover at May 25, 2025, 9:41 p.m. 
  3. Ben,

Great work,

The deprecation warnings is something you may wish to raise with upstream, nothing more. Building relationships with upstreams is something that normally ends in Debian related issues being given higher priorities etc. etc. You know the score.

Regards

Phil
    Phil Wyett at May 27, 2025, 6:01 a.m.

Upload #2

Information

Version: 1.17.9+ds-1
Uploaded: 2025-03-06 02:56
Source package: makemkv-oss_1.17.9+ds-1.dsc
Distribution: unstable
Section: non-free/video
Priority: optional
Homepage: https://makemkv.com/
Vcs-Git: https://salsa.debian.org/benthetechguy/makemkv-oss.git
Vcs-Browser: https://salsa.debian.org/benthetechguy/makemkv-oss
Closes bugs: #1003815

Changelog

 makemkv-oss (1.17.9+ds-1) unstable; urgency=medium
 .
   * Initial Package (Closes: #1003815)

QA information

Comments

No comments

Upload #1

Information

Version: 1.17.9+ds-1
Uploaded: 2025-02-10 16:56
Source package: makemkv-oss_1.17.9+ds-1.dsc
Distribution: unstable
Section: non-free/video
Priority: optional
Homepage: https://makemkv.com/
Vcs-Git: https://salsa.debian.org/benthetechguy/makemkv-oss.git
Vcs-Browser: https://salsa.debian.org/benthetechguy/makemkv-oss
Closes bugs: #1003815

Changelog

 makemkv-oss (1.17.9+ds-1) unstable; urgency=medium
 .
   * Initial Package (Closes: #1003815)

QA information

Comments

No comments