Sign me up Login

Details about package kwstyle

Name: kwstyle (PTS)
Uploader: 何庆 Ching He <heqing@rool.me> (Debian QA page)
Description: kwstyle - Style checker for source code

Package uploads

Upload #4

Information

Version: 1.1.0~git20250114.eb1e46d+ds-1
Uploaded: 2026-06-09 11:36
Source package: kwstyle_1.1.0~git20250114.eb1e46d+ds-1.dsc
Distribution: unstable
Section: devel
Priority:
Homepage: https://kitware.github.io/KWStyle/
Vcs-Browser: https://salsa.debian.org/debian/kwstyle
Vcs-Git: https://salsa.debian.org/debian/kwstyle.git
Closes bugs: #1117934

Changelog

 kwstyle (1.1.0~git20250114.eb1e46d+ds-1) unstable; urgency=medium
 .
   * Intent to Adopt (ITA) kwstyle package (Closes: #1117934)
   * New upstream version 1.1.0~git20250114.eb1e46d+ds:
     - Upstream has natively fixed FTBFS with CMake 4,
       remove the temporary NMU patch for #1113091
   * Update Maintainer to 何庆 Ching He <heqing@rool.me>
   * Update Standards-Version to 4.7.4 (routine-update)
   * Update Vcs-Git/Vcs-Browser to point to new Salsa repository (debian/kwstyle)
   * Add +ds suffix to repack upstream source:
     - Exclude bundled boost library in Utilities/boost and
       Utilities/updateBoost.sh, use system libboost-dev instead
     - Follow Debian Policy §4.13 (No bundled libraries)
   * Remove obsolete copyright paragraphs from debian/copyright:
     - The corresponding files (Utilities/KWSys/hash_fun.hxx.in,
       Utilities/KWSys/hash_map.hxx.in, Utilities/KWSys/hash_set.hxx.in,
       Utilities/KWSys/hashtable.hxx.in) no longer exist in the latest
       upstream git version
   * debian/watch: Bump format version to 5.
   * debian/control: Remove redundant Rules-Requires-Root and Priority
     fields. Align Build-Depends and Depends.
   * debian/tests: Remove superficial tests directory.
   * debian/copyright: Add Upstream-Contact. Add missing copyright
     holders for IGSTK, VTK, and RegularExpression. Correct licenses
     for update-third-party.bash and ITKHeader.h to Apache-2.0.
   * debian/changelog: Remove trailing whitespace.
   * debian/fill.copyright.blanks.yml: Remove obsolete KWSys overrides
     as the corresponding files no longer exist.

QA information

Comments

No comments

Upload #3

Information

Version: 1.1.0~git20250114.eb1e46d+ds-1
Uploaded: 2026-06-08 16:51
Source package: kwstyle_1.1.0~git20250114.eb1e46d+ds-1.dsc
Distribution: unstable
Section: devel
Priority:
Homepage: https://kitware.github.io/KWStyle/
Vcs-Browser: https://salsa.debian.org/debian/kwstyle
Vcs-Git: https://salsa.debian.org/debian/kwstyle.git
Closes bugs: #1117934

Changelog

 kwstyle (1.1.0~git20250114.eb1e46d+ds-1) unstable; urgency=medium
 .
   * Intent to Adopt (ITA) kwstyle package (Closes: #1117934)
   * New upstream version 1.1.0~git20250114.eb1e46d+ds:
     - Upstream has natively fixed FTBFS with CMake 4,
       remove the temporary NMU patch for #1113091
   * Update Maintainer to 何庆 Ching He <heqing@rool.me>
   * Update Standards-Version to 4.7.4 (routine-update)
   * Update Vcs-Git/Vcs-Browser to point to new Salsa repository (debian/kwstyle)
   * Add +ds suffix to repack upstream source:
     - Exclude bundled boost library in Utilities/boost and
       Utilities/updateBoost.sh, use system libboost-dev instead
     - Follow Debian Policy §4.13 (No bundled libraries)
   * Remove obsolete copyright paragraphs from debian/copyright:
     - The corresponding files (Utilities/KWSys/hash_fun.hxx.in,
       Utilities/KWSys/hash_map.hxx.in, Utilities/KWSys/hash_set.hxx.in,
       Utilities/KWSys/hashtable.hxx.in) no longer exist in the latest
       upstream git version
   * debian/watch: Bump format version to 5.
   * debian/control: Remove redundant Rules-Requires-Root and Priority
     fields. Align Build-Depends and Depends.
   * debian/tests: Remove superficial tests directory.
   * debian/copyright: Add Upstream-Contact. Add missing copyright
     holders for IGSTK, VTK, and RegularExpression. Correct licenses
     for update-third-party.bash and ITKHeader.h to Apache-2.0.
   * debian/changelog: Remove trailing whitespace.
   * debian/fill.copyright.blanks.yml: Remove obsolete KWSys overrides
     as the corresponding files no longer exist.

QA information

Comments

  1. d/watch: some lines are useless.
d/watch should be:
https://paste.debian.net/plainh/1a02c009

And I suggest you use + for ~git as well.
1.1.0~git20250114.eb1e46d+ds-1   -->   1.1.0+git20250114.eb1e46d+ds-1

==============================

Your d/copyright is terrible!
There are many things that need to be corrected.
Please check all files once with (grep 'copyright' -ir .)
It has strange syntax and many things are not correct.
For example, the following may not be all the problems!


Please combine sections that have the same license.
For example:

Files: *
Copyright: Kitware, Inc.
License: BSD-Kitware

Files: CMake/*
Copyright: 2020 Hans Johnson
License: BSD-Kitware

should be:

Files: *
Copyright:
 Kitware, Inc.
 2020 Hans Johnson
License: BSD-Kitware

or another example:

Files:
 Testing/*
 Utilities/update-third-party.bash
 Web/headers/ITKHeader.h
 kwsHeader.h
 metaCommand.cxx
 metaCommand.h
Copyright: NumFOCUS
License: Apache-2.0

==============================

In these cases (the same license and the same holder), to combine files, you can also combine years.

for example:

Files:
 file_1
 file_2
Copyright:
 2010 holder_1
 2015 holder_2
License: BSD-Kitware

Files: file_3
Copyright: 2020 holder_1
License: BSD-Kitware

TO:

Files:
 file_1
 file_2
 file_3
Copyright:
 2010, 2020 holder_1     (or 2010-2020 holder_1)
 2015 holder_2
License: BSD-Kitware

==============================

You wrote some copyright holders wrong.

ISIS Georgetown University. All rights reserved.    ->    ISIS Georgetown University

1986 by University of Toronto    ->    1986 University of Toronto

Ken Martin, Will Schroeder, Bill Lorensen   ->
Copyright:
 Ken Martin
 Will Schroeder
 Bill Lorensen

==============================

Another missing author:
Web/headers/SOVHeader.h:  Copyright (c) 2002 CADDLab @ UNC. All rights reserved.

==============================

In Web/headers/CMakeHeader.h, both Kitware, Inc. and NumFOCUS are mentioned.
    Needs work Seyed Mohamad Amin Modaresi at June 9, 2026, 8:29 a.m. 
  2. Hi,  

Thank you very much for your detailed review and suggestions! I have carefully updated the package. Here are the explanations for the decisions and modifications I made based on your feedback:  

1. Regarding debian/copyright cleanups and NumFOCUS files:
You are completely right. I have removed all the autogenerated "foo" placeholders in the standalone license paragraphs (Apache-2.0, BSD-3-clause, Zlib). I also adopted your excellent suggestion to combine the explicit files belonging to NumFOCUS into a single paragraph to make the file cleaner without expanding the copyright scope. I also fixed the holder names (ISIS Georgetown University, University of Toronto) and formatted Ken Martin, Will Schroeder, and Bill Lorensen into multi-line entries as per DEP-5 best practices.  

2. Regarding the combination of Files: * and Files: CMake/*:
I decided to keep them separate. If I put "Hans Johnson" under Files: *, it legally implies he holds copyright over the entire repository, which is factually incorrect. I prefer to retain the precise path attributions for strict legal accuracy, even if it adds a few more lines.

3. Regarding the versioning (+git vs ~git):
I kept the ~git suffix intentionally. According to the Debian Policy Manual on version sorting, the tilde ~ sorts before an empty string. Since this is a pre-release snapshot, using 1.1.0~git... ensures that when the actual upstream 1.1.0 is released, dpkg will correctly consider the official 1.1.0 as a newer version than this snapshot. Using +git would break the future upgrade path because dpkg evaluates 1.1.0+git as newer than 1.1.0.

4. Regarding the empty lines in debian/watch:
The empty lines are kept intentionally as they are part of the standard format generated by uscan's prompts. It improves readability and remains fully compliant with the standard format.

I have pushed the new changes and uploaded the updated package. Thank you again for your time and guidance!
    何庆 Ching He at June 9, 2026, 9:29 a.m.

Upload #2

Information

Version: 1.1.0~git20250114.eb1e46d+ds-1
Uploaded: 2026-06-08 16:36
Source package: kwstyle_1.1.0~git20250114.eb1e46d+ds-1.dsc
Distribution: unstable
Section: devel
Priority:
Homepage: https://kitware.github.io/KWStyle/
Vcs-Browser: https://salsa.debian.org/debian/kwstyle
Vcs-Git: https://salsa.debian.org/debian/kwstyle.git
Closes bugs: #1117934

Changelog

 kwstyle (1.1.0~git20250114.eb1e46d+ds-1) unstable; urgency=medium
 .
   * Intent to Adopt (ITA) kwstyle package (Closes: #1117934)
   * New upstream version 1.1.0~git20250114.eb1e46d+ds:
     - Upstream has natively fixed FTBFS with CMake 4,
       remove the temporary NMU patch for #1113091
   * Update Maintainer to 何庆 Ching He <heqing@rool.me>
   * Update Standards-Version to 4.7.4 (routine-update)
   * Update Vcs-Git/Vcs-Browser to point to new Salsa repository (debian/kwstyle)
   * Add +ds suffix to repack upstream source:
     - Exclude bundled boost library in Utilities/boost and
       Utilities/updateBoost.sh, use system libboost-dev instead
     - Follow Debian Policy §4.13 (No bundled libraries)
   * Remove obsolete copyright paragraphs from debian/copyright:
     - The corresponding files (Utilities/KWSys/hash_fun.hxx.in,
       Utilities/KWSys/hash_map.hxx.in, Utilities/KWSys/hash_set.hxx.in,
       Utilities/KWSys/hashtable.hxx.in) no longer exist in the latest
       upstream git version
   * debian/watch: Bump format version to 5.
   * debian/control: Remove redundant Rules-Requires-Root and Priority
     fields. Align Build-Depends and Depends.
   * debian/tests: Remove superficial tests directory.
   * debian/copyright: Add Upstream-Contact. Add missing copyright
     holders for IGSTK, VTK, and RegularExpression. Correct licenses
     for update-third-party.bash and ITKHeader.h to Apache-2.0.
   * debian/changelog: Remove trailing whitespace.
   * debian/fill.copyright.blanks.yml: Remove obsolete KWSys overrides
     as the corresponding files no longer exist.

QA information

Comments

  1. If you need to a sponsor, change the `Needs a sponsor` status from No to Yes.
    Seyed Mohamad Amin Modaresi at June 8, 2026, 4:40 p.m. 
  2. I changed the status
    何庆 Ching He at June 8, 2026, 4:53 p.m.

Upload #1

Information

Version: 1.1.0~git20250114.eb1e46d+ds-1
Uploaded: 2026-02-27 16:13
Source package: kwstyle_1.1.0~git20250114.eb1e46d+ds-1.dsc
Distribution: unstable
Section: devel
Priority: optional
Homepage: https://kitware.github.io/KWStyle/
Vcs-Browser: https://salsa.debian.org/heqing/kwstyle
Vcs-Git: https://salsa.debian.org/heqing/kwstyle.git
Closes bugs: #1117934

Changelog

 kwstyle (1.1.0~git20250114.eb1e46d+ds-1) unstable; urgency=medium
 .
   * Intent to Adopt (ITA) kwstyle package (Closes: #1117934)
   * New upstream version 1.1.0~git20250114.eb1e46d+ds:
     - Upstream has natively fixed FTBFS with CMake 4,
       remove the temporary NMU patch for #1113091
   * Update Maintainer to 何庆 Ching He <heqing@rool.me>
   * Update Standards-Version to 4.7.3 (routine-update)
   * Update Vcs-Git/Vcs-Browser to point to new Salsa repository
   * Add +ds suffix to repack upstream source:
     - Exclude bundled boost library in Utilities/boost and
       Utilities/updateBoost.sh, use system libboost-dev instead
     - Follow Debian Policy §4.13 (No bundled libraries)
   * Remove obsolete copyright paragraphs from debian/copyright:
     - The corresponding files (Utilities/KWSys/hash_fun.hxx.in,
       Utilities/KWSys/hash_map.hxx.in, Utilities/KWSys/hash_set.hxx.in,
       Utilities/KWSys/hashtable.hxx.in) no longer exist in the latest
       upstream git version

QA information

Comments

  1. Hello.

I'm not a DD but I wrote a review.

---
d/watch:

1- Update to version 5

For example:

https://salsa.debian.org/python-team/packages/pytesseract/-/blob/master/debian/watch?ref_type=heads

---
d/control:

1- Remove the Priority and Rules-Requires-Root tag.

2- Update Standards-Version to 4.7.4

3- Align B-D and Depends:

Build-Depends:
 debhelper-compat (= 13),
 cmake,
 libboost-dev

---
d/copyright:

1- Most of your work is for d/copyright.

Search for missing authors.

./Utilities/KWSys/RegularExpression.cxx: *      Copyright (c) 1986 by University of Toronto.


You can find them with (grep 'copyright' -ir .)
And decopy can give you a good information about missing authors. 

For example

2- It is better to put files that have the same license in one section.

Files: *
Copyright:
 Kitware, Inc.
 2020 Hans Johnson
 2015 Lucas Gandel
License: BSD-Kitware

3- Bad license for Utilities/update-third-party.bash & Web/headers/ITKHeader.h

$ lrc
en: Versions: licenserecon '17.0'  licensecheck '3.3.9-1'

Parsing Source Tree  ....
Reading d/copyright  ....
Running licensecheck ....

d/copyright      | licensecheck

BSL-1.0          | Apache-2.0        Utilities/update-third-party.bash
BSD-Kitware      | Apache-2.0        Web/headers/ITKHeader.h
---
    Needs work Seyed Mohamad Amin Modaresi at June 5, 2026, 7:58 a.m. 
  2. And please remove debian/tests . This test doesn't really do anything.


Some missing authors:

Web/headers/IGSTKSandbox/IGSTKHeader2.h:Copyright (c) 2000-2005 Atamai, Inc.

Web/headers/VTKHeader.h:  Copyright (c) Ken Martin, Will Schroeder, Bill Lorensen

./Web/headers/IGSTKSandbox/IGSTKHeader2.h:  Copyright (c) ISIS Georgetown University. All rights reserved.
./Web/headers/IGSTKSandbox/IGSTKHeader.h:  Copyright (c) ISIS Georgetown University. All rights reserved.
./Web/headers/IGSTKHeader.h:  Copyright (c) ISIS Georgetown University. All rights reserved.

Utilities/KWSys/RegularExpression.cxx: *      Copyright (c) 1986 by University of Toronto.
    Needs work Seyed Mohamad Amin Modaresi at June 5, 2026, 8:08 a.m. 
  3. Add Upstream Contact to d/copyright
    Needs work Seyed Mohamad Amin Modaresi at June 5, 2026, 8:11 a.m. 
  4. trailing-whitespace
 [debian/changelog:44]
    Needs work Seyed Mohamad Amin Modaresi at June 5, 2026, 8:34 a.m.