Hi,
Preamble...
Thank you for taking the time to prepare this package and your contribution to the Debian project.
The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Information only, as per historical package state
Running lintian...
N:
I: kgb: hardening-no-bindnow [usr/bin/kgb]
N:
N: This package provides an ELF binary that lacks the "bindnow" linker flag.
N:
N: This is needed (together with "relro") to make the "Global Offset Table"
N: (GOT) fully read-only. The bindnow feature trades startup time for
N: improved security. Please consider enabling this feature or consider
N: overriding the tag (possibly with a comment about why).
N:
N: If you use dpkg-buildflags, you may have to add hardening=+bindnow or
N: hardening=+all to DEB_BUILD_MAINT_OPTIONS.
N:
N: The relevant compiler flags are set in LDFLAGS.
N:
N: Please refer to https://wiki.debian.org/Hardening for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: binaries/hardening
N:
N:
I: kgb: hardening-no-fortify-functions [usr/bin/kgb]
N:
N: This package provides an ELF binary that lacks the use of fortified libc
N: functions. Either there are no potentially unfortified functions called by
N: any routines, all unfortified calls have already been fully validated at
N: compile-time, or the package was not built with the default Debian
N: compiler flags defined by dpkg-buildflags. If built using dpkg-buildflags
N: directly, be sure to import CPPFLAGS.
N:
N: NB: Due to false-positives, Lintian ignores some unprotected functions
N: (e.g. memcpy).
N:
N: Please refer to https://wiki.debian.org/Hardening and Bug#673112 for
N: details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: binaries/hardening
N:
N:
I: kgb source: no-dh-sequencer [debian/rules]
N:
N: This package does not use the dh sequencer in debian/rules.
N:
N: While maintainers may use a variety of build systems, this one is by far
N: the most popular.
N:
N: Maintainers are strongly encouraged to use the dh sequencer in new
N: packages and convert existing ones when appropriate.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/rules/dh-sequencer
N:
N:
I: kgb source: older-debian-watch-file-standard 3 [debian/watch]
N:
N: The version= line in the debian/watch file in this package declares an
N: older version. Please upgrade when you have a chance.
N:
N: Please refer to the uscan(1) manual page for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/watch/standard
N:
N:
I: kgb source: out-of-date-standards-version 3.9.8 (released 2016-04-06) (current is 4.7.0)
N:
N: The source package refers to a Standards-Version older than the one that
N: was current at the time the package was created (according to the
N: timestamp of the latest debian/changelog entry). Please consider updating
N: the package to current Policy and setting this control field
N: appropriately.
N:
N: If the package is already compliant with the current standards, you don't
N: have to re-upload the package just to adjust the Standards-Version control
N: field. However, please remember to update this field next time you upload
N: the package.
N:
N: See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
N: debian-policy package for a summary of changes in newer versions of
N: Policy.
N:
N: Please refer to
N: https://www.debian.org/doc/debian-policy/upgrading-checklist.html for
N: details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: fields/standards-version
N:
N:
I: kgb source: quilt-patch-missing-description [debian/patches/32bits.patch]
N:
N: quilt patch files should start with a description of patch. All lines
N: before the start of the patch itself are considered part of the
N: description. You can edit the description with quilt header -e when the
N: patch is at the top of the stack.
N:
N: As well as a description of the purpose and function of the patch, the
N: description should ideally contain author information, a URL for the bug
N: report (if any), Debian or upstream bugs fixed by it, upstream status, the
N: Debian version and date the patch was first included, and any other
N: information that would be useful if someone were investigating the patch
N: and underlying problem. Please consider using the DEP 3 format for this
N: information.
N:
N: Please refer to https://dep-team.pages.debian.net/deps/dep3/ for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/patches/quilt
N:
N:
I: kgb source: quilt-patch-missing-description [debian/patches/CVE-2015-1192.patch]
N:
I: kgb source: quilt-patch-missing-description [debian/patches/bad_strings.patch]
N:
I: kgb source: quilt-patch-missing-description [debian/patches/char2int.patch]
N:
I: kgb source: quilt-patch-missing-description [debian/patches/gcc-4.7.patch]
N:
I: kgb source: quilt-patch-missing-description [debian/patches/lfs.patch]
N:
I: kgb source: quilt-patch-missing-description [debian/patches/missing_cstring_include.patch]
N:
I: kgb source: quilt-patch-missing-description [debian/patches/signed2uint.patch]
N:
I: kgb source: quilt-patch-missing-description [debian/patches/usage_info.patch]
N:
P: kgb source: maintainer-manual-page [debian/additions/kgb.1]
N:
N: The maintainer keeps a manual page in ./debian. Please forward the manual
N: page upstream and ask them to include in their version control system, and
N: in their next release.
N:
N: If the manual page was already forwarded or rejected, or the upstream is
N: gone, please override the tag and annotate it with a suitable comment.
N:
N: Please refer to social contract item 2, Coordination with upstream
N: developers (Section 3.1.4) in the Debian Developer's Reference, and
N: Changes to the upstream sources (Section 4.3) in the Debian Policy Manual
N: for details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/manual-pages
N: Renamed from: maintainer-manpage
N:
N:
P: kgb source: no-dep5-copyright [debian/copyright]
N:
N: This package does not use a machine-readable debian/copyright file.
N:
N: This format makes it easier to review licenses and can be easily parsed by
N: Lintian.
N:
N: Please refer to
N: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ for
N: details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/copyright/dep5
N:
N:
P: kgb source: package-uses-old-debhelper-compat-version 10
N:
N: This package uses a debhelper compatibility level that is no longer
N: recommended. Please consider using the recommended level.
N:
N: For most packages, the best way to set the compatibility level is to
N: specify debhelper-compat (= X) as a Build-Depends in debian/control. You
N: can also use the debian/compat file or export DH_COMPAT in debian/rules.
N:
N: If no level is selected debhelper defaults to level 1, which is
N: deprecated.
N:
N: Please refer to the debhelper(7) manual page for details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debhelper
N:
N:
P: kgb source: silent-on-rules-requiring-root [debian/control]
N:
N: The field Rules-Requires-Root is missing from the file debian/control.
N:
N: Over time, Debian has successively narrowed the steps for which elevated
N: privileges are required. It speeds up the building of installation
N: packages in the archive. Eventually, Debian will switch the default
N: archive-wide behaviour to expedite the build process further.
N:
N: Please declare explicitly that the sources do not require root privileges.
N: You can use the setting Rules-Requires-Root: no in the source stanza of
N: debian/control, but please verify with diffoscope(1) that the installation
N: packages produced are in fact identical.
N:
N: Please refer to usr/share/doc/dpkg/spec/rootless-builds.txt, debian/rules
N: and Rules-Requires-Root (Section 4.9.2) in the Debian Policy Manual, and
N: Rules-Requires-Root (Section 5.6.31) in the Debian Policy Manual for
N: details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/control/field/rules-requires-root
N: Renamed from: rules-requires-root-missing
N:
N:
P: kgb source: trailing-whitespace [debian/control:18]
N:
N: This file contains lines with trailing whitespace characters.
N:
N: Whilst often harmless and unsightly, such extra whitespaces can also cause
N: tools to interpret the whitespace characters literally. The tool diff(1)
N: does not like them, either. They are best avoided.
N:
N: Some of these problems can be hard to track down.
N:
N: Whitespace at the end of lines may be removed with the following:
N:
N: $ sed -i -e 's@[[:space:]]*$@@g' debian/control debian/changelog
N:
N: If you use Emacs, you can also use "M-x wh-cl" (whitespace-cleanup).
N:
N: However, if you wish to only remove trailing spaces and leave trailing
N: tabs (eg. for Makefiles), you can use the following code snippet:
N:
N: $ sed -i -e 's@[ ]*$@@g' debian/rules
N:
N: To remove empty lines from the end of a file, you can use:
N:
N: $ sed -i -e :a -e '/^\n*$/{$d;N;};/\n$/ba' debian/rules
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/trailing-whitespace
N: Renamed from: file-contains-trailing-whitespace
N:
I: Lintian run was successful.
3. Licenses [4]: Not DEP-5, but we will not argue the state at this time
4. Watch file [uscan --force-download]: Good
5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
6. Reproducible builds [5]: Not performing at this time.
7. Install [No previous installs]: Good
8. Upgrade [Over previous installs if any]: Good
Summary...
Great work here. Looking at should an old package, I admire your efforts.
Have you had any contact with the maintainer?
I would suggest reading, if you not have already done so: https://www.debian.org/doc/manuals/developers-reference/pkgs.en.html#package-salvaging
Regards
Phil
[1] pbuilder:
* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
Ready
Phil Wyett at Dec. 8, 2024, 9:45 a.m.
