Details about package intel-vaapi-driver
Package uploads
Upload #1
Information
Changelog
intel-vaapi-driver (2.4.1+dfsg1-1.2) unstable; urgency=medium
.
* Non-maintainer upload.
* debian/patches/0005-Make-wl_drm-optional.patch (Closes: #1082533):
- wl_drm_interface from libEGL used to work
* Update debian/watch to fix watch error
* debian/control:
- Bump Standards-Version to 4.7.0
- deps: pkg-config to pkgconf
Comments
-
Don,
Preamble...
Thank you for taking the time to prepare this package and your contribution to the Debian project.
This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Information
Running lintian...
N:
I: intel-vaapi-driver source: anticipated-repack-count 2.4.1+dfsg1-1.2
N:
N: The version contains the string +dfsgN where N is a low number as in
N: +dfsg1.
N:
N: Normally it is not necessary to repackage an upstream source package more
N: than once. You can omit the repack count. In most cases +dfsg-1 is enough.
N:
N: If you really need to bump it, just go straight to +dfsg2-1.
N:
N: Please refer to
N: https://lists.debian.org/debian-devel/2021/10/msg00026.html for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: fields/version/repack/count
N:
N:
I: i965-va-driver: hardening-no-bindnow [usr/lib/x86_64-linux-gnu/dri/i965_drv_video.so]
N:
N: This package provides an ELF binary that lacks the "bindnow" linker flag.
N:
N: This is needed (together with "relro") to make the "Global Offset Table"
N: (GOT) fully read-only. The bindnow feature trades startup time for
N: improved security. Please consider enabling this feature or consider
N: overriding the tag (possibly with a comment about why).
N:
N: If you use dpkg-buildflags, you may have to add hardening=+bindnow or
N: hardening=+all to DEB_BUILD_MAINT_OPTIONS.
N:
N: The relevant compiler flags are set in LDFLAGS.
N:
N: Please refer to https://wiki.debian.org/Hardening for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: binaries/hardening
N:
N:
I: intel-vaapi-driver source: patch-not-forwarded-upstream [debian/patches/0001-Don-t-build-non-free-files.patch]
N:
N: According to the DEP-3 headers, this patch has not been forwarded
N: upstream.
N:
N: Please forward the patch and try to have it included in upstream's version
N: control system. If the patch is not suitable for that, please mention
N: not-needed in the Forwarded field of the patch header.
N:
N: Please refer to social contract item 2, Coordination with upstream
N: developers (Section 3.1.4) in the Debian Developer's Reference, Changes to
N: the upstream sources (Section 4.3) in the Debian Policy Manual, and
N: Bug#755153 for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/patches/dep3
N: Renamed from: send-patch
N:
N:
I: intel-vaapi-driver source: patch-not-forwarded-upstream [debian/patches/0002-Disable-post-processing-shaders.patch]
N:
I: intel-vaapi-driver source: patch-not-forwarded-upstream [debian/patches/0003-Disable-decoding.patch]
N:
I: intel-vaapi-driver source: upstream-metadata-missing-repository [debian/upstream/metadata]
N:
N: The DEP 12 metadata file does not specify the location of upstream's
N: version control repository (ie. the Repository and Repository-Browse
N: fields are missing).
N:
N: The upstream metadata can be found in the source package in the file
N: debian/upstream/metadata.
N:
N: Please refer to https://dep-team.pages.debian.net/deps/dep12/ for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/upstream/metadata
N:
I: Lintian run was successful.
3. Licenses [4]: None blocking, but looks like a review is in order.
4. Watch file [uscan --force-download]: Good
5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Good
8. Upgrade [Over previous installs if any]: Good
Summary...
Some lintian issues to look at.
'd/copyright' needs review at a later date.
Looking good.
Please try the below on your packages...
[1] pbuilder:
* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian --display-info --verbose --fail-on error --info --pedantic --show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
Note: Please report false positives as bug reports against 'licenserecon'.
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
Regards
Phil
Needs work
Phil Wyett at Jan. 4, 2025, 4:47 p.m.
-
An NMU can be in order, but do you have contact with the maintainers of the package to assist a smooth update?
Phil Wyett at Jan. 4, 2025, 4:49 p.m.
