Details about package intel-ipsec-mb
| Name: |
intel-ipsec-mb
(PTS)
|
| Uploader: |
ColinKing
<colin.i.king@gmail.com>
(Debian QA page)
|
| Description: |
libipsec-mb2 - Intel(R) Multi-Buffer Crypto for IPSec library
libipsec-mb-dev - Development files for Intel(R) Multi-Buffer Crypto for IPSec library |
Package uploads
Upload #1
Information
Changelog
intel-ipsec-mb (2.0-1) unstable; urgency=medium
.
* Sync to latest 2.0 release
Comments
-
Colin,
Preamble...
Thank you for taking the time to prepare this package and your contribution to the Debian project.
The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Issue
Running lintian...
N:
W: intel-ipsec-mb source: newer-standards-version 4.7.2 (current is 4.7.0)
N:
N: The source package refers to a Standards-Version which is newer than the
N: highest one Lintian is programmed to check.
N:
N: If the source package is correct, please upgrade Lintian to the newest
N: version.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: fields/standards-version
N:
N:
W: libipsec-mb-dev: privacy-breach-generic [<img src="https://api.securityscorecards.dev/projects/github.com/intel/intel-ipsec-mb/badge" alt="openssf scorecard" class="inline"/>] (https://api.securityscorecards.dev/projects/github.com/intel/intel-ipsec-mb/badge) [usr/share/doc/libipsec-mb/index.html]
N:
N: This package creates a potential privacy breach by fetching data from an
N: external website at runtime. Please remove these scripts or external HTML
N: resources.
N:
N: Please replace any scripts, images, or other remote resources with
N: non-remote resources. It is preferable to replace them with text and links
N: but local copies of the remote resources are also acceptable as long as
N: they don't also make calls to remote services. Please ensure that the
N: remote resources are suitable for Debian main before making local copies
N: of them.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: files/privacy-breach
N:
N:
W: libipsec-mb-dev: privacy-breach-generic [<img src="https://github.com/intel/intel-ipsec-mb/actions/workflows/freebsd.yml/badge.svg" alt="freebsd" style="pointer-events: none;" class="inline"/>] (https://github.com/intel/intel-ipsec-mb/actions/workflows/freebsd.yml/badge.svg) [usr/share/doc/libipsec-mb/index.html]
N:
W: libipsec-mb-dev: privacy-breach-generic [<img src="https://github.com/intel/intel-ipsec-mb/actions/workflows/linux.yml/badge.svg" alt="linux" style="pointer-events: none;" class="inline"/>] (https://github.com/intel/intel-ipsec-mb/actions/workflows/linux.yml/badge.svg) [usr/share/doc/libipsec-mb/index.html]
N:
W: libipsec-mb-dev: privacy-breach-generic [<img src="https://github.com/intel/intel-ipsec-mb/actions/workflows/windows.yml/badge.svg" alt="windows" style="pointer-events: none;" class="inline"/>] (https://github.com/intel/intel-ipsec-mb/actions/workflows/windows.yml/badge.svg) [usr/share/doc/libipsec-mb/index.html]
N:
W: libipsec-mb-dev: privacy-breach-generic [<img src="https://scan.coverity.com/projects/16449/badge.svg" alt="coverity status" style="pointer-events: none;" class="inline"/>] (https://scan.coverity.com/projects/16449/badge.svg) [usr/share/doc/libipsec-mb/index.html]
N:
I: libipsec-mb2: extra-license-file [usr/share/doc/libipsec-mb2/LICENSE]
N:
N: All license information should be collected in the debian/copyright file.
N: This usually makes it unnecessary for the package to install this
N: information in other places as well.
N:
N: Please refer to Copyright information (Section 12.5) in the Debian Policy
N: Manual for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: files/licenses
N:
N:
I: libipsec-mb2-dbgsym: file-references-package-build-path [usr/lib/debug/.build-id/07/db3bff3dc2808837ed254fbfe8846a808d004f.debug]
N:
N: The listed file or maintainer script appears to reference the build path
N: used to build the package as specified in the Build-Path field of the
N: .buildinfo file.
N:
N: This is likely to cause the package to be unreproducible, but it may also
N: indicate that the package will not work correctly outside of the
N: maintainer's own system.
N:
N: Please note that this tag will not appear unless the .buildinfo file
N: contains a Build-Path field. That field is optional. You may have to set
N: DEB_BUILD_OPTIONS=buildinfo=+path or use
N: --buildinfo-option=--always-include-path with dpkg-buildpackage when
N: building.
N:
N: Please refer to https://reproducible-builds.org/,
N: https://wiki.debian.org/ReproducibleBuilds/BuildinfoFiles, and the
N: dpkg-genbuildinfo(1) manual page for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: files/contents
N:
N:
I: libipsec-mb-dev: possible-documentation-but-no-doc-base-registration
N:
N: The package ships a .html or .pdf file under /usr/share/doc/. Those files
N: are usually documentation, but no files are registered in doc-base.
N:
N: Files in folders named examples are exempt from this tag.
N:
N: Please refer to Registering Documents using doc-base (Section 9.10) in the
N: Debian Policy Manual for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: menus
N:
N:
P: intel-ipsec-mb source: co-maintained-package-with-no-vcs-fields
N:
N: Based on the content of the maintainer and uploader fields this package is
N: co-maintained but there are no Vcs-* fields.
N:
N: It is recommended that shared maintenance of packages are co-ordinated via
N: a revision control system.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: fields/vcs
N: Renamed from: co-maintained-package-with-no-vcs-headers
N:
N:
P: intel-ipsec-mb source: package-does-not-install-examples [examples/]
N:
N: The original source tarball contains the specified examples directory.
N: However, no examples are installed in any binary packages.
N:
N: Please use dh_installexamples to install these to the most relevant
N: package, for example by adding the directory name followed by a wildcard
N: to a debian/pkgname.examples file.
N:
N: Lintian looks for any directory called examples under /usr/share/doc in
N: all binary packages.
N:
N: Please refer to the dh_installexamples(1) manual page for details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: examples
N:
N: Screen: examples/in-tests
N: Advocates: "Scott Kitterman" <debian@kitterman.com>
N: Reason:
N: Some sources like python-tomlkit trigger this tag for tests because of files
N: in ./tests/examples/. They are not examples for tomlkit, however. They are
N: examples of TOML files used in the tests.
N:
N: Overall, the check is probably better off not looking in test
N: directories.
N:
N: Read more in Bug#1005184.
N:
I: Lintian run was successful.
3. Licenses [4]: Issue, possible false positives
philwyett@ks-tarkin:~/Development/builder/debian/intel-ipsec-mb-2.0$ lrc
en: Versions: recon 3.0 check 3.3.9-1
Parsing Source Tree ....
Reading d/copyright ....
Running licensecheck ....
d/copyright | licensecheck
BSD-3-clause | Expat docs/dynsections.js
BSD-3-clause | Expat docs/jquery.js
BSD-3-clause | Expat docs/navtreedata.js
BSD-3-clause | Expat docs/navtree.js
BSD-3-clause | Expat docs/resize.js
BSD-3-clause | Expat docs/search/search.js
4. Watch file [uscan --force-download]: Good
5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Good
8. Upgrade [Over previous installs if any]: Good
Summary...
I believe intel-ipsec-mb is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the raised issues.
Regards
Phil
[1] pbuilder:
* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
Needs work
Phil Wyett at Nov. 7, 2024, 5:13 p.m.
