Sign me up Login

Details about package getdns

Name: getdns (PTS)
Uploader: Andrew Bower <andrew@bower.uk> (Debian QA page)
Description: libgetdns-dev - modern asynchronous DNS API (development)
libgetdns10t64 - modern asynchronous DNS API (shared library)
getdns-utils - modern asynchronous DNS API (utils)
stubby - modern asynchronous DNS API (stub resolver)

Package uploads

Upload #1

Information

Version: 1.6.0-3.2
Uploaded: 2025-02-03 07:56
Source package: getdns_1.6.0-3.2.dsc
Distribution: unstable
Section: libs
Priority: optional
Homepage: https://getdnsapi.net/
Vcs-Git: https://salsa.debian.org/dns-team/getdns.git
Vcs-Browser: https://salsa.debian.org/dns-team/getdns
Closes bugs: #1074989

Changelog

 getdns (1.6.0-3.2) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   [ Debian Janitor ]
   * Remove constraints unnecessary since buster (oldstable):
     + stubby: Drop versioned constraint on getdns-utils in Replaces.
     + stubby: Drop versioned constraint on getdns-utils in Breaks.
   * debian/copyright: use spaces rather than tabs to start continuation lines.
   * Bump debhelper from old 11 to 13.
     + debian/rules: Drop --fail-missing argument to dh_missing, which is now the
       default.
   * Set debhelper-compat version in Build-Depends.
   * Update standards version to 4.6.2, no changes needed.
 .
   [ Andrew Bower ]
   * Patch tests to fix FTBFS with gcc-14. (Closes: #1074989)

QA information

Comments

  1. If anyone chooses to upload this, please also fast-forward merge the packaging repo to:

https://salsa.debian.org/abower/getdns/-/commit/06b1b349e16a7e6549c440ead29defdc10dd217d

The repo does not include the -3.1 NMU from a year ago - my commit above incorporates this.
    Andrew Bower at Feb. 3, 2025, 8:17 a.m. 
  2. Andrew,

Preamble...

Thank you for taking the time to prepare this package and your contribution to the Debian project.

This review is offered to help package contributors to Debian mentors improve their packages (where needed) prior to possible sponsorship into Debian by a Debian Developer.


Review...

1. Build:

  * pbuilder [1]: Good
 
  * sbuild [2]: Good


2. Lintian [3]: Information only

Running lintian...
N:
W: getdns-utils: no-manual-page [usr/bin/getdns_query]
N: 
N:   Each binary in /usr/bin, /usr/sbin, /bin, /sbin or /usr/games should have
N:   a manual page
N:   
N:   Note that though the man program has the capability to check for several
N:   program names in the NAMES section, each of these programs should have its
N:   own manual page (a symbolic link to the appropriate manual page is
N:   sufficient) because other manual page viewers such as xman or tkman don't
N:   support this.
N:   
N:   If the name of the manual page differs from the binary by case, man may be
N:   able to find it anyway; however, it is still best practice to match the
N:   exact capitalization of the executable in the manual page.
N:   
N:   If the manual pages are provided by another package on which this package
N:   depends, Lintian may not be able to determine that manual pages are
N:   available. In this case, after confirming that all binaries do have manual
N:   pages after this package and its dependencies are installed, please add a
N:   Lintian override.
N: 
N:   Please refer to Manual pages (Section 12.1) in the Debian Policy Manual
N:   for details.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: documentation/manual
N:   Renamed from: binary-without-manpage
N: 
N:
W: getdns-utils: no-manual-page [usr/bin/getdns_server_mon]
N:
W: getdns source: orig-tarball-missing-upstream-signature getdns_1.6.0.orig.tar.gz
N: 
N:   The packaging includes an upstream signing key but the corresponding .asc
N:   signature for one or more source tarballs are not included in your
N:   .changes file.
N:   
N:   Please ensure a <package>_<version>.orig.tar.<ext>.asc file exists in the
N:   same directory as your <package>_<version>.orig.tar.<ext> tarball prior to
N:   dpkg-source --build being called.
N:   
N:   If you are repackaging your source tarballs for Debian Free Software
N:   Guidelines compliance reasons, ensure that your package version includes
N:   dfsg or similar.
N:   
N:   Sometimes, an upstream signature must be added for an orig.tar.gz that is
N:   already present in the archive. Please include the upstream sources again
N:   with dpkg-genchanges -sa while the signature is also present. Your upload
N:   will be accepted as long as the new orig.tar.gz file is identical to the
N:   old one.
N: 
N:   Please refer to Bug#954743 and Bug#872864 for details.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: upstream-signature
N: 
N:
I: getdns source: out-of-date-standards-version 4.6.2 (released 2022-12-17) (current is 4.7.0)
N: 
N:   The source package refers to a Standards-Version older than the one that
N:   was current at the time the package was created (according to the
N:   timestamp of the latest debian/changelog entry). Please consider updating
N:   the package to current Policy and setting this control field
N:   appropriately.
N:   
N:   If the package is already compliant with the current standards, you don't
N:   have to re-upload the package just to adjust the Standards-Version control
N:   field. However, please remember to update this field next time you upload
N:   the package.
N:   
N:   See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
N:   debian-policy package for a summary of changes in newer versions of
N:   Policy.
N: 
N:   Please refer to
N:   https://www.debian.org/doc/debian-policy/upgrading-checklist.html for
N:   details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: fields/standards-version
N: 
N:
I: getdns source: patch-not-forwarded-upstream [debian/patches/0001-avoid-phoning-home-to-creativecommons.org-when-readi.patch]
N: 
N:   According to the DEP-3 headers, this patch has not been forwarded
N:   upstream.
N:   
N:   Please forward the patch and try to have it included in upstream's version
N:   control system. If the patch is not suitable for that, please mention
N:   not-needed in the Forwarded field of the patch header.
N: 
N:   Please refer to social contract item 2, Coordination with upstream
N:   developers (Section 3.1.4) in the Debian Developer's Reference, Changes to
N:   the upstream sources (Section 4.3) in the Debian Policy Manual, and
N:   Bug#755153 for details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: debian/patches/dep3
N:   Renamed from: send-patch
N: 
N:
I: getdns source: patch-not-forwarded-upstream [debian/patches/0002-fix-typo.patch]
N:
I: getdns source: patch-not-forwarded-upstream [debian/patches/0004-Fix-stubby.yml-install-path-for-debian.patch]
N:
I: libgetdns10t64: symbols-file-missing-build-depends-package-field libgetdns_ex_ev.so.10 [symbols]
N: 
N:   The symbols file for this package does not contain a Build-Depends-Package
N:   meta-information field.
N:   
N:   This field specifies the name of the -dev package associated to the
N:   library and is used by dpkg-shlibdeps(1) to make sure that the dependency
N:   generated is at least as strict as the corresponding build dependency.
N:   
N:   This is useful as allows packages to not hardcode this information
N:   multiple times.
N:   
N:   Note that the format of deb-symbols(5) files requires that the *
N:   Build-Depends-Package: line should start in column one of the file and not
N:   be indented to align with the symbols themselves. Please do not use the
N:   placeholder #PACKAGE#. The development package for your shared library
N:   must be stated explicitly.
N: 
N:   Please refer to The symbols File Format (Section 8.6.3.2) in the Debian
N:   Policy Manual, the deb-symbols(5) manual page, the dpkg-shlibdeps(1)
N:   manual page,
N:   https://www.debian.org/doc/manuals/maint-guide/advanced.en.html#librarysymbols,
N:   and Bug#944047 for details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: debian/shlibs
N: 
N:
I: libgetdns10t64: symbols-file-missing-build-depends-package-field libgetdns_ex_event.so.10 [symbols]
N:
I: libgetdns10t64: symbols-file-missing-build-depends-package-field libgetdns_ex_uv.so.10 [symbols]
N:
I: libgetdns10t64: unused-override package-name-doesnt-match-sonames libgetdns10 [usr/share/lintian/overrides/libgetdns10t64:1]
N: 
N:   Your package specifies the named override but there were no tags that
N:   could have been silenced by it.
N:   
N:   Maybe you fixed an underlying condition but forgot to remove the override.
N:   It is also possible that the Lintian maintainers fixed a false positive.
N:   
N:   If the override is now unused, please remove it.
N:   
N:   This tag is similar to mismatched-override except there a tag could have
N:   been silenced if the context had matched.
N:   
N:   Sometimes, overrides end up not being used because a tag appears only on
N:   some architectures. In that case, overrides can be equipped with an
N:   architecture qualifier.
N: 
N:   Please refer to Architecture specific overrides (Section 2.4.3) in the
N:   Lintian User's Manual for details.
N: 
N:   Visibility: info
N:   Show-Always: yes
N:   Check: lintian
N: 
N:
P: getdns source: debian-control-has-unusual-field-spacing Breaks [debian/control:55]
N: 
N:   A field in the debian/control file has an unusual amount of whitespace
N:   after the colon.
N:   
N:   The syntax for Deb822 files permits any kind of space, but according to
N:   Policy there is a convention to use a single space after the colon.
N: 
N:   Please refer to Syntax of control files (Section 5.1) in the Debian Policy
N:   Manual for details.
N: 
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: debian/control/field/spacing
N: 
N:
P: getdns source: debian-control-has-unusual-field-spacing Replaces [debian/control:57]
N:
P: getdns source: trailing-whitespace [debian/control:55]
N: 
N:   This file contains lines with trailing whitespace characters.
N:   
N:   Whilst often harmless and unsightly, such extra whitespaces can also cause
N:   tools to interpret the whitespace characters literally. The tool diff(1)
N:   does not like them, either. They are best avoided.
N:   
N:   Some of these problems can be hard to track down.
N:   
N:   Whitespace at the end of lines may be removed with the following:
N:   
N:    $ sed -i -e 's@[[:space:]]*$@@g' debian/control debian/changelog
N:   
N:   If you use Emacs, you can also use "M-x wh-cl" (whitespace-cleanup).
N:   
N:   However, if you wish to only remove trailing spaces and leave trailing
N:   tabs (eg. for Makefiles), you can use the following code snippet:
N:   
N:    $ sed -i -e 's@[ ]*$@@g' debian/rules
N:   
N:   To remove empty lines from the end of a file, you can use:
N:   
N:    $ sed -i -e :a -e '/^\n*$/{$d;N;};/\n$/ba' debian/rules
N: 
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: debian/trailing-whitespace
N:   Renamed from: file-contains-trailing-whitespace
N: 
N:
P: getdns source: trailing-whitespace [debian/control:57]

E: Lintian run failed (runtime error


3. Licenses [4]: Information only

philwyett@ks-tarkin:~/Development/builder/debian/getdns-1.6.0$ lrc
en: Versions: recon '3.4'  check '3.3.9-1'

Parsing Source Tree  ....
Reading d/copyright  ....
Running licensecheck ....

d/copyright      | licensecheck

BSD-3-clause     | BSD-4-Clause-UC   stubby/src/compat/getopt.c


4. Watch file [uscan --force-download]: Good


5. Build Twice (build source after successful build) [1]: Good


6. Reproducible builds [5]: Good

Note: Test does not block sponsorship and is for information only at this time.


7. Tail of the ratt (architecture dependant packages only) [6]: Good

Note: Test does not block sponsorship and is for information only at this time.


8. Install [No previous installs]: Good


9. Upgrade [Over previous installs if any]: Good


Additional...

A. Note many of test fails.

B. Would not be against a neew upstream release NMU.


Summary...

I believe 'getdns' is ready for review/possible sponsorship.

If you do not have upload rights or a regular sponsor. You can follow the RFS process linked to below.

https://mentors.debian.net/sponsors/rfs-howto/


Please try the below on your packages...

[1] pbuilder:

  * Command for 1.: sudo pbuilder build <PACKAGE>.dsc
  * Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks


[2] sbuild:

  * Command: sbuild -d unstable <PACKAGE>.dsc
  * Document: https://wiki.debian.org/sbuild


[3] lintian:

  * Command: lintian --display-info --verbose --fail-on error --info --pedantic --show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian


[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

  Note: Please report false positives as bug reports against 'licenserecon'.


[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method


[6] ratt

  * Command: ratt --dist=<YOUR_DISTRIBUTION> <PACKAGE>_<VERSION>-<DEBIAN_REVISION>_<ARCHITECTURE>.changes
  * Document: https://manpages.debian.org/unstable/ratt/ratt.1.en.html


Regards

Phil
    Ready Phil Wyett at Feb. 3, 2025, 1:05 p.m.