Details about package galvani
Package uploads
Upload #2
Information
Changelog
galvani (0.38-1) unstable; urgency=medium
.
* New upstream version
Comments
-
Burkard,
Preamble...
Thank you for taking the time to prepare this package and your contribution to the Debian project.
The review below is for assistance. This review is offered to help package submitters to Debian mentors in order to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]:
2. Lintian [3]: Issue
W: galvani source: superfluous-file-pattern src/Makefile.in [debian/copyright:21]
N:
N: The wildcard that was specified matches no file in the source tree. This
N: either indicates that you should fix the wildcard so that it matches the
N: intended file or that you can remove the wildcard. Notice that in contrast
N: to shell globs, the "*" (star or asterisk) matches slashes and leading
N: dots.
N:
N: Please refer to
N: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ for
N: details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: debian/copyright/dep5
3. Licenses [4]: Issue
philwyett@ks-tarkin:~/Development/builder/debian/galvani-0.38$ lrc
en: Versions: recon 2.2 check 3.3.9-1
Parsing Source Tree ....
Reading d/copyright ....
** Superfluous file pattern src/Makefile.in
Missing Files: Paragraph for debian/
Running licensecheck ....
No differences found
4. Watch file [uscan --force-download]:
5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Issue
dpkg-source --before-build .
debian/rules clean
dh clean --with autoreconf
dh_auto_clean
make -j12 distclean
make[1]: Entering directory '/build/galvani-0.38'
Making distclean in src
make[2]: Entering directory '/build/galvani-0.38/src'
rm -rf .libs _libs
rm -f *.o
rm -f galvani
rm -f *.lo
rm -f *.tab.c
test -z "" || rm -f
rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
test . = "." || test -z "" || rm -f
rm -f ./.deps/data_rw.Po
rm -f ./.deps/eval.Po
rm -f ./.deps/main.Po
rm -f ./.deps/mess.Po
rm -f ./.deps/options.Po
rm -f ./.deps/print.Po
rm -f Makefile
make[2]: Leaving directory '/build/galvani-0.38/src'
Making distclean in po
make[2]: Entering directory '/build/galvani-0.38/po'
rm -f *.insert-header
rm -f remove-potcdate.sed
rm -f ./stamp-poT
rm -f core core.* galvani.po galvani.1po galvani.2po *.new.po
rm -fr *.o
rm -f Makefile Makefile.in POTFILES
make[2]: Leaving directory '/build/galvani-0.38/po'
make[2]: Entering directory '/build/galvani-0.38'
rm -rf .libs _libs
rm -f *.lo
test -z "" || rm -f
rm -f config.h stamp-h1
rm -f libtool config.lt
rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
test . = "." || test -z "" || rm -f
test -z "intltool-extract intltool-merge intltool-update po/.intltool-merge-cache" || rm -f intltool-extract intltool-merge intltool-update po/.intltool-merge-cache
rm -f cscope.out cscope.in.out cscope.po.out cscope.files
make[2]: Leaving directory '/build/galvani-0.38'
rm -f config.status config.cache config.log configure.lineno config.status.lineno
rm -f Makefile
make[1]: Leaving directory '/build/galvani-0.38'
dh_autoreconf_clean
rm -f -- ./ltmain.sh ./m4/progtest.m4 ./m4/pkg.m4 ./m4/ltoptions.m4 ./m4/po.m4 ./m4/ltversion.m4 ./m4/lt\~obsolete.m4 ./m4/lib-prefix.m4 ./m4/lib-ld.m4 ./m4/iconv.m4 ./m4/libtool.m4 ./m4/ltsugar.m4 ./m4/intlmacosx.m4 ./m4/gettext.m4 ./m4/lib-link.m4 ./m4/nls.m4 ./m4/host-cpu-c-abi.m4 ./config.rpath ./src/Makefile.in ./Makefile.in ./INSTALL ./depcomp ./ABOUT-NLS ./compile ./missing ./COPYING ./config.h.in ./install-sh ./aclocal.m4 ./po/en\@boldquot.header ./po/Makefile.in.in ./po/quot.sed ./po/boldquot.sed ./po/remove-potcdate.sin ./po/insert-header.sin ./po/Makevars.template ./po/Rules-quot ./po/en\@quot.header ./autom4te.cache/output.2 ./autom4te.cache/traces.2 ./autom4te.cache/traces.0 ./autom4te.cache/output.0 ./autom4te.cache/output.3 ./autom4te.cache/requests ./autom4te.cache/traces.1 ./autom4te.cache/output.1 ./autom4te.cache/traces.3 ./config.sub ./config.guess ./configure\~ ./configure
rm -f debian/autoreconf.before debian/autoreconf.after
dh_clean
rm -f debian/debhelper-build-stamp
rm -rf debian/.debhelper/
rm -f -- debian/galvani.substvars ./po/stamp-po debian/files
rm -fr -- debian/galvani/ debian/tmp/
find . \( \( \
\( -path .\*/.git -o -path .\*/.svn -o -path .\*/.bzr -o -path .\*/.hg -o -path .\*/CVS -o -path .\*/.pc -o -path .\*/_darcs \) -prune -o -type f -a \
\( -name '#*#' -o -name '.*~' -o -name '*~' -o -name DEADJOE \
-o -name '*.orig' -o -name '*.rej' -o -name '*.bak' \
-o -name '.*.orig' -o -name .*.rej -o -name '.SUMS' \
-o -name TAGS -o \( -path '*/.deps/*' -a -name '*.P' \) \
\) -exec rm -f {} + \) -o \
\( -type d -a \( -name autom4te.cache -o -name __pycache__ \) -prune -exec rm -rf {} + \) \)
dpkg-source -b .
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: warning: upstream signing key but no upstream tarball signature
dpkg-source: info: building galvani using existing ./galvani_0.38.orig.tar.xz
dpkg-source: warning: ignoring deletion of file configure, use --include-removal to override
dpkg-source: warning: ignoring deletion of file po/POTFILES, use --include-removal to override
dpkg-source: error: cannot represent change to po/de.gmo: binary file contents changed
dpkg-source: error: add po/de.gmo in debian/source/include-binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: unrepresentable changes to source
dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 1
I: copying local configuration
E: Failed autobuilding of package
I: unmounting dev/ptmx filesystem
I: unmounting dev/pts filesystem
I: unmounting dev/shm filesystem
I: unmounting proc filesystem
I: unmounting sys filesystem
I: cleaning the build env
I: removing directory /var/cache/pbuilder/build/36017 and its subdirectories
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Good
8. Upgrade [Over previous installs if any]: Good
Summary...
I believe galvani is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the raised issues.
Regards
Phil
[1] pbuilder:
* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
Needs work
Phil Wyett at Nov. 4, 2024, 6:22 a.m.
Upload #1
Information
Changelog
galvani (0.37-1) unstable; urgency=medium
.
* New upstream version
Comments
-
Burkard,
Preamble...
Thank you for taking the time to prepare this package and your contribution to the Debian project.
The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Issue
Running lintian...
N:
W: galvani: appstream-metadata-validation-failed Problems reported by "appstreamcli validate-tree".
N:
N: The specified AppStream metadata file fail to validate using 'appstreamcli
N: validate-tree --no-net path-to-package-root'.
N:
N: Please refer to https://wiki.debian.org/AppStream/Guidelines for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: appstream-metadata
N:
N:
I: galvani: hardening-no-fortify-functions [usr/bin/galvani]
N:
N: This package provides an ELF binary that lacks the use of fortified libc
N: functions. Either there are no potentially unfortified functions called by
N: any routines, all unfortified calls have already been fully validated at
N: compile-time, or the package was not built with the default Debian
N: compiler flags defined by dpkg-buildflags. If built using dpkg-buildflags
N: directly, be sure to import CPPFLAGS.
N:
N: NB: Due to false-positives, Lintian ignores some unprotected functions
N: (e.g. memcpy).
N:
N: Please refer to https://wiki.debian.org/Hardening and Bug#673112 for
N: details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: binaries/hardening
N:
N:
I: galvani source: out-of-date-standards-version 4.6.2 (released 2022-12-17) (current is 4.7.0)
N:
N: The source package refers to a Standards-Version older than the one that
N: was current at the time the package was created (according to the
N: timestamp of the latest debian/changelog entry). Please consider updating
N: the package to current Policy and setting this control field
N: appropriately.
N:
N: If the package is already compliant with the current standards, you don't
N: have to re-upload the package just to adjust the Standards-Version control
N: field. However, please remember to update this field next time you upload
N: the package.
N:
N: See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
N: debian-policy package for a summary of changes in newer versions of
N: Policy.
N:
N: Please refer to
N: https://www.debian.org/doc/debian-policy/upgrading-checklist.html for
N: details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: fields/standards-version
N:
N:
I: galvani source: upstream-metadata-missing-bug-tracking [debian/upstream/metadata]
N:
N: The DEP 12 metadata file does not specify any upstream bug tracking
N: information (ie. the Bug-Database or Bug-Submit fields are missing).
N:
N: The upstream metadata can be found in the source package in the file
N: debian/upstream/metadata.
N:
N: Please refer to https://dep-team.pages.debian.net/deps/dep12/ for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/upstream/metadata
N:
I: Lintian run was successful.
3. Licenses [4]: Issue
philwyett@ks-tarkin:~/Development/builder/debian/mentoring/galvani-0.37$ lrc
en: Versions: recon 2.0 check 3.3.9-1
Parsing Source Tree ....
Reading d/copyright ....
Missing Files: Paragraph for debian/
Running licensecheck ....
d/copyright | licensecheck
GPL-2+ | FSFULLR config.rpath
GPL-2+ | FSFAP po/remove-potcdate.sin
4. Watch file [uscan --force-download]: Good
5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Good
8. Upgrade [Over previous installs if any]: Good
Summary...
I believe galvani is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the raised issues.
Regards
Phil
[1] pbuilder:
* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
Needs work
Phil Wyett at Oct. 8, 2024, 1:14 p.m.