Sign me up Login

Details about package fennel-ls

Name: fennel-ls
Uploader: Phil Hagelberg <phil@hagelb.org> (Debian QA page)
Description: fennel-ls - Intelligent editing features for fennel files.

Package uploads

Upload #3

Information

Version: 0.2.1-1
Uploaded: 2025-07-06 18:12
Source package: fennel-ls_0.2.1-1.dsc
Distribution: unstable
Section: devel
Priority: optional
Homepage: https://git.sr.ht/~xerool/fennel-ls
Vcs-Browser: https://git.sr.ht/~technomancy/fennel-ls
Vcs-Git: https://git.sr.ht/~technomancy/fennel-ls
Closes bugs: #1108755

Changelog

 fennel-ls (0.2.1-1) unstable; urgency=medium
 .
   * Initial release. (Closes: #1108755)

QA information

Comments

  1. Phil,

Review of upload: 2025-07-06 18:12

For information about the tests run, see:

https://wiki.debian.org/PhilWyett/DebianMentoring

Note: If test line removed, it indicates a test pass.

Test 4 (sbuild): Information only

Lintian:

E: fennel-ls source: debian-watch-file-pubkey-file-is-missing [debian/watch]
N: 
N:   This watch file verifies a cryptographic signature but the upstream public
N:   key is missing.
N:   
N:   Please add upstream public keys in either debian/upstream/signing-key.asc
N:   or debian/upstream/signing-key.pgp.
N: 
N:   Please refer to the uscan(1) manual page for details.
N: 
N:   Visibility: error
N:   Show-Always: no
N:   Check: debian/watch
N: 
N:
W: fennel-ls: groff-message an.tmac:<standard input>:255: warning: tbl preprocessor failed, or it or soelim was not run; table(s) likely not rendered (TE macro called with TW register undefined) [usr/share/man/man1/fennel-ls.1.gz:1]
N: 
N:   A manual page provoked warnings or errors from the man program. Here are
N:   some common ones:
N:   
N:   "cannot adjust" or "can't break" are issues with paragraph filling. They
N:   are usually related to long lines. Justifying text on the left hand side
N:   can help with adjustments. Hyphenation can help with breaks.
N:   
N:   For more information, please see "Manipulating Filling and Adjusting" and
N:   "Manipulating Hyphenation" in the Groff manual (see info groff).
N:   
N:   "can't find numbered character" usually means that the input was in a
N:   national legacy encoding. The warning means that some characters were
N:   dropped. Please use escapes such as \[:a] as described on the groff_char
N:   manual page.
N:   
N:   Other common warnings are formatting typos. String arguments to .IP
N:   require quotes. Usually, some text is lost or mangled. See the groff_man
N:   (or groff_mdoc if using mdoc) manual page for details on macros.
N:   
N:   The check for manual pages uses the --warnings option to man to catch
N:   common problems, like a . or a ' at the beginning of a line as literal
N:   text. They are interpreted as Groff commands. Just reformat the paragraph
N:   so the characters are not at the beginning of a line. You can also add a
N:   zero-width space (\&) in front of them.
N:   
N:   Aside from overrides, warnings can be disabled with the .warn directive.
N:   Please see "Debugging" in the Groff manual.
N:   
N:   You can see the warnings yourself by running the command used by Lintian:
N:   
N:       LC_ALL=C.UTF-8 MANROFFSEQ='' MANWIDTH=80 \
N:           man --warnings -E UTF-8 -l -Tutf8 -Z <file> >/dev/null
N: 
N:   Please refer to the groff_man(7) manual page and the groff_mdoc(7) manual
N:   page for details.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: documentation/manual
N:   Renamed from: manpage-has-errors-from-man
N: 
N:
W: fennel-ls: virtual-package-depends-without-real-package-depends Depends: lua
N: 
N:   The package declares a depends on a virtual package without listing a real
N:   package as an alternative first.
N:   
N:   If this package could ever be a build dependency, it should list a real
N:   package as the first alternative to any virtual package in its Depends.
N:   Otherwise, the build daemons will not be able to provide a consistent
N:   build environment.
N:   
N:   If it will never be a build dependency, this isn't necessary, but you may
N:   want to consider doing so anyway if there is a real package providing that
N:   virtual package that most users will want to use.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: fields/package-relations
N: 
N:
I: fennel-ls: synopsis-is-a-sentence "Intelligent editing features for fennel files."
N: 
N:   The package synopsis (also known as the "short" description, ie. the first
N:   line in the package's "Description:" field) either ends with a full stop
N:   "." character or starts another sentence.
N:   
N:   This is not necessary as the synopsis does not need to be a full sentence.
N:   It is recommended that a single descriptive phrase is used instead.
N:   
N:   Note also that the synopsis is not part of the rest of the "long"
N:   Description: field.
N: 
N:   Please refer to The package synopsis, or short description (Section 6.2.2)
N:   in the Debian Developer's Reference for details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: fields/description
N:   Renamed from: description-synopsis-might-not-be-phrased-properly

Test 7 (licenserecon): Information only

philwyett@ks-tarkin:~/Development/builder/debian/fennel-ls-0.2.1$ lrc
en: Versions: licenserecon '6.0'  licensecheck '3.3.9-1'

Parsing Source Tree  ....
Reading d/copyright  ....
  Missing Files: Paragraph for debian/
Running licensecheck ....

d/copyright      | licensecheck

Expat            | Expat and/or X11  docs/manual.md

Summary
=======

Looks promising. Some lintian and a copyright issue you may wish to look at.

Regards

Phil
    Needs work Phil Wyett at July 7, 2025, 11:11 a.m.

Upload #2

Information

Version: 0.2.1-1
Uploaded: 2025-07-05 19:27
Source package: fennel-ls_0.2.1-1.dsc
Distribution: unstable
Section: devel
Priority: optional
Homepage: https://git.sr.ht/~xerool/fennel-ls
Vcs-Browser: https://git.sr.ht/~technomancy/fennel-ls
Vcs-Git: https://git.sr.ht/~technomancy/fennel-ls
Closes bugs: #1108755

Changelog

 fennel-ls (0.2.1-1) unstable; urgency=medium
 .
   * New upstream release. (Closes: #1108755)

QA information

Comments

  1. Hi,

Seems we are missing 'pandoc' 'Build-Depends'.

Testing finished in approximately 0 second(s) with 570 assertion(s)
77 passed, 0 failed, 0 error(s), 0 skipped
0.21 second(s) of CPU time used
make[1]: Leaving directory '/build/reproducible-path/fennel-ls-0.2.1'
   create-stamp debian/debhelper-build-stamp
   dh_prep
   debian/rules override_dh_auto_install
make[1]: Entering directory '/build/reproducible-path/fennel-ls-0.2.1'
dh_auto_install -- PREFIX=/usr FENNELFLAGS='--add-fennel-path "src/?.fnl"'
	make -j8 install DESTDIR=/build/reproducible-path/fennel-ls-0.2.1/debian/fennel-ls AM_UPDATE_INFO_DIR=no "INSTALL=install --strip-program=true" PREFIX=/usr "FENNELFLAGS=--add-fennel-path \"src/?.fnl\""
make[2]: Entering directory '/build/reproducible-path/fennel-ls-0.2.1'
mkdir -p build/
echo ".TH FENNEL-LS 1" > build/fennel-ls.1
pandoc --title-prefix=fennel-ls -t man docs/manual.md >> build/fennel-ls.1
/bin/sh: 1: pandoc: not found
make[2]: *** [Makefile:55: build/fennel-ls.1] Error 127
make[2]: Leaving directory '/build/reproducible-path/fennel-ls-0.2.1'
dh_auto_install: error: make -j8 install DESTDIR=/build/reproducible-path/fennel-ls-0.2.1/debian/fennel-ls AM_UPDATE_INFO_DIR=no "INSTALL=install --strip-program=true" PREFIX=/usr "FENNELFLAGS=--add-fennel-path \"src/?.fnl\"" returned exit code 2
make[1]: *** [debian/rules:7: override_dh_auto_install] Error 25
make[1]: Leaving directory '/build/reproducible-path/fennel-ls-0.2.1'
make: *** [debian/rules:4: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------
Build finished at 2025-07-06T03:04:01Z
    Needs work Phil Wyett at July 6, 2025, 3:07 a.m. 
  2. Hi,

You may also wish to chnage the 'debian/changelog' text. For new packges it would normally be as below.

* Initial release. (Closes: #1108755)
    Needs work Phil Wyett at July 6, 2025, 3:09 a.m. 
  3. Thanks for the feedback.

I forgot about the built-time pandoc dependency. For the changelog, I originally published this to an unofficial 3rd-party repository, which is why I listed 0.1.3, but I don't think anyone who uses that repository is going to be too interested in the changelog, so I'll go ahead and pretend that doesn't exist.

The "very long line" warnings are from vendored dependencies that are left in the repository, but the Debian builds ignore the vendored files in favor of using the version of fennel that's already in apt. I think that means that the warnings are a red herring that it's OK to ignore.

The "debian-watch-file-pubkey-file-is-missing" also seems like a red herring since the tags are not signed by upstream.
    Needs work Phil Hagelberg at July 6, 2025, 5:56 p.m.

Upload #1

Information

Version: 0.2.1-1
Uploaded: 2025-07-02 02:57
Source package: fennel-ls_0.2.1-1.dsc
Distribution: unstable
Section: devel
Priority: optional
Homepage: https://git.sr.ht/~xerool/fennel-ls
Vcs-Browser: https://salsa.debian.org/technomancy-guest/fennel-ls/
Vcs-Git: https://salsa.debian.org/technomancy-guest/fennel-ls/

Changelog

 fennel-ls (0.2.1-1) unstable; urgency=medium
 .
   * New upstream release

QA information

Comments

  1. Hi,

This is a new package to Debian?

New packages need an ITP[1] that is closed in your innitial changelog entry, usually in the for of below.

  * Initial release. (Closes: #ITP_BUG_NUMBER)

Could you also rectify some of the litians warning such as:

 I out-of-date-standards-version

    4.7.0 (released 2024-04-07) (current is 4.7.2)

A new packag to Debian needs to support the latest Standards Version[2].

[1] https://wiki.debian.org/ITP
[2] https://www.debian.org/doc/debian-policy/

Regards

Phil
    Needs work Phil Wyett at July 2, 2025, 5:04 a.m. 
  2. Thanks; I was planning to file an ITP yesterday but ran out of time. I'll take a look at the lintian issues after that! I suspect missing-dep-for-interpreter is wrong like it was last time I saw it (with the fennel package) but the others look real. I can probably work around it by specifying the dependency on lua5.4 even tho that isn't actually needed.
    Needs work Phil Hagelberg at July 2, 2025, 4:01 p.m.