Sign me up Login

Details about package electrum-nmc

Name: electrum-nmc
Uploader: Nicholas Voyak <nnnnnnnnnnnn@airmail.cc> (Debian QA page)
Description: python3-electrum-nmc - Easy to use Namecoin client - Python module
electrum-nmc - Easy to use Namecoin client

Package uploads

Upload #2

Information

Version: 4.0.6-2
Uploaded: 2024-08-31 01:54
Source package: electrum-nmc_4.0.6-2.dsc
Distribution: unstable
Section: utils
Priority: optional
Homepage: https://www.namecoin.org/docs/electrum-nmc/

Changelog

 electrum-nmc (4.0.6-2) unstable; urgency=medium
 .
   * Correction in watch file
   * Correction in copyright file
   * Added forwarding status to Fix-libsecp256k1-path.patch

QA information

Comments

  1. I maintain the Electrum package in Debian.

https://tracker.debian.org/pkg/electrum

I see below that you have already contacted a Debian team for sponsorship, but if you haven't had a response from them you might consider maintaining it under the Debian Cryptocoin team.

https://salsa.debian.org/cryptocoin-team
    Soren Stoutner at Sept. 2, 2024, 6:06 p.m. 
  2. Hey. The Debian Cryptocoin team was actually the team I had contacted heh. I wonder if you didn't get my e-mail or if possibly the contact info is outdated?

E-mail headers:
From: nnnnnnnnnnnn@airmail.cc
To: team+cryptocoin@tracker.debian.org, jeremy@namecoin.org
Subject: Request for Sponsorship of Electrum-NMC 4.0.6
Date: Mon, 12 Aug 2024 22:05:16 -0300
    Nicholas Voyak at Sept. 11, 2024, 12:58 p.m. 
  3. It turns out I was a member of the team on Salsa but not subscribed to the email alias team+cryptocoin@tracker.debian.org (fixed now).

Did you get a response from anyone on the team?
    Soren Stoutner at Sept. 11, 2024, 10:55 p.m. 
  4. Oh.

>Did you get a response from anyone on the team?
No. After a while I opened a regular RFS and replied to that e-mail informing of this to avoid duplicated efforts. (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1080242)

I've asked the reviewer in the RFS a couple questions, and I imagine the next upload is coming briefly if you'd be interested
    Nicholas Voyak at Sept. 12, 2024, 1:05 a.m.

Upload #1

Information

Version: 4.0.6-1
Uploaded: 2024-08-13 00:39
Source package: electrum-nmc_4.0.6-1.dsc
Distribution: unstable
Section: utils
Priority: optional
Homepage: https://www.namecoin.org/docs/electrum-nmc/
Closes bugs: #1077302

Changelog

 electrum-nmc (4.0.6-1) unstable; urgency=low
 .
   * Initial Release.
   * Based on Debian Cryptocoin Team Electrum package and Lola Rigaut-Luczak's
     work.
     Closes: #1077302

QA information

Comments

  1. Hi,

You have indicated that you are looking for sponsorship, but have yet to file and Request For Sponsorship (RFS) bug.

https://mentors.debian.net/sponsors/rfs-howto/
    Phil Wyett at Aug. 13, 2024, 9:09 a.m. 
  2. Hey,

I've contacted a specific Debian team asking for sponsorship. I was worried that filing the RFS could lead to duplicated efforts. Should I change "Needs a sponsor" to no while I wait for their response?
    Nicholas Voyak at Aug. 13, 2024, 12:21 p.m. 
  3. Hi,

Yes, that would be good. If your sponsor is unable to help and you need a sponsor it can be toggled to "yes" again and an RFS filed.

Hopefully your sponsor can help.

Regards

Phil
    Phil Wyett at Aug. 13, 2024, 12:42 p.m. 
  4. I have already done a basic review, included below. You may wish to look at it and maybe address one or more of the issue prior to your sponsor giving you a helping hand.

Nicholas,

Preamble...

Thank you for taking the time to prepare this package and your contribution to the Debian project.

The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Good

2. Lintian [3]: Issue and information

I: electrum-nmc source: patch-not-forwarded-upstream [debian/patches/Fix-libsecp256k1-path.patch]
N: 
N:   According to the DEP-3 headers, this patch has not been forwarded
N:   upstream.
N:   
N:   Please forward the patch and try to have it included in upstream's version
N:   control system. If the patch is not suitable for that, please mention
N:   not-needed in the Forwarded field of the patch header.
N: 
N:   Please refer to social contract item 2, Coordination with upstream
N:   developers (Section 3.1.4) in the Debian Developer's Reference, Changes to
N:   the upstream sources (Section 4.3) in the Debian Policy Manual, and
N:   Bug#755153 for details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: debian/patches/dep3
N:   Renamed from: send-patch

Information only, future for upstream.

I: electrum-nmc source: uses-deprecated-python-stdlib chunk (deprecated in Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/blockchain.py:586]
N: 
N:   
N:   In Python $deprecated, $library has been formally marked as deprecated.
N:   Code that imports $library will no longer work from Python $removed.
N:   
N:   Please prepare for this deprecation and migrate away from this Python
N:   library.
N:   
N:   See-Also: https://peps.python.org/pep-0594/#deprecated-modules
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: languages/python/stdlib-deprecation
N: 
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:71]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:75]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:76]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:77]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:78]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:79]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:80]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:83]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:84]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib distutils (deprecated in Python 3.10, removed in Python 3.12) [electrum_nmc/electrum/gui/qt/update_checker.py:7

3. Licenses [4]: Issue

philwyett@ks-tarkin:~/Development/builder/debian/mentoring/electrum-nmc-4.0.6$ lrc -t
: Versions: recon 1.14  check 3.3.9-1

Parsing Source Tree  ....
Reading copyright    ....
Running licensecheck ....

d/copyright     | licensecheck

Expat           | GPL-3            Electrum_NMC.egg-info/PKG-INFO
Expat           | OFL-1.1          electrum_nmc/electrum/plugins/revealer/SIL Open Font License.txt
OFL             | OFL-1.1          electrum_nmc/electrum/plugins/revealer/SourceSansPro-Bold.otf

The latter two can be rectified by changing the appropriate section in 'debian/coyright' to the below.

Files: electrum_nmc/electrum/plugins/revealer/SourceSansPro-Bold.otf
       electrum_nmc/electrum/plugins/revealer/SIL?Open?Font?License.txt
Copyright: 2010, 2012 Adobe Systems Incorporated (http://www.adobe.com/)
License: OFL-1.1

4. Watch file [uscan --force-download]: Issue

philwyett@ks-tarkin:~/Development/builder/debian/mentoring/electrum-nmc-4.0.6$ uscan --force-download 
uscan warn: In watch file debian/watch, reading webpage
  https://www.namecoin.org/files/electrum-nmc/ failed: 403 Forbidden

5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good

6. Reproducible builds [5]: Good

7. Install [No previous installs]: 

8. Upgrade [Over previous installs if any]: N/A

Additional...

A. The first 'debian/changelog' entry only needs the blow.

* Initial Release (Closes: #1077302).

Summary...

I believe electrum-nmc is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the rasied issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' tag on the Request For Sponsorship (RFS) bug report.

Regards

Phil

[1] pbuilder:

  * Command: sudo pbuilder build <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild <PACKAGE>.dsc
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc -t
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
    Needs work Phil Wyett at Aug. 13, 2024, 12:44 p.m.