Sign me up Login

Details about package devilutionx

Name: devilutionx
Uploader: Kirill Rekhov <krekhov.dev@gmail.com> (Debian QA page)
Description: devilutionx - diablo build for modern operating systems
devilutionx-data - architecture-independent data files for DevilutionX

Package uploads

Upload #2

Information

Version: 1.5.4+ds2-1
Uploaded: 2025-05-08 23:42
Source package: devilutionx_1.5.4+ds2-1.dsc
Distribution: unstable
Section: games
Priority: optional
Homepage: https://github.com/diasurgical/DevilutionX
Vcs-Git: https://salsa.debian.org/krekhov/Devilutionx.git
Vcs-Browser: https://salsa.debian.org/krekhov/Devilutionx
Closes bugs: #1088174

Changelog

 devilutionx (1.5.4+ds2-1) unstable; urgency=medium
 .
   * Initial release (Closes: #1088174)

QA information

Comments

  1. Hi, Phil, Thanks for noticing, I've fixed it. If everything is ok, don't forget to include the +confirmed tag: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1104851
    Ready Kirill Rekhov at May 8, 2025, 11:49 p.m.

Upload #1

Information

Version: 1.5.4+ds2-1
Uploaded: 2025-05-06 23:42
Source package: devilutionx_1.5.4+ds2-1.dsc
Distribution: unstable
Section: games
Priority: optional
Homepage: https://github.com/diasurgical/DevilutionX
Vcs-Git: https://salsa.debian.org/krekhov/Devilutionx.git
Vcs-Browser: https://salsa.debian.org/krekhov/Devilutionx
Closes bugs: #1088174

Changelog

 devilutionx (1.5.4+ds2-1) unstable; urgency=medium
 .
   * Initial release (Closes: #1088174)

QA information

Comments

  1. Kirill,

Looks good, just a couple of lintian issues you may wish to look at.

Running lintian...
N:
P: devilutionx: copyright-refers-to-symlink-license usr/share/common-licenses/LGPL
N: 
N:   The copyright file refers to the versionless symlink in
N:   /usr/share/common-licenses for the full text of the GPL, LGPL, or GFDL
N:   license. This symlink is updated to point to the latest version of the
N:   license when a new one is released. The package appears to allow
N:   relicensing under later versions of its license, so this is legally
N:   consistent, but it implies that Debian will relicense the package under
N:   later versions of those licenses as they're released. It is normally
N:   better to point to the version of the license the package references in
N:   its license statement.
N:   
N:   For example, if the package says something like "you may redistribute it
N:   and/or modify it under the terms of the GNU General Public License as
N:   published by the Free Software Foundation; either version 2, or (at your
N:   option) any later version", the debian/copyright file should refer to
N:   /usr/share/common-licenses/GPL-2, not /GPL.
N:   
N:   For packages released under the same terms as Perl, Perl references the
N:   GPL version 1, so point to /usr/share/common-licenses/GPL-1.
N: 
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: debian/copyright
N: 
N:
P: devilutionx-data: copyright-refers-to-symlink-license usr/share/common-licenses/LGPL
N:
P: devilutionx source: package-does-not-install-examples [dist/libzt-src/examples/]
N: 
N:   The original source tarball contains the specified examples directory.
N:   However, no examples are installed in any binary packages.
N:   
N:   Please use dh_installexamples to install these to the most relevant
N:   package, for example by adding the directory name followed by a wildcard
N:   to a debian/pkgname.examples file.
N:   
N:   Lintian looks for any directory called examples under /usr/share/doc in
N:   all binary packages.
N: 
N:   Please refer to the dh_installexamples(1) manual page for details.
N: 
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: examples
N: 
N:   Screen: examples/in-tests
N:     Advocates: "Scott Kitterman" <debian@kitterman.com>
N:     Reason: 
N:             Some sources like python-tomlkit trigger this tag for tests because of files
N:             in ./tests/examples/. They are not examples for tomlkit, however. They are
N:             examples of TOML files used in the tests.
N:             
N:             Overall, the check is probably better off not looking in test
N:             directories.
N:             
N:             Read more in Bug#1005184.
N: 
N:
P: devilutionx source: package-does-not-install-examples [dist/libzt-src/ext/ZeroTierOne/ext/hiredis-0.14.1/examples/]
N:
P: devilutionx source: package-does-not-install-examples [dist/libzt-src/ext/ZeroTierOne/rule-compiler/examples/]
N:
P: devilutionx source: package-does-not-install-examples [dist/libzt-src/ext/lwip-contrib/examples/]
N:
P: devilutionx source: package-does-not-install-examples [dist/libzt-src/pkg/crate/libzt/src/examples/]
N:
P: devilutionx source: source-contains-autogenerated-visual-c++-file [dist/libzt-src/ext/ZeroTierOne/windows/TapDriver6/resource.h]
N: 
N:   The following file is autogenerated by Microsoft Visual C++.
N:   
N:   They are usually provided for the convenience of users. These files
N:   usually just take up space in the tarball and are of no use in Debian.
N:   
N:   Check if upstream also provides source-only tarballs that you can use as
N:   the upstream distribution instead. If not, you may want to ask upstream to
N:   provide source-only tarballs.
N: 
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: cruft
N: 
N:
P: devilutionx source: source-contains-autogenerated-visual-c++-file [dist/libzt-src/ext/ZeroTierOne/windows/TapDriver6/resource.rc]
N:
P: devilutionx source: source-contains-autogenerated-visual-c++-file [dist/libzt-src/ext/ZeroTierOne/windows/ZeroTierOne/resource.h]
N:
P: devilutionx source: source-contains-prebuilt-java-object [android-project/gradle/wrapper/gradle-wrapper.jar]
N: 
N:   The source tarball contains a prebuilt Java class file. These are often
N:   included by mistake when developers generate a tarball without cleaning
N:   the source directory first. If there is no sign this was intended,
N:   consider reporting it as an upstream bug as it may be a DFSG violation.
N: 
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: languages/java
N: 
N:
P: devilutionx source: source-contains-prebuilt-java-object [dist/libzt-src/pkg/android/gradle/wrapper/gradle-wrapper.jar]
N:
P: devilutionx source: source-contains-prebuilt-javascript-object [dist/libzt-src/ext/ZeroTierOne/rule-compiler/rule-compiler.js]
N: 
N:   The source tarball contains a prebuilt (minified) JavaScript object. They
N:   are usually left by mistake when generating the tarball by not cleaning
N:   the source directory first. You may want to report this as an upstream
N:   bug, in case there is no sign that this was intended.
N: 
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: files/source-missing
N: 
N:
N: The "dir-no-metadata-found" info message from appstreamcli can be ignored
O: devilutionx-data: appstream-metadata-validation-failed Problems reported by "appstreamcli validate-tree".
N: 
N:   The specified AppStream metadata file fail to validate using 'appstreamcli
N:   validate-tree --no-net path-to-package-root'.
N: 
N:   Please refer to https://wiki.debian.org/AppStream/Guidelines for details.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: appstream-metadata
N: 
N:
N: no old addresses in copyright file
O: devilutionx: old-fsf-address-in-copyright-file
N: 
N:   The /usr/share/doc/*pkg*/copyright file refers to the old postal address
N:   of the Free Software Foundation (FSF). You should refer to
N:   https://www.gnu.org/licenses/ instead of a physical address, for example:
N:   
N:     You should have received a copy of the GNU General Public License
N:     along with this program.  If not, see https://www.gnu.org/licenses/.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: debian/copyright
N: 
N:
N: no old addresses in copyright file
O: devilutionx-data: old-fsf-address-in-copyright-file
N:
N: It's OK
O: devilutionx-data: package-contains-documentation-outside-usr-share-doc [usr/share/diasurgical/devilutionx/README.txt]
N: 
N:   This package ships a documentation file outside /usr/share/doc
N:   Documentation files are normally installed inside /usr/share/doc.
N:   
N:   If this file doesn't describe the contents or purpose of the directory it
N:   is in, please consider moving this file to /usr/share/doc/ or maybe even
N:   removing it. If this file does describe the contents or purpose of the
N:   directory it is in, please add a lintian override.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: documentation
N: 
N:   Screen: python/egg/metadata
N:     Advocates: "Scott Kitterman" <debian@kitterman.com>
N:     Reason: The folders XXX.dist-info/ and XXX.egg-info/ hold metadata for
N:             Python modules. Those files are not documentation even though
N:             some of their names carry the .txt file extension.
N:             
N:             Python modules can be both public and private.
N:             
N:             Read more in
N:             https://www.python.org/dev/peps/pep-0427/#the-dist-info-directory,
N:             https://www.python.org/dev/peps/pep-0376/#id16,
N:             https://www.python.org/dev/peps/pep-0610/,
N:             https://www.python.org/dev/peps/pep-0639/,
N:             https://setuptools.pypa.io/en/latest/deprecated/python_eggs.html,
N:             and Bug#1003913.
N: 

I: Lintian run was successful.

Regards

Phil
    Phil Wyett at May 7, 2025, 12:55 p.m.