Sign me up Login

Details about package ddclient

Name: ddclient (PTS)
Uploader: Richard Hansen <rhansen@rhansen.org> (Debian QA page)
Description: ddclient - address updating utility for dynamic DNS services

Package uploads

Upload #1

Information

Version: 4.0.0-1
Uploaded: 2025-01-29 22:56
Source package: ddclient_4.0.0-1.dsc
Distribution: unstable
Section: net
Priority: optional
Homepage: https://ddclient.net
Vcs-Git: https://salsa.debian.org/debian/ddclient.git
Vcs-Browser: https://salsa.debian.org/debian/ddclient

Changelog

 ddclient (4.0.0-1) unstable; urgency=medium
 .
   * debian/watch: Drop unnecessary filenamemangle
   * debian/watch: Mangle upstream vX.Y.Z_N tags to X.Y.Z~rc.N
   * debian/watch: Mangle dash in upstream -beta, -rc tags to tilde
   * debian/watch: Scan release artifacts, not automatic tag tarballs
   * debian/gbp.conf: Mangle tilde to dash for upstream tag version
   * debian/patches: Drop unnecessary maxinterval.diff
   * New upstream version 4.0.0
     + Drop patch applied upstream
   * Add iproute2 to build dependencies (for unit tests)
   * Update debian/copyright
   * postinst: Don't exit early if passed an unknown argument
   * New README.Debian to explain service vs. one-shot modes of operation
   * Remove old SysV init script
   * Always default to periodic checks (daemon mode)
   * Don't install a PPP hook
   * Don't install a DHCP hook
   * Delete the recap file on purge, not remove
   * Remove /etc/default/ddclient
   * Replace debconf with a minimal static default config
   * Move ddclient.conf to /etc/ddclient to match upstream

QA information

Comments

  1. Richard,

Preamble...

Thank you for taking the time to prepare this package and your contribution to the Debian project.

This review is offered to help package contributors to Debian mentors improve their packages (where needed) prior to possible sponsorship into Debian by a Debian Developer.


Review...

1. Build:

  * pbuilder [1]: Good, See: Additional A.
 
  * sbuild [2]: Good, See: Additional A.


2. Lintian [3]: Good


3. Licenses [4]: Good


4. Watch file [uscan --force-download]: Good


5. Build Twice (build source after successful build) [1]: Good, See: Additional A.


6. Reproducible builds [5]: Good, See: Additional A.

Note: This test does not block sponsorship and is for information only at this time. It is good if a package passes this test.


7. Tail of the ratt (architecture dependant packages only) [6]: N/A

Note: This test does not block sponsorship and is for information only at this time. It is good if a package passes this test.


8. Install [No previous installs]: N/A


9. Upgrade [Over previous installs if any]: N/A


Additional...

A. Internal package tests

# Looks like you failed 2 tests of 9.
# your server received SIGPIPE
ok 1 - usev4=webv4 web-ssl-validate=no
PASS: t/ssl-validate.pl 1 - usev4=webv4 web-ssl-validate=no
ok 2 - usev4=webv4 web-ssl-validate=yes
PASS: t/ssl-validate.pl 2 - usev4=webv4 web-ssl-validate=yes
ok 3 - usev6=webv6 web-ssl-validate=no
PASS: t/ssl-validate.pl 3 - usev6=webv6 web-ssl-validate=no
ok 4 - usev6=webv6 web-ssl-validate=yes
PASS: t/ssl-validate.pl 4 - usev6=webv6 web-ssl-validate=yes
not ok 5 - usev4=cisco-asa fw-ssl-validate=no
FAIL: t/ssl-validate.pl 5 - usev4=cisco-asa fw-ssl-validate=no
ok 6 - usev4=cisco-asa fw-ssl-validate=yes
PASS: t/ssl-validate.pl 6 - usev4=cisco-asa fw-ssl-validate=yes
not ok 7 - usev4=fwv4 fw-ssl-validate=no
FAIL: t/ssl-validate.pl 7 - usev4=fwv4 fw-ssl-validate=no
ok 8 - usev4=fwv4 fw-ssl-validate=yes
PASS: t/ssl-validate.pl 8 - usev4=fwv4 fw-ssl-validate=yes
ok 9 - no (unexpected) warnings (via done_testing)
PASS: t/ssl-validate.pl 9 - no (unexpected) warnings (via done_testing)
1..9
ERROR: t/ssl-validate.pl - exited with status 2

============================================================================
Testsuite summary for ddclient 4.0.0
============================================================================
# TOTAL: 762
# PASS:  757
# SKIP:  2
# XFAIL: 0
# FAIL:  2
# XPASS: 0
# ERROR: 1
============================================================================
See ./test-suite.log for debugging.
============================================================================



Summary...

Internal testing seems to show error you may wish to look at before filing an RFS.

I believe 'ddclient' is ready for review/possible sponsorship.

If you do not have upload rights or a regular sponsor. You can follow the RFS process linked to below.

https://mentors.debian.net/sponsors/rfs-howto/


Please try the below on your packages...

[1] pbuilder:

  * Command for 1.: sudo pbuilder build <PACKAGE>.dsc
  * Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks


[2] sbuild:

  * Command: sbuild -d unstable <PACKAGE>.dsc
  * Document: https://wiki.debian.org/sbuild


[3] lintian:

  * Command: lintian --display-info --verbose --fail-on error --info --pedantic --show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian


[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

  Note: Please report false positives as bug reports against 'licenserecon'.


[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method


[6] ratt

  * Command: ratt --dist=<YOUR_DISTRIBUTION> <PACKAGE>_<VERSION>-<DEBIAN_REVISION>_<ARCHITECTURE>.changes
  * Document: https://manpages.debian.org/unstable/ratt/ratt.1.en.html


Regards

Phil
    Ready Phil Wyett at Jan. 30, 2025, 12:09 p.m.