Sign me up Login

Details about package apachetop

Name: apachetop (PTS)
Uploader: Osman Romulo Condori Guevara <osman.cg@gmail.com> (Debian QA page)
Description: apachetop - Realtime Apache monitoring tool

Package uploads

Upload #1

Information

Version: 0.23.2-4.2~mentors1
Uploaded: 2025-07-21 07:12
Source package: apachetop_0.23.2-4.2~mentors1.dsc
Distribution: unstable
Section: admin
Priority: optional
Homepage: https://github.com/tessus/apachetop
Vcs-Git: https://salsa.debian.org/debian/apachetop.git
Vcs-Browser: https://salsa.debian.org/debian/apachetop

Changelog

 apachetop (0.23.2-4.2~mentors1) unstable; urgency=medium
 .
   * Fix bug closure: close only bug #1098915, not #1107844 (already closed).
   * Add Upstream-Contact field in debian/copyright.
   * Fix lintian warnings related to copyright and other minor fixes.

QA information

Comments

  1. Thank you for properly filing the ITA bug. However, there are underlying issues. VCS isn't showing the changes because you're not making them directly in the original repository. I recommend you write to the mentors list requesting maintainer access to the apachetop repository:
https://salsa.debian.org/debian/apachetop

Say you've just adopted the package and need to upload a new version. To do so, add the link to the ITA bug:
https://bugs.debian.org/1098915

There's still a lot more to do, but one thing at a time... You haven't correctly filled out the RFS request, which is required for reviewers to write recommendations.

Regards,
    Needs work Manuel Guerra at July 21, 2025, 1:06 p.m. 
  2. Okay, so this is easier to understand: the apachetop package is already in Debian and is hosted in the "debian" namespace reserved for Debian Developers (DDs). The changes you're going to make need to be made directly in that repository, not in another. To do so, you must ask a DD for permission to grant you access to the repository as a maintainer.

Write to the mentor list requesting access to the repository, something like this:

Subject: apachetop repository access
Message body:

I recently adopted apachetop (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1098915). Could a DD grant me access as a maintainer to this repository, since I need to push a new version?

https://salsa.debian.org/debian/apachetop

Once you have access to that repository, you should make changes directly there or first make changes in a fork and, after testing them, move them to the main repository via a MR.

I must make it clear that this is a huge responsibility. Just because the package has been put up for adoption doesn't mean it's less important or that no one uses it anymore. The previous maintainer made it clear that the package is in good shape, and this should remain the case over time. Debian's primary rule is to guarantee high-quality packages.

Regards,
    Needs work Manuel Guerra at July 21, 2025, 1:39 p.m. 
  3. As Soren mentioned you should wait to have your Salsa account active to move forward with this... I will be mentoring your work on apachetop until a new version is pushed to Debian, I will also be keeping an eye on changes applied to the apachetop repository in Salsa.

You can reply here to ask for assistance until your RFS bug is ready.

Regards,
    Needs work Manuel Guerra at July 21, 2025, 5:34 p.m. 
  4. Thank you very much for your guidance, Manuel.

I'll wait for my Salsa account to be approved before proceeding. Once I have access, I’ll prepare a consolidated version (-4) directly in the official repository and update the RFS accordingly.

I appreciate your support in mentoring this package.

Best regards,  
Osman Romulo Condori Guevara
    Needs work Osman Romulo Condori Guevara at July 21, 2025, 6:18 p.m. 
  5. Hello Manuel,

I wanted to update you on the current progress with the apachetop package:

I have pushed the proposed packaging changes to the official Salsa repository in a dedicated branch.

A merge request is open here: https://salsa.debian.org/debian/apachetop/-/merge_requests

I have also submitted the RFS, which is now tracked under bug #1109745:
https://bugs.debian.org/1109745

If everything looks good, I would be grateful for your support in sponsoring the upload.

Thank you very much again for your mentorship and guidance.

Best regards,
Osman Romulo Condori Guevara
    Needs work Osman Romulo Condori Guevara at July 23, 2025, 5:08 a.m. 
  6. Osman,

Thanks for mentioning the updates. I have a few suggestions for you to implement in apachetop:

1. Don't customize the repository branches, instead use something standard that other maintainers can use in the future, like debian/packaging or something similar.

2. In the changelog, you should close the ITA and RFS bugs, as well as any other bugs affecting the Apachetop package, such as an FRP or ITP, as Aryan mentioned in the RFS reply. For example:

(Closes: #1109745) > RFS Bug
(Closes: #1098915) > ITA Bug

The new version should be -4 instead of -4.2.

Since the package is already in Debian, the changes should be set to UNRELEASED until they are ready to be uploaded to the archive.

I think something like this would fit well:

apachetop (0.23.2-4) UNRELEASED; urgency=medium

* Update debian/control:
- Set myself as the new maintainer due to the package adoption.
  (Closes: #1098915, #1109745)

3 Remove the rules-requires-root section because the new behavior for this has been set to no by default and it only needs to be added when declared as yes.

4 Add yourself to the debian/ stanzas *

5 Separate the license text from the stanzas, example:

Files: src/pcre2_cpp_wrapper.h
Copyright: 2003 Peter Petersen <pp@on-time.de>
2023 Helmut K. C. Tessarek (tessarek@evermeet.cx)
License: Special

License: Special
This source file is freeware. You may use it for any purpose without restriction except that the copyright notice at the top of this file, as well as this paragraph, may not be removed or altered.
Comment: This license applies only to src/pcre2_cpp_wrapper.h and is not a standard SPDX license. It has been reviewed and is considered DFSG-free.

These are just a few cosmetic changes; the package needs some additional tweaks to comply with new Debian standards, such as GBP branches or setting up Salsa's CI pipeline. But one thing at a time, take this slowly. If you're going to be the maintainer of this package, this is a years-long project.

Let me take a closer look at the package.

Regards,
    Needs work Manuel Guerra at July 23, 2025, 1:56 p.m. 
  7. Hi Manuel,

Thank you for your guidance and suggestions.

I’ve now implemented all the recommended changes in the Salsa repository, including:

- Setting the correct version to `0.23.2-4`.
- Updating the changelog to properly close the ITA and RFS bugs.
- Removing the `Rules-Requires-Root` field.
- Adjusting the license layout and separating the special license section as advised.
- Adding myself to the `debian/*` stanzas in `debian/copyright`.

For this upload, I’ve kept the current branch name (`osman/package-maintenance`) since the MR has already been approved by Soren and we are close to finalizing the process. However, I will follow your suggestion and use a more standard branch name (like `debian/packaging`) for future work on this package or others.

Once the MR is merged, the branch will be automatically deleted as per the MR options.

Thanks again for mentoring me through this process!
    Needs work Osman Romulo Condori Guevara at July 23, 2025, 6:48 p.m.