Sign me up Login

Details about package "owlrl"

Name: owlrl
Uploader: Ashley Sommer <Ashley.Sommer@csiro.au> (Debian QA page)
Description: python3-owlrl - OWL-RL and RDFS based RDF Closure inferencing for Python

Package versions

Version 5.2.0-1

Information

Version: 5.2.0-1
Uploaded: 2019-02-07 09:43
Source package: https://mentors.debian.net/debian/pool/main/o/owlrl/owlrl_5.2.0-1.dsc
Section: python
Priority: optional
Closes bugs: 919440

QA information

Comments

  1. Looks good, uploading...
    Perfect Jonathan Carter at 2019-02-07 10:20:44.585421 
  2. Uploadede to NEW
    Perfect Jonathan Carter (highvoltage) <jcc> at 2019-02-07 11:49:59.235663 Package has been uploaded to Debian

Version 5.2.0-1

Information

Version: 5.2.0-1
Uploaded: 2019-02-07 00:20
Source package: https://mentors.debian.net/debian/pool/main/o/owlrl/owlrl_5.2.0-1.dsc
Section: python
Priority: optional
Closes bugs: 919440

QA information

Comments

  1. Great, that built in a clean chroot for me now. Although it does have a few odd and some minor issues that I think you should look at:

Lintian reports that it seems to try to use a python exe as interpreter for some python scripts, this doesn't seem intended?

"""
W: python3-owlrl: unusual-interpreter usr/lib/python3/dist-packages/owlrl/Closure.py #!/d/Bin/Python/python.exe
W: python3-owlrl: unusual-interpreter usr/lib/python3/dist-packages/owlrl/CombinedClosure.py #!/d/Bin/Python/python.exe
"""

In debian/control, some fields are just out of date (standards version should be 4.3.0, X-Python3-Version can probably be dropped entirely, only 3.7 is available in unstable). Minor issue, but since you're there: python should be capitilized as "Python" in the package description.

Your debian/changelog entry is quite long, I recommend just making it "Initial release (Closes: 919440)"

You should probably remove debian/NEWS, since it ends up being installed next to "usr/share/doc/python3-owlrl/NEWS.Debian.gz" which is right next to "usr/share/doc/python3-owlrl/changelog.gz", and you probably don't need those two identical files there.

Sorry for not doing a more complete review from the start, time constraints and all, almost there.
    Needs work Jonathan Carter at 2019-02-07 07:13:26.522798 
  2. Jonathan thank you for your constructive feedback.

Those unusual-interpreter warnings look to be leftover shebangs from the previous author's old dev environment. They weren't hurting anything, but I've removed them, so that should quiet the warnings.

I've made the other suggested changes too, please see the new version uploaded: 2019-02-07 09:43
    Ashley Sommer at 2019-02-07 09:49:24.987620

Version 5.2.0-1

Information

Version: 5.2.0-1
Uploaded: 2019-01-29 09:17
Source package: https://mentors.debian.net/debian/pool/main/o/owlrl/owlrl_5.2.0-1.dsc
Section: python
Priority: optional
Closes bugs: 919440

QA information

Comments

  1. Packaging looks a lot better, thanks! I just ran into an issue while trying to build it in a clean chroot:

"""
======================================================================
ERROR: owlrl (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: owlrl
Traceback (most recent call last):
  File "/usr/lib/python3.7/unittest/loader.py", line 470, in _find_test_path
    package = self._get_module_from_name(name)
  File "/usr/lib/python3.7/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/build/owlrl-5.2.0/.pybuild/cpython3_3.7_owlrl/build/owlrl/__init__.py", line 171, in <module>
    import rdflib
ModuleNotFoundError: No module named 'rdflib'
"""

It seems that you need to build-depend on one of the python3 rdflib packages in order for the tests to run.
    Needs work Jonathan Carter at 2019-02-06 10:49:07.689675 
  2. Yes, I noticed that when I did a build last week. I uploaded a fix when I did my builds to the github releases page, but I forgot to re-upload the source-package on here.
I've re-uploaded now with build-depends on python3-rdflib and python3-pytest so that the tests run successfully.
See new version uploaded: 2019-02-07 00:20
- Ashley
    Ashley Sommer at 2019-02-07 00:26:31.074776

Version 5.2.0-1

Information

Version: 5.2.0-1
Uploaded: 2019-01-29 08:56
Source package: https://mentors.debian.net/debian/pool/main/o/owlrl/owlrl_5.2.0-1.dsc
Section: python
Priority: optional
Closes bugs: 919440

QA information

Comments

No comments

Version 5.2.0-1

Information

Version: 5.2.0-1
Uploaded: 2019-01-16 02:53
Source package: https://mentors.debian.net/debian/pool/main/o/owlrl/owlrl_5.2.0-1.dsc
Section: python
Priority: optional
Closes bugs: 919440

QA information

Comments

  1. You'll have to fix the packaging created by stdeb.

In particular, pay attention to debian/control, there are many extra spaces, and the description isn't very good, I suggest trying to cut it back to the minimum. Debhelper depends is still on 9, you probably want to get that to at least 11 along with debian/compat.

Remove stdeb boilerplate, such as the comments in debian/rules.

You will also want to create a proper machine-readable debian/copyright file.
    Needs work Jonathan Carter at 2019-01-23 10:51:37.005012