Details about package melonds

Name:	melonds
Uploader:	Mae Miller <maeborow@posteo.net> (Debian QA page)
Description:	melonds - Nintendo DS emulator

Package uploads

Upload #4

Information

Version:	0.9.5-1
Uploaded:	2023-08-28 21:52
Source package:	melonds_0.9.5-1.dsc
Distribution:	UNRELEASED
Section:
Priority:
Homepage:	https://melonds.kuribo64.net/
Vcs-Git:	https://salsa.debian.org/x4d6165/melonds/ -b master
Closes bugs:	#1050356

Changelog

 melonds (0.9.5-1) UNRELEASED; urgency=medium
 .
   * Initial release. (Closes: #1050356)

QA information

–
Package uploaded for the UNRELEASED distribution
–
Package uses debhelper-compat

Debhelper compatibility level 13
–
Watch file is not present
–
Package is not native

Format: 3.0 (quilt)
–
"Maintainer" email is the same as the uploader
–
Package has lintian warnings
melonds
- W no-manual-page
  - [usr/bin/melonDS]
- W recommended-field
  - melonds_0.9.5-1_amd64.deb Priority
  - melonds_0.9.5-1_amd64.deb Section
- I extended-description-is-probably-too-short
- I hardening-no-bindnow
  - [usr/bin/melonDS]
- I spelling-error-in-binary
  - Faild Failed [usr/bin/melonDS]
  - occured occurred [usr/bin/melonDS]
  - succeded succeeded [usr/bin/melonDS]
melonds source
- W newer-standards-version
  - 4.6.2 (current is 4.6.1.0)
- W recommended-field
  - (in section for source) Priority [debian/control:1]
  - (in section for source) Section [debian/control:1]
- W syntax-error-in-dep5-copyright
  - Continuation line not in paragraph (line 477). Missing a dot on the previous line? [debian/copyright]
- I debian-watch-file-is-missing
- I missing-vcs-browser-field
  - Vcs-Git https://salsa.debian.org/x4d6165/melonds/ -b master
- I unreleased-changelog-distribution
  - [debian/changelog:1]
- P debian-control-has-unusual-field-spacing
  - Homepage:https [debian/control:10]
  - Vcs-Git:https [debian/control:11]
- P silent-on-rules-requiring-root
  - [debian/control]
- P very-long-line-length-in-source-file
  - 1488 > 512 [src/frontend/glad/glad_wgl.c:73]
  - 1488 > 512 [src/frontend/glad/glad_wgl.h:73]
  - 1725 > 512 [src/frontend/glad/glad_glx.c:84]
  - 1725 > 512 [src/frontend/glad/glad_glx.h:84]
  - 2464 > 512 [freebios/drastic_bios_arm9.bin:14]
  - 5008 > 512 [res/melon.icns:257]
  - 556 > 512 [src/fatfs/ffunicode.c:15484]
  - 645 > 512 [src/teakra/externals/catch/catch.hpp:909]
  - 647 > 512 [src/teakra/src/dma.md:99]
  - 661 > 512 [src/teakra/src/mmio.md:3]
  - 705 > 512 [src/teakra/src/processor_general.md:5]
  - 728 > 512 [src/fatfs/LICENSE.txt:24]
  - 757 > 512 [debian/copyright:573]
  - 802 > 512 [src/teakra/README.md:19]
  - 824 > 512 [src/teakra/src/register.md:25]
  - 8303 > 512 [freebios/drastic_bios_arm7.bin:31]
- X upstream-metadata-file-is-missing
–
Package closes bugs in a wrong way
Errors:
- Bug #1050356 is a RFS bug
- melonds:
  - #1050356 (Wishlist, RFS): RFS: melonds/0.9.5 [ITP] -- nintendo DS emulator
–
Package is not in Debian

–

Upstream-Contact missing from d/copyright

Upstream Contact:	None
Licenses:	UNKNOWN, GPL-2, BSD-3-clause and/or BSD-4-clause, Apache-2.0, public-domain, BSL-1.0, BSD-2-clause, BSD-4-Clause-UC, BSD-3-clause, BSD-4-clause-UC, GPL-3

Comments

Hi, also this time I only gave a fast look.
quilt format now is ok
the close in d/changelog now is wrong, should point to #1050348 (ITP bug) as was before (on first and second upload was correct).
d/copyright now is more complete (I not checked good), have you asked to a expert DD about the freebios binaries?
it might be useful to "compact" d/copyright a bit by merging parts with same licenses, however it's secondary, for example use "Files: *" (putting all copyrights) for all files of the main license and/or grouping whole folders with same license in one line (e.g. "debian/*" instead one line for any file of debian directory)
did a fast look to salsa repo, please make default the right branch (seems "master" and not "main") and remove the files related to package build before do commit (for example with "debuild clean")
d/watch is missed, can you do fast for example take this (https://salsa.debian.org/cinnamon-team/xapp/-/blob/master/debian/watch) and replace "https://github.com/linuxmint/xapp/tags" with "https://github.com/melonDS-emu/melonDS/tags"

Needs work Fabio Fantoni at Aug. 30, 2023, 8:09 p.m.

Upload #3

Information

Version:	0.9.5-1
Uploaded:	2023-08-28 20:52
Source package:	melonds_0.9.5-1.dsc
Distribution:	UNRELEASED
Section:
Priority:
Homepage:	https://melonds.kuribo64.net/
Closes bugs:	#1050356

Changelog

 melonds (0.9.5-1) UNRELEASED; urgency=medium
 .
   * Initial release. (Closes: #1050356)

QA information

–
Package uploaded for the UNRELEASED distribution
–
Package uses debhelper-compat

Debhelper compatibility level 13
–
Watch file is not present
–
Package is not native

Format: 3.0 (quilt)
–
"Maintainer" email is the same as the uploader
–
Package has lintian errors
melonds
- E copyright-file-contains-full-gpl-license
- E copyright-not-using-common-license-for-gpl
- W no-manual-page
  - [usr/bin/melonDS]
- W recommended-field
  - melonds_0.9.5-1_amd64.deb Priority
  - melonds_0.9.5-1_amd64.deb Section
- I extended-description-is-probably-too-short
- I hardening-no-bindnow
  - [usr/bin/melonDS]
- I spelling-error-in-binary
  - Faild Failed [usr/bin/melonDS]
  - occured occurred [usr/bin/melonDS]
  - succeded succeeded [usr/bin/melonDS]
melonds source
- W newer-standards-version
  - 4.6.2 (current is 4.6.1.0)
- W recommended-field
  - (in section for source) Priority [debian/control:1]
  - (in section for source) Section [debian/control:1]
- I debian-watch-file-is-missing
- I unreleased-changelog-distribution
  - [debian/changelog:1]
- P debian-control-has-unusual-field-spacing
  - Homepage:https [debian/control:10]
- P no-dep5-copyright
  - [debian/copyright]
- P silent-on-rules-requiring-root
  - [debian/control]
- P very-long-line-length-in-source-file
  - 1488 > 512 [src/frontend/glad/glad_wgl.c:73]
  - 1488 > 512 [src/frontend/glad/glad_wgl.h:73]
  - 1725 > 512 [src/frontend/glad/glad_glx.c:84]
  - 1725 > 512 [src/frontend/glad/glad_glx.h:84]
  - 2464 > 512 [freebios/drastic_bios_arm9.bin:14]
  - 5008 > 512 [res/melon.icns:257]
  - 556 > 512 [src/fatfs/ffunicode.c:15484]
  - 645 > 512 [src/teakra/externals/catch/catch.hpp:909]
  - 647 > 512 [src/teakra/src/dma.md:99]
  - 661 > 512 [src/teakra/src/mmio.md:3]
  - 691 > 512 [debian/copyright:3231]
  - 705 > 512 [src/teakra/src/processor_general.md:5]
  - 728 > 512 [src/fatfs/LICENSE.txt:24]
  - 802 > 512 [src/teakra/README.md:19]
  - 824 > 512 [src/teakra/src/register.md:25]
  - 8303 > 512 [freebios/drastic_bios_arm7.bin:31]
- X upstream-metadata-file-is-missing
–
Package closes bugs in a wrong way
Errors:
- Bug #1050356 is a RFS bug
- melonds:
  - #1050356 (Wishlist, RFS): RFS: melonds/0.9.5 [ITP] -- nintendo DS emulator
–
No VCS field present
–
Package is not in Debian
–
d/copyright is not in DEP5 format

Upstream Contact: None

Licenses: None

Comments

No comments

Upload #2

Information

Version:	0.9.5
Uploaded:	2023-08-23 19:37
Source package:	melonds_0.9.5.dsc
Distribution:	UNRELEASED
Section:	games
Priority:	optional
Closes bugs:	#1050348

Changelog

 melonds (0.9.5) UNRELEASED; urgency=medium
 .
   * Initial release. (Closes: #1050348)

QA information

–
Package uploaded for the UNRELEASED distribution
–
Package uses debhelper-compat

Debhelper compatibility level 13
–
Watch file is not present
–
Package is native

Format: 3.0 (native)
–
"Maintainer" email is the same as the uploader
–
Package has lintian errors
melonds
- E package-section-games-but-contains-no-game
- W no-manual-page
  - [usr/bin/melonDS]
- I extended-description-is-probably-too-short
- I hardening-no-bindnow
  - [usr/bin/melonDS]
- I spelling-error-in-binary
  - Faild Failed [usr/bin/melonDS]
  - occured occurred [usr/bin/melonDS]
  - succeded succeeded [usr/bin/melonDS]
melonds source
- W newer-standards-version
  - 4.6.2 (current is 4.6.1.0)
- W syntax-error-in-dep5-copyright
  - Continuation line not in paragraph (line 12). Missing a dot on the previous line? [debian/copyright]
- I unreleased-changelog-distribution
  - [debian/changelog:1]
- P silent-on-rules-requiring-root
  - [debian/control]
- P very-long-line-length-in-source-file
  - 1488 > 512 [src/frontend/glad/glad_wgl.c:73]
  - 1488 > 512 [src/frontend/glad/glad_wgl.h:73]
  - 1725 > 512 [src/frontend/glad/glad_glx.c:84]
  - 1725 > 512 [src/frontend/glad/glad_glx.h:84]
  - 2464 > 512 [freebios/drastic_bios_arm9.bin:14]
  - 5008 > 512 [res/melon.icns:371]
  - 556 > 512 [src/fatfs/ffunicode.c:15484]
  - 645 > 512 [src/teakra/externals/catch/catch.hpp:909]
  - 647 > 512 [src/teakra/src/dma.md:99]
  - 661 > 512 [src/teakra/src/mmio.md:3]
  - 705 > 512 [src/teakra/src/processor_general.md:5]
  - 728 > 512 [src/fatfs/LICENSE.txt:24]
  - 802 > 512 [src/teakra/README.md:19]
  - 824 > 512 [src/teakra/src/register.md:25]
  - 8303 > 512 [freebios/drastic_bios_arm7.bin:31]
–
Package closes ITP bug
- melonds:
  - #1050348 (Wishlist, ITP): ITP: melonds -- nintendo DS emulator
–
No Homepage field present
–
No VCS field present
–
Package is not in Debian
–
Upstream-Contact missing from d/copyright

Upstream Contact: None

Licenses: GPL-3+

Comments

hi, thanks for start contributing to debian.
I suggest to add a packaging repository, for example on salsa.debian.org, this will make easier/faster review and contribute.
Packaging is not included upstream so format should be quilt and not native, the official source should keep as it is and any changes will be done in debian/patches.
after switch to quilt for check and import new upstream version debian/watch should be added, look for example this where upstream is also in github: https://salsa.debian.org/cinnamon-team/xapp/-/blob/master/debian/watch
For help with manage of packaging in addition to git I think gbp is a good tool:
https://wiki.debian.org/PackagingWithGit
In debian/copyright text of the gpl3 license can be shorter pointing to the full license present in /usr/share/common-licenses/
From a fast look I also see that debian/copyright is incomplete, an accurate check in source included to be done. For example from a fast look in src/ I saw some folders with other projects integrated and there are also different licenses.
As reported by lintian I suggest to add the homepage (of upstream) field to debian/control
are you sure only amd64 is supported? from a fast look to CMakeLists.txt seems support also other architectures
freebios folder contain binaries, if not needed should be excluded with dfsg repack, if required we need to see well how to manage them, perhaps the opinion of someone more expert is better.
At the moment I've just had a quick look and given some informations that I hope will be useful to you.
Sorry for my bad english.

Needs work Fabio Fantoni at Aug. 24, 2023, 9:14 p.m.

Upload #1

Information

Version:	0.9.5
Uploaded:	2023-08-23 19:22
Source package:	melonds_0.9.5.dsc
Distribution:	UNRELEASED
Section:	games
Priority:	optional
Closes bugs:	#1050348

Changelog

 melonds (0.9.5) UNRELEASED; urgency=medium
 .
   * Initial release. (Closes: #1050348)

QA information

–
Package uploaded for the UNRELEASED distribution
–
Package uses debhelper-compat

Debhelper compatibility level 13
–
Watch file is not present
–
Package is native

Format: 3.0 (native)
–
"Maintainer" email is the same as the uploader
–
Package has lintian errors
melonds
- E package-section-games-but-contains-no-game
- W no-manual-page
  - [usr/bin/melonDS]
- I extended-description-is-probably-too-short
- I hardening-no-bindnow
  - [usr/bin/melonDS]
- I spelling-error-in-binary
  - Faild Failed [usr/bin/melonDS]
  - occured occurred [usr/bin/melonDS]
  - succeded succeeded [usr/bin/melonDS]
melonds source
- W newer-standards-version
  - 4.6.2 (current is 4.6.1.0)
- W syntax-error-in-dep5-copyright
  - Continuation line not in paragraph (line 12). Missing a dot on the previous line? [debian/copyright]
- I unreleased-changelog-distribution
  - [debian/changelog:1]
- P silent-on-rules-requiring-root
  - [debian/control]
- P very-long-line-length-in-source-file
  - 1488 > 512 [src/frontend/glad/glad_wgl.c:73]
  - 1488 > 512 [src/frontend/glad/glad_wgl.h:73]
  - 1725 > 512 [src/frontend/glad/glad_glx.c:84]
  - 1725 > 512 [src/frontend/glad/glad_glx.h:84]
  - 2464 > 512 [freebios/drastic_bios_arm9.bin:14]
  - 5008 > 512 [res/melon.icns:371]
  - 556 > 512 [src/fatfs/ffunicode.c:15484]
  - 645 > 512 [src/teakra/externals/catch/catch.hpp:909]
  - 647 > 512 [src/teakra/src/dma.md:99]
  - 661 > 512 [src/teakra/src/mmio.md:3]
  - 705 > 512 [src/teakra/src/processor_general.md:5]
  - 728 > 512 [src/fatfs/LICENSE.txt:24]
  - 802 > 512 [src/teakra/README.md:19]
  - 824 > 512 [src/teakra/src/register.md:25]
  - 8303 > 512 [freebios/drastic_bios_arm7.bin:31]
–
Package closes ITP bug
- melonds:
  - #1050348 (Wishlist, ITP): ITP: melonds -- nintendo DS emulator
–
No Homepage field present
–
No VCS field present
–
Package is not in Debian
–
Upstream-Contact missing from d/copyright

Upstream Contact: None

Licenses: GPL-3+

Comments

No comments