Details about package golang-go.gearno-encoding-base58
Package uploads
Upload #2
Information
Changelog
golang-go.gearno-encoding-base58 (0.1.0-1) unstable; urgency=medium
.
* Initial release (Closes: #1087617)
Comments
No comments
Upload #1
Information
Changelog
golang-go.gearno-encoding-base58 (0.1.0-1) unstable; urgency=medium
.
* Initial release (Closes: #1087617)
Comments
-
Martin,
Preamble...
Thank you for taking the time to prepare this package and your contribution to the Debian project.
The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Issue
Running lintian...
N:
I: golang-go.gearno-encoding-base58-dev: extended-description-is-probably-too-short
N:
N: The extended description (the lines after the first line of the
N: "Description:" field) is only one or two lines long. The extended
N: description should provide a user with enough information to decide
N: whether they want to install this package, what it contains, and how it
N: compares to similar packages. One or two lines is normally not enough to
N: do this.
N:
N: Please refer to General guidelines for package descriptions (Section
N: 6.2.1) in the Debian Developer's Reference and The long description
N: (Section 6.2.3) in the Debian Developer's Reference for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: fields/description
N:
N:
I: golang-go.gearno-encoding-base58 source: out-of-date-standards-version 4.6.2 (released 2022-12-17) (current is 4.7.0)
N:
N: The source package refers to a Standards-Version older than the one that
N: was current at the time the package was created (according to the
N: timestamp of the latest debian/changelog entry). Please consider updating
N: the package to current Policy and setting this control field
N: appropriately.
N:
N: If the package is already compliant with the current standards, you don't
N: have to re-upload the package just to adjust the Standards-Version control
N: field. However, please remember to update this field next time you upload
N: the package.
N:
N: See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
N: debian-policy package for a summary of changes in newer versions of
N: Policy.
N:
N: Please refer to
N: https://www.debian.org/doc/debian-policy/upgrading-checklist.html for
N: details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: fields/standards-version
N:
N:
P: golang-go.gearno-encoding-base58 source: trailing-whitespace [debian/control:21]
N:
N: This file contains lines with trailing whitespace characters.
N:
N: Whilst often harmless and unsightly, such extra whitespaces can also cause
N: tools to interpret the whitespace characters literally. The tool diff(1)
N: does not like them, either. They are best avoided.
N:
N: Some of these problems can be hard to track down.
N:
N: Whitespace at the end of lines may be removed with the following:
N:
N: $ sed -i -e 's@[[:space:]]*$@@g' debian/control debian/changelog
N:
N: If you use Emacs, you can also use "M-x wh-cl" (whitespace-cleanup).
N:
N: However, if you wish to only remove trailing spaces and leave trailing
N: tabs (eg. for Makefiles), you can use the following code snippet:
N:
N: $ sed -i -e 's@[ ]*$@@g' debian/rules
N:
N: To remove empty lines from the end of a file, you can use:
N:
N: $ sed -i -e :a -e '/^\n*$/{$d;N;};/\n$/ba' debian/rules
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/trailing-whitespace
N: Renamed from: file-contains-trailing-whitespace
N:
I: Lintian run was successful.
3. Licenses [4]: Good
4. Watch file [uscan --force-download]: Good
5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Good
8. Upgrade [Over previous installs if any]: N/A
Summary...
Martin, Package is in good shape, with a couple of fixes needed.
Lintian issues need to be resolved.
Regards
Phil
[1] pbuilder:
* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
Needs work
Phil Wyett at Nov. 22, 2024, 8:11 p.m.
-
Dear Phil,
thank you very much for this detailed review. The standards version was already increased, but I forgot to upload the changed package to mentors. I now fixed the other issues you discovered and made a new upload which should appear soon.
Best regards,
Martin
Martin Dosch at Nov. 22, 2024, 9:01 p.m.
