Details about package golang-github-tomasen-fcgi-client
Package uploads
Upload #3
Information
Changelog
golang-github-tomasen-fcgi-client (0.0~git20180423.2bb3d81-1) unstable; urgency=medium
.
* Initial release (Closes: #1077533)
Comments
-
Nicolas,
Preamble...
Thank you for taking the time to prepare this package and your contribution to the Debian project.
The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Good
3. Licenses [4]: Good
4. Watch file [uscan --force-download]: Good
5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Good
8. Upgrade [Over previous installs if any]: N/A
Summary...
I believe golang-github-tomasen-fcgi-client is ready for review/possible sponsorship.
If you do not have a go team or other regular sponsor, you may wish to change 'Needs a sponsor' to yes and file an RFS bug[6]. A review can be done on the RFS bug and then marked as ready ("confirmed") so that it shows DDs it is ready for final review and possible upload into Debian.
Regards
Phil
[1] pbuilder:
* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
[6] https://mentors.debian.net/sponsors/rfs-howto/
Ready
Phil Wyett at Oct. 3, 2024, 3:03 p.m.
-
Most of the checklist above about Lintian, reproducible builds etc could be automatically validated by Salsa CI. However the current CI in https://salsa.debian.org/go-team/packages/prometheus-phpfpm-exporter/-/blob/debian/sid/debian/gitlab-ci.yml only runs Golang tests. Would it make sense to expand it to also include the Salsa CI tests?
Needs work
Otto Kekäläinen at Oct. 10, 2024, 3:32 a.m.
-
Correct link: https://salsa.debian.org/go-team/packages/golang-github-tomasen-fcgi-client/-/blob/debian/sid/debian/gitlab-ci.yml
Needs work
Otto Kekäläinen at Oct. 10, 2024, 3:32 a.m.
-
Clean test build at https://launchpadlibrarian.net/755571510/buildlog_ubuntu-oracular-amd64.golang-github-tomasen-fcgi-client_0.0~git20180423.2bb3d81-1~bpo24.10.1~1729697956.2d637d7+debian.sid_BUILDING.txt.gz passed.
I am running Salsa CI for additional testing: https://salsa.debian.org/otto/golang-github-tomasen-fcgi-client/-/pipelines/751593
Needs work
Otto Kekäläinen at Oct. 23, 2024, 3:49 p.m.
-
Review of commits at https://salsa.debian.org/go-team/packages/golang-github-tomasen-fcgi-client/-/commits/debian/sid
18dc6618
- Remove this, we are not allowed to modify upstream sources. Only make modifications in debian /*
6c50c1b1
- This isn't actually the initial packaging, as you modify this in later commits
- debian/gbp.conf: What is 'dist = DEP14', where in gbp man pages does it say it supports this? I think it can be omitted or keep default value 'dist = debian'. If you want to follow DEP-14, use 'debian/latest' as branch name.
f04ed49f
- You can prepend lines with a hash (#) and have comments why certains things are overridden.
- Did you talk to upstream about doing actual tagged releases? You could file a request at https://github.com/tomasen/fcgi_client/issues along with motivations on why it is useful
All other commits where amending 6c50c1b1 but exposed to reviewers instead of rebased locally.
Overall this is pretty good and close to upload quality.
Needs work
Otto Kekäläinen at Oct. 23, 2024, 3:58 p.m.
Upload #2
Information
Changelog
golang-github-tomasen-fcgi-client (0.0~git20180423.2bb3d81-2) unstable; urgency=medium
.
* Remove unneeded lintian override for source package
* Better short and long description
* Update Standards version to 4.7.0, no changes needed
Comments
No comments
Upload #1
Information
Changelog
golang-github-tomasen-fcgi-client (0.0~git20180423.2bb3d81-1) unstable; urgency=medium
.
* Initial release (Closes: #1077533)
Comments
-
Hi,
You have not indicated that you wish a review and sponsorship by toggling "Needs a sponsor" on this page and creating and RFS bug[1].
If you have your own sponsor, you need do nothing. If not please do the above and your package will be looked at in a more timely manner.
[1] https://mentors.debian.net/sponsors/rfs-howto/
Regards
Phil
Phil Wyett at Aug. 3, 2024, 7:40 a.m.
-
Nicolas,
Preamble...
Thank you for taking the time to prepare this package and your contribution to the Debian project.
The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Issue
I: golang-github-tomasen-fcgi-client-dev: extended-description-is-probably-too-short
N:
N: The extended description (the lines after the first line of the
N: "Description:" field) is only one or two lines long. The extended
N: description should provide a user with enough information to decide
N: whether they want to install this package, what it contains, and how it
N: compares to similar packages. One or two lines is normally not enough to
N: do this.
N:
N: Please refer to General guidelines for package descriptions (Section
N: 6.2.1) in the Debian Developer's Reference and The long description
N: (Section 6.2.3) in the Debian Developer's Reference for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: fields/description
I: golang-github-tomasen-fcgi-client source: out-of-date-standards-version 4.6.2 (released 2022-12-17) (current is 4.7.0)
N:
N: The source package refers to a Standards-Version older than the one that
N: was current at the time the package was created (according to the
N: timestamp of the latest debian/changelog entry). Please consider updating
N: the package to current Policy and setting this control field
N: appropriately.
N:
N: If the package is already compliant with the current standards, you don't
N: have to re-upload the package just to adjust the Standards-Version control
N: field. However, please remember to update this field next time you upload
N: the package.
N:
N: See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
N: debian-policy package for a summary of changes in newer versions of
N: Policy.
N:
N: Please refer to
N: https://www.debian.org/doc/debian-policy/upgrading-checklist.html for
N: details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: fields/standards-version
I: golang-github-tomasen-fcgi-client source: unused-override package-has-long-file-name [debian/source/lintian-overrides:1]
N:
N: Your package specifies the named override but there were no tags that
N: could have been silenced by it.
N:
N: Maybe you fixed an underlying condition but forgot to remove the override.
N: It is also possible that the Lintian maintainers fixed a false positive.
N:
N: If the override is now unused, please remove it.
N:
N: This tag is similar to mismatched-override except there a tag could have
N: been silenced if the context had matched.
N:
N: Sometimes, overrides end up not being used because a tag appears only on
N: some architectures. In that case, overrides can be equipped with an
N: architecture qualifier.
N:
N: Please refer to Architecture specific overrides (Section 2.4.3) in the
N: Lintian User's Manual for details.
N:
N: Visibility: info
N: Show-Always: yes
N: Check: lintian
N:
N: 0 hints overridden; 1 unused override
3. Licenses [4]: Good
4. Watch file [uscan --force-download]: Good
5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Good
8. Upgrade [Over previous installs if any]: N/A
Additional...
A. 'Standards-Version' in 'debian/control' needs to be updated to the latest version 4.7.0 as per Debian policy[6].
Summary...
I believe golang-github-tomasen-fcgi-client is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the raised issues and perform a new upload.
Regards
Phil
[1] pbuilder:
* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc -t
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
[6] https://www.debian.org/doc/debian-policy/
Needs work
Phil Wyett at Aug. 23, 2024, 3:33 p.m.
