Sign me up Login

Details about package golang-github-erroneousboat-termui

Name: golang-github-erroneousboat-termui
Uploader: Takuma Shibuya <shibuuuu5@gmail.com> (Debian QA page)
Description: golang-github-erroneousboat-termui-dev - Golang terminal dashboard

Package uploads

Upload #4

Information

Version: 2.2.0-1~3.gbp38852c
Uploaded: 2021-11-07 14:44
Source package: golang-github-erroneousboat-termui_2.2.0-1~3.gbp38852c.dsc
Distribution: unstable
Section: golang
Priority: optional
Homepage: https://github.com/erroneousboat/termui
Vcs-Browser: https://salsa.debian.org/go-team/packages/golang-github-erroneousboat-termui
Vcs-Git: https://salsa.debian.org/go-team/packages/golang-github-erroneousboat-termui.git
Closes bugs: #994282

Changelog

 golang-github-erroneousboat-termui (2.2.0-1~3.gbp38852c) unstable; urgency=medium
 .
   ** SNAPSHOT build @38852c3dfc9a04a4565edd4a0a41457ae553d069 **
 .
   * Initial release (Closes: #994282)
   * add patch: add go.mod
   * add patch: replace to use fmt package
   * Rediff patches

QA information

Comments

  1. Nack. mainly package version and appropriate explanation about patches.
    
    * It seems that you did packaging based on 2.2.0 upstream tar.gz, right?
    Then it should be 2.2.0-1, not 2.2.0-1~3.gbp38852c.
    * debian/patches/0001-add-patch-add-go.mod.patch
      * Could you forward it to upstream?
      * Then could you follow DEP-3 https://dep-team.pages.debian.net/deps/dep3/
    * debian/patches/0002-add-patch-replace-to-use-fmt-package.patch
      * Missing the reason why it must be replaced. (Meaningful commit message is helpful)
      * Then could you follow DEP-3 https://dep-team.pages.debian.net/deps/dep3/
    * debian/patches/0003-add-patch-add-module.patch
      * Not sure why this commit is extracted as a patch (It seems squashing 0001 or 0004 may be better about go.mod changes)
    * debian/patches/0004-add-patch-update-render-method-in-render.go.patch 
      * Missing the reason why it must be updated. (Meaningful commit message is helpful)
      * Could you follow DEP-3 https://dep-team.pages.debian.net/deps/dep3/
    Needs work Kentaro Hayashi at Nov. 10, 2021, 12:04 p.m.

Upload #3

Information

Version: 2.2.0-1
Uploaded: 2021-11-07 12:59
Source package: golang-github-erroneousboat-termui_2.2.0-1.dsc
Distribution: unstable
Section: golang
Priority: optional
Homepage: https://github.com/erroneousboat/termui
Vcs-Browser: https://salsa.debian.org/go-team/packages/golang-github-erroneousboat-termui
Vcs-Git: https://salsa.debian.org/go-team/packages/golang-github-erroneousboat-termui.git
Closes bugs: #994282

Changelog

 golang-github-erroneousboat-termui (2.2.0-1) unstable; urgency=medium
 .
   * Initial release (Closes: #994282)

QA information

Comments

No comments

Upload #2

Information

Version: 2.2.0-1
Uploaded: 2021-10-07 14:50
Source package: golang-github-erroneousboat-termui_2.2.0-1.dsc
Distribution: unstable
Section: golang
Priority: optional
Homepage: https://github.com/erroneousboat/termui
Vcs-Browser: https://salsa.debian.org/go-team/packages/golang-github-erroneousboat-termui
Vcs-Git: https://salsa.debian.org/go-team/packages/golang-github-erroneousboat-termui.git
Closes bugs: #994282

Changelog

 golang-github-erroneousboat-termui (2.2.0-1) unstable; urgency=medium
 .
   * Initial release (Closes: #994282)

QA information

Comments

  1. Nack: debian/patches/0001-add-patch.patch 
    
    Reason 1: Please consider a more meaningful patch file name.
    Reason 2: It should be split into the proper categories.
      missing go.mod, use fmt. and so on.
      And more, follow the DEP-3 headers. See lintian message in details.
    Needs work Kentaro Hayashi at Oct. 11, 2021, 12:35 p.m.

Upload #1

Information

Version: 2.2.0-1
Uploaded: 2021-10-07 14:20
Source package: golang-github-erroneousboat-termui_2.2.0-1.dsc
Distribution: unstable
Section: golang
Priority: optional
Homepage: https://github.com/erroneousboat/termui
Vcs-Browser: https://salsa.debian.org/go-team/packages/golang-github-erroneousboat-termui
Vcs-Git: https://salsa.debian.org/go-team/packages/golang-github-erroneousboat-termui.git
Closes bugs: #994282

Changelog

 golang-github-erroneousboat-termui (2.2.0-1) unstable; urgency=medium
 .
   * Initial release (Closes: #994282)

QA information

Comments

No comments