Sign me up Login

Details about package fibocom-pc-services

Name:	fibocom-pc-services
Uploader:	Kai-Chuan Hsieh <kaichuan.hsieh@canonical.com> (Debian QA page)
Description:	fibocom-helper-service - DBus API provider for Flash/Ma/Config service fibocom-config-service - OEM configuration functions for Fibocom modem fibocom-ma-service - Provide fccunlock function for Fibocom modem fibocom-flash-service - Provide firmware flash function for Fibocom modem

Package uploads

Upload #3

Information

Version:	1.0.10-1
Uploaded:	2024-07-03 01:39
Source package:	fibocom-pc-services_1.0.10-1.dsc
Distribution:	unstable
Section:	non-free/net
Priority:	optional
Homepage:	https://github.com/fibocom-pc/linux_apps_opensource
Vcs-Browser:	https://salsa.debian.org/kchsieh/fibocom-pc-services
Vcs-Git:	https://salsa.debian.org/kchsieh/fibocom-pc-services.git
Closes bugs:	#1074405

Changelog

 fibocom-pc-services (1.0.10-1) unstable; urgency=medium
 .
   * Initial release (closes: #1074405)

QA information

–
Package uses debhelper-compat

Debhelper compatibility level 13

–

Package is the latest upstream version

Local:	1.0.10
Upstream:	1.0.10
Url:	https://github.com/fibocom-pc/linux_apps_opensource.git refs/tags/v1.0.10

–
Package is not native

Format: 3.0 (quilt)
–
The uploader is in the package's "Uploaders" field
–
Package has lintian warnings
fibocom-pc-services source
- W newer-standards-version
  - 4.7.0 (current is 4.6.2)
- X debian-watch-does-not-check-openpgp-signature
  - [debian/watch]
- X very-long-line-length-in-source-file
  - 13601 > 512 [application/fibo_ma_service/fibo_ma:195]
- O source-contains-prebuilt-binary
  - [application/fibo_ma_service/fibo_ma]
- O source-contains-prebuilt-doxygen-documentation
  - [application/3rd/iniparser/html/]
- O source-is-missing
  - [application/fibo_ma_service/fibo_ma]
–
Package closes ITP bug
- fibocom-pc-services:
  - #1074405 (Wishlist, ITP): ITP: fibocom-pc-services -- Services to support WWAN modules manufactured by Fibocom Wireless Inc.
–
Package is not in Debian
–
d/copyright is in DEP5 format

Upstream Contact: Felix Yan <felix.yan@fibocom.com>

Licenses: MIT, GPL-2+

Comments

Hi,

Preamble...

Thank you for taking time to create this package and your contribution to Debian.

The below review is for assistance. It is offered to help submitters of
packages to Debian mentors improve their packages prior to possible
sponsorship into Debian. There is no obligation on behalf of the submitter to
make any alterations based upon information provided in the review.

Review...

1. Build: Good

2. Lintian: Issues

W: fibocom-ma-service-dbgsym: debug-file-with-no-debug-symbols [usr/lib/debug/.build-id/31/c688714629cba39332ccc6c74073bf344b389e.debug]
N: 
N:   The binary is installed as a detached "debug symbols" ELF file, but it
N:   does not appear to have debug information associated with it.
N:   
N:   A common cause is not passing -g to GCC when compiling.
N:   
N:   Implementation detail: Lintian checks for the ".debug_line" and the
N:   ".debug_str" sections. If either of these are present, the binary is
N:   assumed to contain debug information.
N: 
N:   Please refer to Bug#668437 for details.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: binaries/debug-symbols/detached

W: fibocom-pc-services source: newer-standards-version 4.7.0 (current is 4.6.2)
N: 
N:   The source package refers to a Standards-Version which is newer than the
N:   highest one Lintian is programmed to check.
N:   
N:   If the source package is correct, please upgrade Lintian to the newest
N:   version.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: fields/standards-version

I: fibocom-ma-service: unused-override very-long-line-length-in-source-file  [usr/share/lintian/overrides/fibocom-ma-service:2]
N: 
N:   Your package specifies the named override but there were no tags that
N:   could have been silenced by it.
N:   
N:   Maybe you fixed an underlying condition but forgot to remove the override.
N:   It is also possible that the Lintian maintainers fixed a false positive.
N:   
N:   If the override is now unused, please remove it.
N:   
N:   This tag is similar to mismatched-override except there a tag could have
N:   been silenced if the context had matched.
N:   
N:   Sometimes, overrides end up not being used because a tag appears only on
N:   some architectures. In that case, overrides can be equipped with an
N:   architecture qualifier.
N: 
N:   Please refer to Architecture specific overrides (Section 2.4.3) in the
N:   Lintian User's Manual for details.
N: 
N:   Visibility: info
N:   Show-Always: yes
N:   Check: lintian

3. Licenses (lrc): Issues

philwyett@ks-windu:~/Development/builder/debian/mentoring/fibocom-pc-services-1.0.10$ lrc
en: Versions: recon 1.11  check 3.3.9-1

Parsing Source Tree  ....
Reading copyright    ....
Running licensecheck ....

d/copyright     | licensecheck

GPL-2+          | Zlib             application/3rd/iniparser/test/CuTest_license.txt
GPL-2+          | BSD-3-clause     application/3rd/qdl/firehose.c
GPL-2+          | BSD-3-clause     application/3rd/qdl/patch.c
GPL-2+          | BSD-3-clause     application/3rd/qdl/program.c
GPL-2+          | BSD-3-clause     application/3rd/qdl/qdl.c
GPL-2+          | BSD-3-clause     application/3rd/qdl/sahara.c
GPL-2+          | BSD-3-clause     application/3rd/qdl/ufs.c
GPL-2+          | BSD-3-clause     application/3rd/qdl/ufs.h
GPL-2+          | BSD-3-clause     application/3rd/qdl/util.c
GPL-2+          | Expat            application/3rd/safestringlib/CMakeLists.txt
GPL-2+          | Expat            application/3rd/safestringlib/include/safe_lib_errno.h
GPL-2+          | Expat            application/3rd/safestringlib/include/safe_lib_errno.h.in
GPL-2+          | Expat            application/3rd/safestringlib/include/safe_lib.h
GPL-2+          | Expat            application/3rd/safestringlib/include/safe_mem_lib.h
GPL-2+          | Expat            application/3rd/safestringlib/include/safe_str_lib.h
GPL-2+          | Expat            application/3rd/safestringlib/include/safe_types.h
GPL-2+          | Expat            application/3rd/safestringlib/include/safe_types.h.in
GPL-2+          | Expat            application/3rd/safestringlib/include/snprintf_s.h
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/abort_handler_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/ignore_handler_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/memcmp16_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/memcmp32_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/memcmp_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/memcpy16_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/memcpy32_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/memcpy_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/memmove16_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/memmove32_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/memmove_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/mem_primitives_lib.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/mem_primitives_lib.h
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/memset16_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/memset32_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/memset_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/memzero16_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/memzero32_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/memzero_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/safeclib_private.h
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/safe_mem_constraint.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/safe_mem_constraint.h
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/safe_str_constraint.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/safe_str_constraint.h
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/snprintf_support.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/stpcpy_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/stpncpy_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strcasecmp_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strcasestr_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strcat_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strcmpfld_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strcmp_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strcpyfldin_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strcpyfldout_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strcpyfld_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strcpy_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strcspn_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strfirstchar_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strfirstdiff_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strfirstsame_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strisalphanumeric_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strisascii_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strisdigit_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strishex_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strislowercase_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strismixedcase_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strispassword_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strisuppercase_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strlastchar_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strlastdiff_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strlastsame_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strljustify_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strncat_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strncpy_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strnlen_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strnterminate_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strpbrk_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strprefix_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strremovews_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strspn_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strstr_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strtok_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strtolowercase_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strtouppercase_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/strzero_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/wcpcpy_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/wcscat_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/wcscpy_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/wcsncat_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/wcsncpy_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/wcsnlen_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/wmemcmp_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/wmemcpy_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/wmemmove_s.c
GPL-2+          | Expat            application/3rd/safestringlib/safeclib/wmemset_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/CMakeLists.txt
GPL-2+          | Expat            application/3rd/safestringlib/unittests/Safe_String_UnitTestMain.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_memcmp16_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_memcmp32_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_memcmp_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_memcpy16_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_memcpy32_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_memcpy_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_memmove16_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_memmove32_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_memmove_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_memset16_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_memset32_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_memset_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_memzero16_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_memzero32_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_memzero_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_private.h
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_stpcpy_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_stpncpy_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strcasecmp_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strcasestr_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strcat_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strcmpfld_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strcmp_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strcpyfldin_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strcpyfldout_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strcpyfld_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strcpy_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strcspn_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strfirstchar_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strfirstdiff_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strfirstsame_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strisalphanumeric_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strisascii_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strisdigit_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strishex_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strislowercase_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strismixed_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strispassword_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strisuppercase_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strlastchar_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strlastdiff_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strlastsame_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strljustify_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strncat_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strncpy_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strnlen_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strnterminate_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strpbrk_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strprefix_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strremovews_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strspn_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strstr_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strtok_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strtolowercase_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strtouppercase_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_strzero_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_wcpcpy_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_wcscat_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_wcscpy_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_wcsncat_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_wcsncpy_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_wcsnlen_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_wmemcmp_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_wmemcpy_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_wmemmove_s.c
GPL-2+          | Expat            application/3rd/safestringlib/unittests/test_wmemset_s.c
GPL-2+          | Expat            application/3rd/safestringlib/version.cmake
GPL-2+          | GPL-2            application/fibo_config_service/include/fibo_config_helper.h
GPL-2+          | GPL-2            application/fibo_config_service/include/fibo_config_parse.h
GPL-2+          | GPL-2            application/fibo_config_service/include/fibo_dynamic_config.h
GPL-2+          | GPL-2            application/fibo_config_service/include/fibo_parse_xml.h
GPL-2+          | GPL-2            application/fibo_config_service/include/fibo_static_config.h
GPL-2+          | GPL-2            application/fibo_config_service/src/fibo_config_helper.c
GPL-2+          | GPL-2            application/fibo_config_service/src/fibo_config_main.c
GPL-2+          | GPL-2            application/fibo_config_service/src/fibo_config_parse.c
GPL-2+          | GPL-2            application/fibo_config_service/src/fibo_dynamic_config.c
GPL-2+          | GPL-2            application/fibo_config_service/src/fibo_static_config.c
GPL-2+          | GPL-2            application/fibo_config_service/src/fibo_xml_parse.c
GPL-2+          | GPL-2            application/fibo_flash_service/fibo_flash_main.c
GPL-2+          | GPL-2            application/fibo_flash_service/fibo_flash_main.h
GPL-2+          | GPL-2            application/fibo_flash_service/fibo_flash_parse_xml.c
GPL-2+          | GPL-2            application/fibo_helper_service/at_channel/common.cc
GPL-2+          | GPL-2            application/fibo_helper_service/at_channel/common.h
GPL-2+          | GPL-2            application/fibo_helper_service/at_channel/serial_port.cc
GPL-2+          | GPL-2            application/fibo_helper_service/at_channel/serial_port.h
GPL-2+          | GPL-2            application/fibo_helper_service/fibo_helper_adapter.c
GPL-2+          | GPL-2            application/fibo_helper_service/fibo_helper_adapter.h
GPL-2+          | GPL-2            application/fibo_helper_service/fibo_helper_basic_func.c
GPL-2+          | GPL-2            application/fibo_helper_service/fibo_helper_basic_func.h
GPL-2+          | GPL-2            application/fibo_helper_service/fibo_helper_common.h
GPL-2+          | GPL-2            application/fibo_helper_service/fibo_helper_log.c
GPL-2+          | GPL-2            application/fibo_helper_service/fibo_helper_main.c
GPL-2+          | GPL-2            application/fibo_helper_service/fibo_helper_mbim_main.c
GPL-2+          | GPL-2            application/include/common/fibo_helper_cid.h
GPL-2+          | GPL-2            application/include/common/fibo_log.h
GPL-2+          | GPL-2            application/include/common/fibo_private_log.h
GPL-2+          | CC0-1.0          install

4. Watch file (uscan --force-download): Good

5. Build Twice (sudo pbuilder build --twice <package>.dsc): Good

6. Reproducible builds (reporotest)[1]: Good

7. Install (No previous installs): Good

8. Upgrade (Over previous installs if any): N/A

Summary...

I believe 'fibocom-pc-services' is not yet ready for sponsorship/upload. Could the contributor rectify one of more of the rasied issues.

[1] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

Regards

Phil

Needs work Phil Wyett at July 9, 2024, 9:27 p.m.

Hi,

You have not indicated that you wish a review and sponsorship by toggling "Needs a sponsor" on this page and creating and RFS bug[1].

If you have your own sponsor, you need do nothing. If not please do the above and your package will be looked at in a more timely manner.

[1] https://mentors.debian.net/sponsors/rfs-howto/

Regards

Phil

Phil Wyett at July 31, 2024, 5:53 p.m.

Upload #2

Information

Version:	1.0.10-1
Uploaded:	2024-06-28 08:09
Source package:	fibocom-pc-services_1.0.10-1.dsc
Distribution:	unstable
Section:	non-free/net
Priority:	optional
Homepage:	https://github.com/fibocom-pc/linux_apps_opensource
Vcs-Browser:	https://salsa.debian.org/kchsieh/fibocom-pc-services
Vcs-Git:	https://salsa.debian.org/kchsieh/fibocom-pc-services.git
Closes bugs:	#1074405

Changelog

 fibocom-pc-services (1.0.10-1) unstable; urgency=medium
 .
   * Initial release (closes: Bug#1074405)

QA information

–
Package uses debhelper-compat

Debhelper compatibility level 13
–
A watch file is present but doesn't work
–
Package is not native

Format: 3.0 (quilt)
–
The uploader is in the package's "Uploaders" field
–
Package has lintian errors
fibocom-pc-services source
- E source-only-upload-to-non-free-without-autobuild
  - (in the source paragraph) XS-Autobuild [debian/control]
- W newer-standards-version
  - 4.7.0 (current is 4.6.2)
- I missing-explanation-for-contrib-or-non-free-package
  - [debian/copyright:1]
- X debian-watch-does-not-check-openpgp-signature
  - [debian/watch]
- X update-debian-copyright
  - 2023 vs 2024 [debian/copyright:27]
- X upstream-metadata-file-is-missing
- X very-long-line-length-in-source-file
  - 13601 > 512 [application/fibo_ma_service/fibo_ma:195]
- O source-contains-prebuilt-binary
  - [application/fibo_ma_service/fibo_ma]
- O source-contains-prebuilt-doxygen-documentation
  - [application/3rd/iniparser/html/]
- O source-is-missing
  - [application/fibo_ma_service/fibo_ma]
–
Package closes ITP bug
- fibocom-pc-services:
  - #1074405 (Wishlist, ITP): ITP: fibocom-pc-services -- Services to support WWAN modules manufactured by Fibocom Wireless Inc.
–
Package is not in Debian
–
d/copyright is in DEP5 format

Upstream Contact: Felix Yan <felix.yan@fibocom.com>

Licenses: MIT, GPL-2+

Comments

i lost you on IRC,

but changelog should be just   * Initial release (Closes: #1074405)


i see you want to put it in non-free, what is the reason for it?

binaries not allowed! debuild fails:

dh binary
 dpkg-genbuildinfo -O../fibocom-pc-services_1.0.10-1_arm64.buildinfo
dpkg-genbuildinfo: error: binary build with no binary artifacts found; .buildinfo is meaningless
dpkg-buildpackage: error: dpkg-genbuildinfo -O../fibocom-pc-services_1.0.10-1_arm64.buildinfo subprocess returned exit status 25
debuild: fatal error at line 1184:
dpkg-buildpackage -us -uc -ui failed

Needs work Alex Myczko at June 28, 2024, 12:57 p.m.

also:

E: fibocom-pc-services source: source-only-upload-to-non-free-without-autobuild (in the source paragraph) XS-Autobuild [debian/control]

the source tarball must have no binaries that can be built from source. if there are binaries, remove them. if there is no source for it, you can't build them.

non-free means you are not free to distribute the software, not that you can add binaries built somewhere by someone.

Needs work Alex Myczko at June 28, 2024, 12:59 p.m.

Hello,

Thanks for reviewing it.

The reason I put it to non-free is because it contains a prebuilt amd64 ELF file in application/fibo_ma_service/fibo_ma. it can't be open source, because it contains OEM specified keys for doing FCC unlock, and Fibocom re-lincense MIT for it specifically. Also, I set architecture to amd64 only because of it. This is the upstream contraint that I can't mitigate. May I have your suggestions how can I proceed, because the OEM customer really want it to be in Ubuntu ecosystem without any dirty hacking.

Thanks

Needs work Kai-Chuan Hsieh at June 29, 2024, 12:53 a.m.

Upload #1

Information

Version:	1.0.10-1
Uploaded:	2024-06-28 06:39
Source package:	fibocom-pc-services_1.0.10-1.dsc
Distribution:	unstable
Section:	non-free/net
Priority:	optional
Homepage:	https://github.com/fibocom-pc/linux_apps_opensource
Vcs-Browser:	https://github.com/fibocom-pc/linux_apps_opensource
Vcs-Git:	https://github.com/fibocom-pc/linux_apps_opensource.git
Closes bugs:	#1074405

Changelog

 fibocom-pc-services (1.0.10-1) unstable; urgency=medium
 .
   * Initial release (closes: Bug#1074405)

QA information

–
Package uses debhelper-compat

Debhelper compatibility level 13
–
A watch file is present but doesn't work
–
Package is not native

Format: 3.0 (quilt)
–
The uploader is in the package's "Uploaders" field
–
Package has lintian errors
fibocom-pc-services source
- E source-only-upload-to-non-free-without-autobuild
  - (in the source paragraph) XS-Autobuild [debian/control]
- W newer-standards-version
  - 4.7.0 (current is 4.6.2)
- I missing-explanation-for-contrib-or-non-free-package
  - [debian/copyright:1]
- X debian-watch-does-not-check-openpgp-signature
  - [debian/watch]
- X update-debian-copyright
  - 2023 vs 2024 [debian/copyright:27]
- X upstream-metadata-file-is-missing
- X very-long-line-length-in-source-file
  - 13601 > 512 [application/fibo_ma_service/fibo_ma:195]
- O source-contains-prebuilt-binary
  - [application/fibo_ma_service/fibo_ma]
- O source-contains-prebuilt-doxygen-documentation
  - [application/3rd/iniparser/html/]
- O source-is-missing
  - [application/fibo_ma_service/fibo_ma]
–
Package closes ITP bug
- fibocom-pc-services:
  - #1074405 (Wishlist, ITP): ITP: fibocom-pc-services -- Services to support WWAN modules manufactured by Fibocom Wireless Inc.
–
Package is not in Debian
–
d/copyright is in DEP5 format

Upstream Contact: Felix Yan <felix.yan@fibocom.com>

Licenses: MIT, GPL-2+

Comments

No comments

Upstream Contact:	Felix Yan <felix.yan@fibocom.com>
Licenses:	MIT, GPL-2+