Sign me up Login

Details about package "cxlflash"

Name: cxlflash
Uploader: Rodrigo R. Galvao <rosattig@br.ibm.com> (Debian QA page)
Description: cxlflash - IBM Capiflash IO Data Engine

Package versions

Version 4.3.2580-1

Information

Version: 4.3.2580-1
Uploaded: 2017-10-19 17:33
Source package: https://mentors.debian.net/debian/pool/main/c/cxlflash/cxlflash_4.3.2580-1.dsc
Section: utils
Priority: optional
Closes bugs: 870487

QA information

Comments

No comments

Version 4.3.2560-1

Information

Version: 4.3.2560-1
Uploaded: 2017-09-21 12:12
Source package: https://mentors.debian.net/debian/pool/main/c/cxlflash/cxlflash_4.3.2560-1.dsc
Section: utils
Priority: optional
Closes bugs: 870487

QA information

Comments

No comments

Version 4.3.2557-1

Information

Version: 4.3.2557-1
Uploaded: 2017-09-20 16:23
Source package: https://mentors.debian.net/debian/pool/main/c/cxlflash/cxlflash_4.3.2557-1.dsc
Section: utils
Priority: optional
Closes bugs: 870487

QA information

Comments

No comments

Version 4.3.2554-1

Information

Version: 4.3.2554-1
Uploaded: 2017-09-18 18:55
Source package: https://mentors.debian.net/debian/pool/main/c/cxlflash/cxlflash_4.3.2554-1.dsc
Section: utils
Priority: optional
Closes bugs: 870487

QA information

Comments

No comments

Version 4.3.2551-1

Information

Version: 4.3.2551-1
Uploaded: 2017-09-11 19:57
Source package: https://mentors.debian.net/debian/pool/main/c/cxlflash/cxlflash_4.3.2551-1.dsc
Section: utils
Priority: optional
Closes bugs: 870487

QA information

Comments

  1. The description given for this package is:
    
    Description: IBM Data Engine for NoSQL Software Libraries : cxlflash
     Power Systems Edition creates a new tier of memory by attaching up to 57
     Terabytes of auxiliary flash memory to the processor without the latency
     issues of traditional I/O storage.
     While not as fast as DRAM, the latency is within the acceptable limit of
     most applications especially when data is accessed over the network.
     Flash is also dramatically less expensive than DRAM, and helps reduce the
     deployment and operational cost for delivering the customer solution.
     Customers, MSPs, and ISPs all benefit from application of this new
     technology in the NoSQL application space.
     Exploiting hardware and software built-in to IBM's flagship POWER8 open
     architecture means that clients no longer much choose between "big" or
     "fast" for their solutions.
    
    From <https://bugs.launchpad.net/ubuntu/+bug/1716924>, I understand that cxlflash does:
    
    The cxlflash driver is responsible for the initialization of the Coherent Accelerator (CXL) Flash Adapter, setting up the special path for user space access, and performing error recovery.
    
    These two descriptions of the technology bear no resemblance to one another.  The second description actually tells me something about what the package does; the first description reads like marketing copy and I do not find that it tells me whether I would want to install this package or why.
    
    Please improve this package description so that it's clear what the package does.  The second description seems like a good starting point for this.
    
    Your debian/control lists a VCS field of:
    
    >  Vcs-Git: https://github.com/open-power/cxlflash.git
    
    This URL does not exist or is not public.  Please only point to a public repository for Vcs-Git.  It's possible this should be https://github.com/open-power/capiflash.git instead.
    
    If this is the same thing as capiflash, <https://github.com/open-power/capiflash/releases> shows only a 4.3.2496 release, not a 4.3.2493 release.  It would be good to have a package version corresponding to an upstream release, so that the integrity can be cross-checked.
    
    > Maintainer: IBM Corp. <mpvageli@us.ibm.com>
    
    The uploaders: field shows that this is the email address of Mike Vageline.  I don't think it makes sense to list 'IBM Corp.' as the maintainer here.  It's fine to list whichever one of you should be considered the primary maintainer of the package in the Maintainer: field, and the other in the uploaders field.
    
    > Build-Depends: debhelper (>=9), doxygen, libudev1, libudev-dev,
    >                gcc-5, g++-5, lsb-release, libcxl1, libcxl-dev, help2man
    
    New packages should not build-depend on gcc-5 / g++-5, which are two upstream releases out of date. This should be fixed to work with current gcc.
    
    I can't find any actual references to gcc-5 in the code anyway, so these build-deps can almost certainly be dropped without incident because the package is already building with the default toolchain.
    
    You also should not be build-depending on libudev1 and libcxl1.  You should only build-depend on the -dev packages.
    
    debian/copyright lists:
    
    Files: *
    Copyright: Copyright IBM Corp. 2014-2017
    
    Files: debian/*
    Copyright: 2017 Mike Vageline <mpvageli@us.ibm.com>
    
    It seems unlikely that the copyright holder for the packaging is an individual employee rather than the corporation.  Please check that this is actually the case.
    
    debian/cxlflash.symbols indicates that you are including shared libraries in this package and exposing them for linking by other packages.  However, your package does not conform to Debian policy for public shared libraries, and if the ABIs of these libraries change, this will force an awkward transition in the archive.  Please fix this either by splitting the libraries into the expected libSONAME, libNAME-dev packages, or by explicitly marking these as NOT for external consumption (which means, not providing a .symbols file).
    
    debian/lintian-overrides:
    
    > # false-positives
    > cxlflash binary: hardening-no-fortify-functions
    > cxlflashimage binary: hardening-no-fortify-functions usr/bin/flashgt_vpd_access
    
    These overrides are unused when building on Ubuntu.  I'm not sure if this is because  of a change in the Ubuntu toolchain that causes -D_FORTIFY_SOURCE=2 to be set by default even when not explicitly declared on the commandline.  However, usr/bin/flashgt_vpd_access definitely uses functions in the printf family, and definitely *should* be using the fortify-source versions of these functions, which means these are not false-positives and should not be overridden.  If lintian gives you this warning, it is a real bug that needs to be fixed - possibly by fixing a missing inclusion of the CPPFLAGS from dpkg-buildflags.
    
    debian/rules and debian/control are inconsistent with regards to their architecture list.  debian/rules references powerpc, debian/control references ppc64; therefore, this package will fail to build on both of these architectures, and will only be buildable on ppc64el.
    
    You are build-depending on the lsb-release package in order to invoke lsb_release -sr in debian/rules, setting an OSRELEASE variable which is then never used.  Please don't do that.
    
    You are calling 'unexport LD_PRELOAD' in debian/rules.  This probably breaks buildability of the package under fakeroot - which means it breaks buildability of the package on autobuilders in both Debian and Ubuntu.
    
    debian/rules:
    
    override_dh_auto_install:
            make install_code
            dh_install -v
    
    You should not call 'dh_install' from the dh_auto_install target; this is a separate stage of the build.
    
    The override_dh_installdeb target is a packaging antipattern.  Please do not bypass this debhelper component.  Instead, please symlink/copy the scripts from src/build/install/resources to the expected locations as debian/cxlflash{,image}.{postinst,prerm}.
    
    The overrides of dh_{auto_test,testroot,gencontrol,shlibdeps} all require explanation or dropping.  (The dh_testroot override is probably fixed by fixing the unexport of LD_PRELOAD, mentioned above.  The gencontrol override should be a complete no-op.  The dh_shlibdeps override may be fixing a real issue, but it's not obvious what that is.)
    
    debian/source/include-binaries includes a list of binaries that do not exist and should *not* be included in the debian diff if they did exist.  These were probably build artifacts that at one time were preventing dpkg-source from working, but that has been corrected and this file should be removed.
    
    Needs work Steve Langasek at 2017-09-14 20:13:22.716713

Version 4.3.2549-1

Information

Version: 4.3.2549-1
Uploaded: 2017-09-11 12:15
Source package: https://mentors.debian.net/debian/pool/main/c/cxlflash/cxlflash_4.3.2549-1.dsc
Section: utils
Priority: optional
Closes bugs: 870487

QA information

Comments

No comments

Version 4.3.2544-1

Information

Version: 4.3.2544-1
Uploaded: 2017-09-07 16:33
Source package: https://mentors.debian.net/debian/pool/main/c/cxlflash/cxlflash_4.3.2544-1.dsc
Section: utils
Priority: optional
Closes bugs: 870487

QA information

Comments

No comments

Version 4.3.2538-1

Information

Version: 4.3.2538-1
Uploaded: 2017-08-31 16:53
Source package: https://mentors.debian.net/debian/pool/non-free/c/cxlflash/cxlflash_4.3.2538-1.dsc
Section: utils
Priority: optional
Closes bugs: 870487

QA information

Comments

No comments

Version 4.3.2538-1

Information

Version: 4.3.2538-1
Uploaded: 2017-08-31 16:35
Source package: https://mentors.debian.net/debian/pool/non-free/c/cxlflash/cxlflash_4.3.2538-1.dsc
Section: utils
Priority: optional
Closes bugs: 870487

QA information

Comments

No comments

Version 4.3.2538-1

Information

Version: 4.3.2538-1
Uploaded: 2017-08-31 16:01
Source package: https://mentors.debian.net/debian/pool/non-free/c/cxlflash/cxlflash_4.3.2538-1.dsc
Section: utils
Priority: optional
Closes bugs: 870487

QA information

Comments

No comments

Version 4.3.2537-1

Information

Version: 4.3.2537-1
Uploaded: 2017-08-31 12:32
Source package: https://mentors.debian.net/debian/pool/non-free/c/cxlflash/cxlflash_4.3.2537-1.dsc
Section: utils
Priority: optional
Closes bugs: 870487

QA information

Comments

No comments

Version 4.3.2533-1

Information

Version: 4.3.2533-1
Uploaded: 2017-08-28 17:22
Source package: https://mentors.debian.net/debian/pool/non-free/c/cxlflash/cxlflash_4.3.2533-1.dsc
Section: utils
Priority: optional
Closes bugs: 870487

QA information

Comments

No comments

Version 4.3.2531-1

Information

Version: 4.3.2531-1
Uploaded: 2017-08-28 13:17
Source package: https://mentors.debian.net/debian/pool/non-free/c/cxlflash/cxlflash_4.3.2531-1.dsc
Section: utils
Priority: optional
Closes bugs: 870487

QA information

Comments

No comments

Version 4.3.2528-1

Information

Version: 4.3.2528-1
Uploaded: 2017-08-24 18:01
Source package: https://mentors.debian.net/debian/pool/non-free/c/cxlflash/cxlflash_4.3.2528-1.dsc
Section: utils
Priority: optional
Closes bugs: 870487

QA information

Comments

No comments

Version 4.3.2524-1

Information

Version: 4.3.2524-1
Uploaded: 2017-08-24 12:39
Source package: https://mentors.debian.net/debian/pool/non-free/c/cxlflash/cxlflash_4.3.2524-1.dsc
Section: utils
Priority: optional
Closes bugs: 870487

QA information

Comments

No comments

Version 4.3.2520-1

Information

Version: 4.3.2520-1
Uploaded: 2017-08-23 17:36
Source package: https://mentors.debian.net/debian/pool/main/c/cxlflash/cxlflash_4.3.2520-1.dsc
Section: utils
Priority: optional
Closes bugs: 870487

QA information

Comments

No comments

Version 4.3.2520-1

Information

Version: 4.3.2520-1
Uploaded: 2017-08-22 12:39
Source package: https://mentors.debian.net/debian/pool/main/c/cxlflash/cxlflash_4.3.2520-1.dsc
Section: utils
Priority: optional
Closes bugs: 870487

QA information

Comments

No comments

Version 4.3.2518-1

Information

Version: 4.3.2518-1
Uploaded: 2017-08-21 16:36
Source package: https://mentors.debian.net/debian/pool/main/c/cxlflash/cxlflash_4.3.2518-1.dsc
Section: utils
Priority: optional
Closes bugs: 870487

QA information

Comments

No comments

Version 4.3.2493-1

Information

Version: 4.3.2493-1
Uploaded: 2017-08-09 15:33
Source package: https://mentors.debian.net/debian/pool/main/c/cxlflash/cxlflash_4.3.2493-1.dsc
Section: utils
Priority: extra
Closes bugs: 870487

QA information

Comments

No comments

Version 4.3.2493-1

Information

Version: 4.3.2493-1
Uploaded: 2017-08-07 17:13
Source package: https://mentors.debian.net/debian/pool/main/c/cxlflash/cxlflash_4.3.2493-1.dsc
Section: utils
Priority: extra
Closes bugs: 870487

QA information

Comments

No comments

Version 4.3.2493-1

Information

Version: 4.3.2493-1
Uploaded: 2017-08-06 10:17
Source package: https://mentors.debian.net/debian/pool/main/c/cxlflash/cxlflash_4.3.2493-1.dsc
Section: utils
Priority: extra
Closes bugs: 870487

QA information

Comments

No comments