Sign me up Login

Details about package acct

Name: acct (PTS)
Uploader: Andrew Bower <andrew@bower.uk> (Debian QA page)
Description: acct - GNU Accounting utilities for process and login accounting

Package uploads

Upload #2

Information

Version: 6.6.4-7
Uploaded: 2025-06-21 09:42
Source package: acct_6.6.4-7.dsc
Distribution: experimental
Section: admin
Priority: optional
Homepage: https://www.gnu.org/software/acct/
Vcs-Git: https://salsa.debian.org/pkg-security-team/acct.git
Vcs-Browser: https://salsa.debian.org/pkg-security-team/acct
Closes bugs: #922533 #1023810

Changelog

 acct (6.6.4-7) experimental; urgency=medium
 .
   * Team upload.
 .
   [ Andrew Bower ]
   * Add autopkgtest for process accounting.
   * Move lock file to /run. (Closes: #1023810)
     - allows autopktest to start service in initless unshare sbuild
   * Do not set DH_VERBOSE in debian/rules.
   * Convert mixed tabs/spaces in scripts to tabs.
   * Use logrotate for daily process accounting log rotation
     - Provide /usr/share/acct/hooks.d (Closes: #922533)
   * Drop obsolete depends on lsb-base
   * Do not remove log files on package purge.
   * d/copyright:
     - swap FSF postal address for URL
     - fix format error
     - add myself
     - expand oversimplifications, including autotools/M4 content
   * d/patches:
     - lift maintainer-supplied man page from replace-all patch
     - fix files listing layout in lastcomm.1
     - re-apply info typo fixes to the texi source
     - drop ineffective html unsplitting doc patch to generated Makefile
     - import sprintf buffer overflow fix from Ubuntu.
       (Thanks: Matthew L. Dailey) (LP: #2095035)

QA information

Comments

  1. WIP, not for upload please. Still to do:
1) systemd timer for monthly report not relying on anacron
2) a noisy runlevels issue on installation
3) then update SV

I am not planning to fix the autotools build-twice mess, which is proving hard to fix.

Note the maintainer man pages were already there - but as 'replace everything' patches. Now they are whole files so it's more transparent what they are and easier to update them.
    Andrew Bower at June 21, 2025, 9:54 a.m.

Upload #1

Information

Version: 6.6.4-7
Uploaded: 2025-06-19 07:42
Source package: acct_6.6.4-7.dsc
Distribution: experimental
Section: admin
Priority: optional
Homepage: https://www.gnu.org/software/acct/
Vcs-Git: https://salsa.debian.org/pkg-security-team/acct.git
Vcs-Browser: https://salsa.debian.org/pkg-security-team/acct
Closes bugs: #1023810

Changelog

 acct (6.6.4-7) experimental; urgency=medium
 .
   * Team upload.
 .
   [ Andrew Bower ]
   * Add autopkgtest for process accounting.
   * Move lock file to /run. (Closes: #1023810)
     - allows autopktest to start service in initless unshare container

QA information

Comments

  1. Andrew,

Review of upload: 2025-06-19 07:42

For information about the tests run, see:

https://wiki.debian.org/PhilWyett/DebianMentoring

Test 3 (build twice): Information only

 dpkg-source -b .
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: warning: upstream signing key but no upstream tarball signature
dpkg-source: info: building acct using existing ./acct_6.6.4.orig.tar.gz
dpkg-source: info: using patch list from debian/patches/series
dpkg-source: warning: ignoring deletion of file aclocal.m4, use --include-removal to override
dpkg-source: warning: ignoring deletion of file missing, use --include-removal to override
dpkg-source: warning: ignoring deletion of file texinfo.tex, use --include-removal to override
dpkg-source: warning: ignoring deletion of file configure, use --include-removal to override
dpkg-source: warning: ignoring deletion of file ltmain.sh, use --include-removal to override
dpkg-source: warning: ignoring deletion of file mdate-sh, use --include-removal to override
dpkg-source: warning: ignoring deletion of file INSTALL, use --include-removal to override
dpkg-source: warning: ignoring deletion of file install-sh, use --include-removal to override
dpkg-source: warning: ignoring deletion of file config.h, use --include-removal to override
dpkg-source: warning: ignoring deletion of file config.h.in, use --include-removal to override
dpkg-source: warning: ignoring deletion of file depcomp, use --include-removal to override
dpkg-source: warning: ignoring deletion of file Makefile.in, use --include-removal to override
dpkg-source: warning: ignoring deletion of file m4/libtool.m4, use --include-removal to override
dpkg-source: warning: ignoring deletion of file m4/lt~obsolete.m4, use --include-removal to override
dpkg-source: warning: ignoring deletion of file m4/ltversion.m4, use --include-removal to override
dpkg-source: warning: ignoring deletion of file m4/ltoptions.m4, use --include-removal to override
dpkg-source: warning: ignoring deletion of file m4/ltsugar.m4, use --include-removal to override
dpkg-source: warning: ignoring deletion of file lib/Makefile.in, use --include-removal to override
dpkg-source: info: local changes detected, the modified files are:
 acct-6.6.4/accounting.info
 acct-6.6.4/html/Preface.html
 acct-6.6.4/html/ac.html
 acct-6.6.4/html/accton.html
 acct-6.6.4/html/dump_002dacct.html
 acct-6.6.4/html/index.html
 acct-6.6.4/html/lastcomm.html
 acct-6.6.4/html/sa.html
 acct-6.6.4/stamp-vti
 acct-6.6.4/version.texi
dpkg-source: hint: make sure the version in debian/changelog matches the unpacked source tree
dpkg-source: hint: you can integrate the local changes with dpkg-source --commit
dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/acct_6.6.4-7.diff.5jh67k
dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
I: copying local configuration
E: Failed autobuilding of package

Test 4 (sbuild): Information only

Lintian:

W: acct: depends-on-obsolete-package Depends: lsb-base
N: 
N:   The package depends on a package that has been superseded. If the
N:   superseded package is part of an ORed group, it should not be the first
N:   package in the group.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: fields/package-relations
N: 
N:
W: acct: missing-systemd-timer-for-cron-script [etc/cron.daily/acct]
N: 
N:   This package ships the specified cron script but does not ship a
N:   equivalent systemd .timer unit.
N:   
N:   The "desktop" and "laptop" tasks no longer pull in anacron(8), the usual
N:   solution for desktop installations that are not running all the time.
N:   
N:   Please consider shipping an equivalent .timer file for this script.
N: 
N:   Please refer to the systemd.timer(5) manual page, the anacron(8) manual
N:   page, and Bug#1007257 for details.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: systemd
N: 
N:
W: acct: missing-systemd-timer-for-cron-script [etc/cron.monthly/acct]
N:
W: acct: old-fsf-address-in-copyright-file
N: 
N:   The /usr/share/doc/*pkg*/copyright file refers to the old postal address
N:   of the Free Software Foundation (FSF). You should refer to
N:   https://www.gnu.org/licenses/ instead of a physical address, for example:
N:   
N:     You should have received a copy of the GNU General Public License
N:     along with this program.  If not, see https://www.gnu.org/licenses/.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: debian/copyright
N: 
N:
W: acct source: orig-tarball-missing-upstream-signature acct_6.6.4.orig.tar.gz
N: 
N:   The packaging includes an upstream signing key but the corresponding .asc
N:   signature for one or more source tarballs are not included in your
N:   .changes file.
N:   
N:   Please ensure a <package>_<version>.orig.tar.<ext>.asc file exists in the
N:   same directory as your <package>_<version>.orig.tar.<ext> tarball prior to
N:   dpkg-source --build being called.
N:   
N:   If you are repackaging your source tarballs for Debian Free Software
N:   Guidelines compliance reasons, ensure that your package version includes
N:   dfsg or similar.
N:   
N:   Sometimes, an upstream signature must be added for an orig.tar.gz that is
N:   already present in the archive. Please include the upstream sources again
N:   with dpkg-genchanges -sa while the signature is also present. Your upload
N:   will be accepted as long as the new orig.tar.gz file is identical to the
N:   old one.
N: 
N:   Please refer to Bug#954743 and Bug#872864 for details.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: upstream-signature
N: 
N:
I: acct source: out-of-date-standards-version 4.6.1 (released 2022-05-11) (current is 4.7.2)
N: 
N:   The source package refers to a Standards-Version older than the one that
N:   was current at the time the package was created (according to the
N:   timestamp of the latest debian/changelog entry). Please consider updating
N:   the package to current Policy and setting this control field
N:   appropriately.
N:   
N:   If the package is already compliant with the current standards, you don't
N:   have to re-upload the package just to adjust the Standards-Version control
N:   field. However, please remember to update this field next time you upload
N:   the package.
N:   
N:   See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
N:   debian-policy package for a summary of changes in newer versions of
N:   Policy.
N: 
N:   Please refer to
N:   https://www.debian.org/doc/debian-policy/upgrading-checklist.html for
N:   details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: fields/standards-version
N: 
N:
I: acct source: patch-not-forwarded-upstream [debian/patches/01_do-not-split-html-info.patch]
N: 
N:   According to the DEP-3 headers, this patch has not been forwarded
N:   upstream.
N:   
N:   Please forward the patch and try to have it included in upstream's version
N:   control system. If the patch is not suitable for that, please mention
N:   not-needed in the Forwarded field of the patch header.
N: 
N:   Please refer to social contract item 2, Coordination with upstream
N:   developers (Section 3.1.4) in the Debian Developer's Reference, Changes to
N:   the upstream sources (Section 4.3) in the Debian Policy Manual, and
N:   Bug#755153 for details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: debian/patches/dep3
N:   Renamed from: send-patch
N: 
N:
I: acct source: patch-not-forwarded-upstream [debian/patches/02_414300-lastcomm-fields-descr.patch]
N:
I: acct source: patch-not-forwarded-upstream [debian/patches/03_cross-build-support.patch]
N:
I: acct source: patch-not-forwarded-upstream [debian/patches/04_Fix-spelling-errors.patch]
N:
I: acct source: patch-not-forwarded-upstream [debian/patches/05_Adapt_dump.acct.8-manpage.patch]
N:
I: acct source: patch-not-forwarded-upstream [debian/patches/06_adapt_dump-utmp.8-manpage.patch]

Test 7 (licenserecon): Information only

philwyett@ks-tarkin:~/Development/builder/debian/acct-6.6.4$ lrc
en: Versions: licenserecon '6.0'  licensecheck '3.3.9-1'

Parsing Source Tree  ....
Reading d/copyright  ....
Running licensecheck ....

d/copyright      | licensecheck

GPL-3            | GPL-3+            ac.c
GPL-3            | GPL-3+            accton.c
GPL-3            | FSFULLR and/or GPL and/or LGPL aclocal.m4
GPL-3            | GPL-3+            common.c
GPL-3            | GPL-3+            common.h
GPL-3            | FSFUL             configure
GPL-3            | GPL-3+            configure.ac
GPL-3            | GPL-3+            dev_hash.h
GPL-3            | GPL-3+            dump-acct.c
GPL-3            | GPL-3+            dump-utmp.c
GPL-3            | GPL-3+            file_rd.h
GPL-3            | GPL-3+            hashtab.h
GPL-3            | FSFAP             INSTALL
GPL-3            | X11               install-sh
GPL-3            | GPL-3+            last.c
GPL-3            | GPL-2+            lastcomm.c
GPL-3            | GPL-3+            lib/alloca.in.h
GPL-3            | GPL-3+            lib/basename-lgpl.c
GPL-3            | GPL-3+            lib/canonicalize-lgpl.c
GPL-3            | GPL-3+            lib/dirname.h
GPL-3            | GPL-3+            lib/dirname-lgpl.c
GPL-3            | GPL-3+            lib/dosname.h
GPL-3            | GPL-3+            lib/errno.in.h
GPL-3            | GPL-3+            lib/error.c
GPL-3            | GPL-3+            lib/error.h
GPL-3            | GPL-3+            lib/exitfail.c
GPL-3            | GPL-3+            lib/exitfail.h
GPL-3            | GPL-3+            lib/fstat.c
GPL-3            | GPL-3+            lib/ftell.c
GPL-3            | GPL-3+            lib/ftello.c
GPL-3            | GPL-3+            lib/getopt1.c
GPL-3            | GPL-3+            lib/getopt.c
GPL-3            | GPL-3+            lib/getopt.in.h
GPL-3            | GPL-3+            lib/getopt_int.h
GPL-3            | GPL-3+            lib/getpagesize.c
GPL-3            | GPL-3+            lib/gettext.h
GPL-3            | GPL-3+            lib/intprops.h
GPL-3            | GPL-3+            lib/lseek.c
GPL-3            | GPL-3+            lib/lstat.c
GPL-3            | GPL-3+            lib/Makefile.am
GPL-3            | GPL-3+            lib/Makefile.in
GPL-3            | GPL-3+            lib/malloca.c
GPL-3            | GPL-3+            lib/malloca.h
GPL-3            | GPL-3+            lib/malloc.c
GPL-3            | GPL-3+            lib/mktime.c
GPL-3            | GPL-3+            lib/msvc-inval.c
GPL-3            | GPL-3+            lib/msvc-inval.h
GPL-3            | GPL-3+            lib/msvc-nothrow.c
GPL-3            | GPL-3+            lib/msvc-nothrow.h
GPL-3            | GPL-3+            lib/pathmax.h
GPL-3            | GPL-3+            lib/raise.c
GPL-3            | GPL-3+            lib/readlink.c
GPL-3            | GPL-3+            lib/readutmp.c
GPL-3            | GPL-3+            lib/readutmp.h
GPL-3            | GPL-3+            lib/rename.c
GPL-3            | GPL-3+            lib/rmdir.c
GPL-3            | GPL-3+            lib/same-inode.h
GPL-3            | GPL-3+            lib/sigaction.c
GPL-3            | GPL-3+            lib/sig-handler.h
GPL-3            | GPL-3+            lib/signal.in.h
GPL-3            | GPL-3+            lib/sigprocmask.c
GPL-3            | GPL-3+            lib/stat.c
GPL-3            | GPL-3+            lib/stdbool.in.h
GPL-3            | GPL-3+            lib/stddef.in.h
GPL-3            | GPL-3+            lib/stdint.in.h
GPL-3            | GPL-3+            lib/stdio-impl.h
GPL-3            | GPL-3+            lib/stdio.in.h
GPL-3            | GPL-3+            lib/stdlib.in.h
GPL-3            | GPL-3+            lib/strerror.c
GPL-3            | GPL-3+            lib/strerror-override.c
GPL-3            | GPL-3+            lib/strerror-override.h
GPL-3            | GPL-3+            lib/string.in.h
GPL-3            | GPL-3+            lib/stripslash.c
GPL-3            | GPL-3+            lib/strtol.c
GPL-3            | GPL-3+            lib/strtoul.c
GPL-3            | GPL-3+            lib/sys_stat.in.h
GPL-3            | GPL-3+            lib/sys_types.in.h
GPL-3            | GPL-3+            lib/time.in.h
GPL-3            | GPL-3+            lib/time_r.c
GPL-3            | GPL-3+            lib/unistd.in.h
GPL-3            | GPL-3+            lib/verify.h
GPL-3            | GPL-3+            lib/xalloc-die.c
GPL-3            | GPL-3+            lib/xalloc.h
GPL-3            | GPL-3+            lib/xalloc-oversized.h
GPL-3            | GPL-3+            lib/xmalloc.c
GPL-3            | GPL-3+            linux-acct.h
GPL-3            | GPL-2+ with Libtool exception ltmain.sh
GPL-3            | FSFULLR           m4/00gnulib.m4
GPL-3            | FSFULLR           m4/alloca.m4
GPL-3            | FSFULLR           m4/canonicalize.m4
GPL-3            | FSFULLR           m4/dirname.m4
GPL-3            | FSFULLR           m4/double-slash-root.m4
GPL-3            | FSFULLR           m4/eealloc.m4
GPL-3            | FSFULLR           m4/errno_h.m4
GPL-3            | FSFULLR           m4/error.m4
GPL-3            | FSFULLR           m4/extensions.m4
GPL-3            | FSFULLR           m4/extern-inline.m4
GPL-3            | FSFULLR           m4/fseeko.m4
GPL-3            | FSFULLR           m4/fstat.m4
GPL-3            | FSFULLR           m4/ftell.m4
GPL-3            | FSFULLR           m4/ftello.m4
GPL-3            | FSFULLR           m4/getopt.m4
GPL-3            | FSFULLR           m4/getpagesize.m4
GPL-3            | GPL-3+            m4/gnulib-cache.m4
GPL-3            | FSFULLR           m4/gnulib-common.m4
GPL-3            | GPL-3+            m4/gnulib-comp.m4
GPL-3            | FSFULLR           m4/include_next.m4
GPL-3            | FSFULLR           m4/largefile.m4
GPL-3            | (FSFULLR and/or GPL-2+) with Libtool exception m4/libtool.m4
GPL-3            | FSFULLR           m4/longlong.m4
GPL-3            | FSFULLR           m4/lseek.m4
GPL-3            | FSFULLR           m4/lstat.m4
GPL-3            | FSFULLR           m4/lt~obsolete.m4
GPL-3            | FSFULLR           m4/ltoptions.m4
GPL-3            | FSFULLR           m4/ltsugar.m4
GPL-3            | FSFULLR           m4/ltversion.m4
GPL-3            | FSFULLR           m4/malloca.m4
GPL-3            | FSFULLR           m4/malloc.m4
GPL-3            | FSFULLR           m4/mktime.m4
GPL-3            | FSFULLR           m4/msvc-inval.m4
GPL-3            | FSFULLR           m4/msvc-nothrow.m4
GPL-3            | FSFULLR           m4/multiarch.m4
GPL-3            | FSFULLR           m4/nocrash.m4
GPL-3            | FSFULLR           m4/off_t.m4
GPL-3            | GPL-3+            m4/onceonly.m4
GPL-3            | FSFULLR           m4/pathmax.m4
GPL-3            | FSFULLR           m4/raise.m4
GPL-3            | FSFULLR           m4/readlink.m4
GPL-3            | FSFULLR           m4/readutmp.m4
GPL-3            | FSFULLR           m4/rename.m4
GPL-3            | FSFULLR           m4/rmdir.m4
GPL-3            | FSFULLR           m4/sigaction.m4
GPL-3            | FSFULLR           m4/signalblocking.m4
GPL-3            | FSFULLR           m4/signal_h.m4
GPL-3            | FSFULLR           m4/ssize_t.m4
GPL-3            | FSFULLR           m4/stat.m4
GPL-3            | FSFULLR           m4/stdbool.m4
GPL-3            | FSFULLR           m4/stddef_h.m4
GPL-3            | FSFULLR           m4/stdint.m4
GPL-3            | FSFULLR           m4/stdio_h.m4
GPL-3            | FSFULLR           m4/stdlib_h.m4
GPL-3            | FSFULLR           m4/strerror.m4
GPL-3            | FSFULLR           m4/string_h.m4
GPL-3            | FSFULLR           m4/strtol.m4
GPL-3            | FSFULLR           m4/strtoul.m4
GPL-3            | FSFULLR           m4/sys_socket_h.m4
GPL-3            | FSFULLR           m4/sys_stat_h.m4
GPL-3            | FSFULLR           m4/sys_types_h.m4
GPL-3            | FSFULLR           m4/time_h.m4
GPL-3            | FSFULLR           m4/time_r.m4
GPL-3            | FSFULLR           m4/unistd_h.m4
GPL-3            | FSFULLR           m4/warn-on-use.m4
GPL-3            | FSFULLR           m4/wchar_t.m4
GPL-3            | FSFULLR           m4/xalloc.m4
GPL-3            | GPL-3+            pacct_rd.h
GPL-3            | GPL-3+            sa.c
GPL-3            | GPL-3+            snippet/arg-nonnull.h
GPL-3            | GPL-3+            snippet/c++defs.h
GPL-3            | GPL-3+            snippet/warn-on-use.h
GPL-3            | GPL-3+            texinfo.tex
GPL-3            | GPL-3+            uid_hash.h
GPL-3            | GPL-3+            utmp_rd.h

Summary
=======

Andrew, Quite a few things to be reviewed and to be possibly addressed.

Regards

Phil
    Needs work Phil Wyett at June 19, 2025, 9:25 a.m. 
  2. Thank, Phil! Agreed. Planning to get the autopkgtest in first on its own to check that succeeds in experimental.
    Andrew Bower at June 19, 2025, 9:36 a.m. 
  3. Phil, I have fixes for some of those things, including lrc, but the build twice issues really evade me. Just adding the 'clean' list you suggested before doesn't even get close! It's so messy having so many autogenerated files in the upstream archive but I'm loathed to go for a '-ds' repacking just for building twice and I can't find really good advice for cleaning autotools mess as downstream. I tried my own stashing operations and it's not enough...

Do you have any good pointers to where people have got on top of this sort of chaos before?
    Andrew Bower at June 20, 2025, 8 p.m.