I've looked through the package, and noted a few things that could do with improvement:
* debian/control, debian/*.1:
- Descriptions contain grammatical errors. http://paste.debian.net/151338/ is a slightly rephrased version of the long description in debian/control.
- Translators in manpage includes "My self".
* debian/copyright:
- GPL-2+, not GPL-2.0+
- GFDL-1.1+, not GFDL-1.1 (license.xml states "or later")
- "LIST THEIR TITLES" is not meant to be included in the License: GFDL-1.1+ block.
- GFDL is not DFSG-free (but in this case it is considered free due to an exception: https://wiki.debian.org/DFSGLicenses#GNU_Free_Documentation_License_.28FDL.29), which is why it is important to properly state that there are no invariant sections. You can get the GFDL snippet from the license.xml files.
- Copyright information for wallpapoz.xml files are wrong. See the <copyright>...</copyright> bits in the wallpapoz.xml files. The following command should help you fill that up:
$ for i in **/wallpapoz.xml; do echo $i; sed -n '/<copyright>/,/<\/copyright>/p' $i; echo; done
* debian/rules:
- That's a lot of chmod statements there. You could replace pretty much all of them with "find debian/wallpapoz -regex '\.(png|py|png|mo|xml)$$' -exec chmod 644 '{}' \+"
- Don't call dh_clean inside override_dh_auto_clean. dh(1) will take care of that. See the output of "dh --no-act clean"
Needs work
Chow Loong Jin at 2012-01-07 17:59:34.489016