Version 0.7.8+git20120112-1

Information

QA information

Comments

1. Changes already done:
   -pspp.doc-base
   -debian/watch
   -debian/copyright
   -build dependencies
   
   For the outstanding things see the discussion on pspp-users mailinglist.

   Needs work Bojo42 at 2012-01-17 16:28:12.338318

2. README.Source says:
   
   > We also ship a supplementary tarball for Gnulib from
   > http://git.savannah.gnu.org/gitweb/?p=gnulib.git, as PSPP has specific
   > dependency needs on certain Git snapshots and the Debian package for Gnulib
   > won't met those. This should only be kept until upstream loosens the dependency.
   
   Did you try building PSPP against whatever is in the current Debian snapshot?  As upstream author, I'm willing to do some amount of work to make PSPP build against it, if you give it a shot and it does not work.
   
   The main reason that PSPP specifies a particular Gnulib snapshot is that Gnulib tends to make incompatible changes.  But the process of "upgrading" is usually simple, so I'm willing to do it as it becomes necessary.

   Ben Pfaff at 2012-01-17 05:31:16.471474

3. Please consider upgrading from debhelper compat level 7 to level 8, since debhelper(7) says that this is the "recommended mode of operation".  I doubt that any changes are necessary other than updating debian/compat.

   Ben Pfaff at 2012-01-17 05:33:23.591057

4. libplot-dev is an obsolete build dependency, because 0.7.8 doesn't use libplot, although older versions did.
   
   I don't think that libglade2-dev is needed as a build dependency.
   
   I don't think that imagemagick is needed as a build dependency.
   

   Ben Pfaff at 2012-01-17 05:39:30.245288

5. In debian/copyright, please remove my old email address pfaffben@msu.edu.  I don't think any email address is necessary there.
   
   Also in debian/copyright, please update the final paragraph of the license excerpt to the form now used in PSPP:
   
      You should have received a copy of the GNU General Public License
      along with this program.  If not, see <http://www.gnu.org/licenses/>.

   Ben Pfaff at 2012-01-17 05:42:03.740433

6. A comment at the top of preinst says:
   # Using old school style since dpkg (>= 1.15.7.2) is too new for backports
   I think this comment must be obsolete, since dpkg newer than that is in stable.  Perhaps something can now be simplified, then?

   Ben Pfaff at 2012-01-17 05:45:51.169056

7. pspp.doc-base doesn't mention the GUI at all, but I think that it probably should.
   
   debian/watch has a lot of boilerplate comments that I would consider deleting.

   Needs work Ben Pfaff at 2012-01-17 05:49:37.052177

8. New changes:
   - switched from upstream gnulib git to debian source tarball
   - added Uploaders and updated Description in debian/control
   - remove possibly auto-generated info dir file via override_dh_auto_install
   - pspp.doc-base noted "various other output formats"

   Bojo42 at 2012-01-18 15:00:39.075671

9. Have you updated the package description?  If so then I will take another look and as long as other recent changes look reasonable, and there are no serious lintian complaints, then I will upload it.
   
   Thanks,
   
   Ben.

   Ben Pfaff at 2012-01-21 17:46:04.925820

10. I took a look at the version uploaded 2012-01-22 20:40 and tried building it.  (Previously, I had only looked over the packaging.)  The build immediately failed for me because I did not have the Debian gnulib package installed even though that was a build dependency.  I think that this build dependency must be a mistake, since gnulib source is shipped.
    
    There are several lintian warnings.  I think that the following should be fixed in the packaging:
    
    W: pspp source: maintainer-not-full-name bojo42
    W: pspp: maintainer-not-full-name bojo42
    W: pspp: binary-without-manpage usr/bin/pspp-dump-sav
    
    I will look at PSPP itself to see whether the following are upstream bugs:
    
    W: pspp: executable-not-elf-or-script ./usr/share/icons/hicolor/16x1/apps/pspp.png
    W: pspp: executable-not-elf-or-script ./usr/share/icons/hicolor/16x16/pspp/string.png
    W: pspp: executable-not-elf-or-script ./usr/share/icons/hicolor/16x16/pspp/scale.png
    W: pspp: executable-not-elf-or-script ./usr/share/icons/hicolor/16x16/pspp/date-scale.png
    W: pspp: executable-not-elf-or-script ./usr/share/icons/hicolor/16x16/pspp/ordinal.png
    W: pspp: executable-not-elf-or-script ./usr/share/pspp/pspp.lang
    W: pspp: executable-not-elf-or-script ./usr/share/icons/hicolor/16x16/pspp/nominal.png
    
    Thanks,
    
    Ben.

    Needs work Ben Pfaff at 2012-01-24 05:25:53.722739

11. Oh, also: I think that you could update the description in debian/pspp.doc-base also.
    
    Thanks,
    
    Ben.

    Ben Pfaff at 2012-01-24 05:26:33.035984

12. I wrote:
    > I will look at PSPP itself to see whether the following are upstream bugs:
    They were upstream bugs.  I push a fix to PSPP "master".

    Ben Pfaff at 2012-01-24 05:34:48.931358