Details about package libsmb2
Name: | libsmb2 |
---|---|
Uploader: | Joe Mondloch <joe@mondloch.net> (Debian QA page) |
Description: | libsmb2-4 - SMB2/3 client library |
Package uploads
Upload #2
Information
Version: | 4.0.0-1 |
---|---|
Uploaded: | 2024-03-30 22:30 |
Source package: | libsmb2_4.0.0-1.dsc |
Distribution: | unstable |
Section: | libs |
Priority: | optional |
Homepage: | https://github.com/sahlberg/libsmb2 |
Vcs-Git: | https://github.com/sahlberg/libsmb2.git |
Vcs-Browser: | https://github.com/sahlberg/libsmb2 |
Closes bugs: | #1068113 |
Changelog
libsmb2 (4.0.0-1) unstable; urgency=medium . * Initial release. (Closes: #1068113)
QA information
-
–
Package uses debhelper-compatDebhelper compatibility level 13
-
–
Package is the latest upstream version
Local: 4.0.0 Upstream: 4.0.0 Url: https://github.com/sahlberg/libsmb2/archive/refs/tags/v4.0.0.tar.gz -
–
Package is not native
Format: 3.0 (quilt) -
–
"Maintainer" email is the same as the uploader
-
–
Package has lintian warningslibsmb2 source
-
I
patch-not-forwarded-upstream
- [debian/patches/fix-sha224-256-compilation-error.patch]
-
X
debian-watch-does-not-check-openpgp-signature
- [debian/watch]
-
X
prefer-uscan-symlink
- filenamemangle s%(?:.*?)?v?(@ANY_VERSION@@ARCHIVE_EXT@)%@PACKAGE@-$1% [debian/watch:4]
-
X
upstream-metadata-file-is-missing
-
X
very-long-line-length-in-source-file
- 756 > 512 [examples/smb2-cat-async.c:11]
- 756 > 512 [examples/smb2-cat-sync.c:11]
- 756 > 512 [examples/smb2-dcerpc-coder-test.c:11]
- 756 > 512 [examples/smb2-ftruncate-sync.c:11]
- 756 > 512 [examples/smb2-ls-async.c:11]
- 756 > 512 [examples/smb2-ls-sync.c:11]
- 756 > 512 [examples/smb2-lsa-lookupsids.c:11]
- 756 > 512 [examples/smb2-lseek-sync.c:11]
- 756 > 512 [examples/smb2-put-async.c:11]
- 756 > 512 [examples/smb2-put-sync.c:11]
- 756 > 512 [examples/smb2-raw-fsstat-async.c:11]
- 756 > 512 [examples/smb2-raw-getsd-async.c:11]
- 756 > 512 [examples/smb2-raw-stat-async.c:11]
- 756 > 512 [examples/smb2-readlink.c:11]
- 756 > 512 [examples/smb2-share-enum.c:11]
- 756 > 512 [examples/smb2-share-info.c:11]
- 756 > 512 [examples/smb2-stat-sync.c:11]
- 756 > 512 [examples/smb2-statvfs-sync.c:11]
- 756 > 512 [examples/smb2-truncate-sync.c:11]
libsmb2-4-
W
link-to-shared-library-in-wrong-package
- usr/lib/x86_64-linux-gnu/libsmb2.so.4.0.0 [usr/lib/x86_64-linux-gnu/libsmb2.so]
-
I
no-symbols-control-file
- usr/lib/x86_64-linux-gnu/libsmb2.so.4.0.0
-
O
spelling-error-in-binary
- Securty Security [usr/lib/x86_64-linux-gnu/libsmb2.so.4.0.0] (override comment: https://github.com/sahlberg/libsmb2/commit/29591dcb544553d146437b186f189d123fc02ce0)
-
I
patch-not-forwarded-upstream
-
–
Package closes ITP bug
-
–
Package is not in Debian
-
–
d/copyright is in DEP5 format
Upstream Contact: Ronnie Sahlberg <ronniesahlberg@gmail.com> Licenses: LGPL-2.1+, BSD-2-Clause
Comments
-
I usually use `lintian -Ivi *.changes` which gives us this: W: libsmb2-4: link-to-shared-library-in-wrong-package usr/lib/x86_64-linux-gnu/libsmb2.so .4.0.0 [usr/lib/x86_64-linux-gnu/libsmb2.so] N: N: Although this package is not a "-dev" package, it installs a N: "libsomething.so" symbolic link referencing the corresponding shared N: library. When the link doesn't include the version number, it is used by N: the linker when other programs are built against this shared library. N: N: Shared libraries are supposed to place such symbolic links in their N: respective "-dev" packages, so it is a bug to include it with the main N: library package. N: N: However, if this is a small package which includes the runtime and the N: development libraries, this is not a bug. In the latter case, please N: override this warning. N: N: Please refer to Development files (Section 8.4) in the Debian Policy N: Manual for details. N: N: Visibility: warning N: Show-Always: no N: Check: libraries/shared/links N: Renamed from: non-dev-pkg-with-shlib-symlink
Alex Myczko at April 3, 2024, 2:21 a.m. -
so from looking at dpkg -L libsmb2-4 we get /. /usr /usr/include /usr/include/smb2 /usr/include/smb2/libsmb2-dcerpc-lsa.h /usr/include/smb2/libsmb2-dcerpc-srvsvc.h /usr/include/smb2/libsmb2-dcerpc.h /usr/include/smb2/libsmb2-raw.h /usr/include/smb2/libsmb2.h /usr/include/smb2/smb2-errors.h /usr/include/smb2/smb2.h /usr/lib /usr/lib/x86_64-linux-gnu /usr/lib/x86_64-linux-gnu/libsmb2.a /usr/lib/x86_64-linux-gnu/libsmb2.la /usr/lib/x86_64-linux-gnu/libsmb2.so.4.0.0 /usr/lib/x86_64-linux-gnu/pkgconfig /usr/lib/x86_64-linux-gnu/pkgconfig/libsmb2.pc /usr/share /usr/share/doc /usr/share/doc/libsmb2-4 /usr/share/doc/libsmb2-4/changelog.Debian.gz /usr/share/doc/libsmb2-4/copyright /usr/share/doc/libsmb2-4/examples /usr/share/doc/libsmb2-4/examples/smb2-cat-async.c /usr/share/doc/libsmb2-4/examples/smb2-cat-sync.c /usr/share/doc/libsmb2-4/examples/smb2-dcerpc-coder-test.c /usr/share/doc/libsmb2-4/examples/smb2-ftruncate-sync.c /usr/share/doc/libsmb2-4/examples/smb2-ls-async.c /usr/share/doc/libsmb2-4/examples/smb2-ls-sync.c /usr/share/doc/libsmb2-4/examples/smb2-lsa-lookupsids.c and basically, drop .a ship .c/.h/.pc with libsmb2-dev (arch: all) *.so with libsmb2-4
Needs work Alex Myczko at April 3, 2024, 2:25 a.m.
Upload #1
Information
Version: | 4.0.0-1 |
---|---|
Uploaded: | 2024-03-30 17:00 |
Source package: | libsmb2_4.0.0-1.dsc |
Distribution: | unstable |
Section: | libs |
Priority: | optional |
Homepage: | https://github.com/sahlberg/libsmb2 |
Vcs-Git: | https://github.com/sahlberg/libsmb2.git |
Vcs-Browser: | https://github.com/sahlberg/libsmb2 |
Changelog
libsmb2 (4.0.0-1) unstable; urgency=medium . * Initial release.
QA information
-
–
Package uses debhelper-compatDebhelper compatibility level 13
-
–
Package is the latest upstream version
Local: 4.0.0 Upstream: 4.0.0 Url: https://github.com/sahlberg/libsmb2/archive/refs/tags/v4.0.0.tar.gz -
–
Package is not native
Format: 3.0 (quilt) -
–
"Maintainer" email is the same as the uploader
-
–
Package has lintian warningslibsmb2 source
-
I
patch-not-forwarded-upstream
- [debian/patches/fix-sha224-256-compilation-error.patch]
-
X
debian-watch-does-not-check-openpgp-signature
- [debian/watch]
-
X
prefer-uscan-symlink
- filenamemangle s%(?:.*?)?v?(@ANY_VERSION@@ARCHIVE_EXT@)%@PACKAGE@-$1% [debian/watch:4]
-
X
upstream-metadata-file-is-missing
-
X
very-long-line-length-in-source-file
- 756 > 512 [examples/smb2-cat-async.c:11]
- 756 > 512 [examples/smb2-cat-sync.c:11]
- 756 > 512 [examples/smb2-dcerpc-coder-test.c:11]
- 756 > 512 [examples/smb2-ftruncate-sync.c:11]
- 756 > 512 [examples/smb2-ls-async.c:11]
- 756 > 512 [examples/smb2-ls-sync.c:11]
- 756 > 512 [examples/smb2-lsa-lookupsids.c:11]
- 756 > 512 [examples/smb2-lseek-sync.c:11]
- 756 > 512 [examples/smb2-put-async.c:11]
- 756 > 512 [examples/smb2-put-sync.c:11]
- 756 > 512 [examples/smb2-raw-fsstat-async.c:11]
- 756 > 512 [examples/smb2-raw-getsd-async.c:11]
- 756 > 512 [examples/smb2-raw-stat-async.c:11]
- 756 > 512 [examples/smb2-readlink.c:11]
- 756 > 512 [examples/smb2-share-enum.c:11]
- 756 > 512 [examples/smb2-share-info.c:11]
- 756 > 512 [examples/smb2-stat-sync.c:11]
- 756 > 512 [examples/smb2-statvfs-sync.c:11]
- 756 > 512 [examples/smb2-truncate-sync.c:11]
libsmb2-4-
W
initial-upload-closes-no-bugs
- [usr/share/doc/libsmb2-4/changelog.Debian.gz:1]
-
W
link-to-shared-library-in-wrong-package
- usr/lib/x86_64-linux-gnu/libsmb2.so.4.0.0 [usr/lib/x86_64-linux-gnu/libsmb2.so]
-
I
no-symbols-control-file
- usr/lib/x86_64-linux-gnu/libsmb2.so.4.0.0
-
O
spelling-error-in-binary
- Securty Security [usr/lib/x86_64-linux-gnu/libsmb2.so.4.0.0] (override comment: https://github.com/sahlberg/libsmb2/commit/29591dcb544553d146437b186f189d123fc02ce0)
-
I
patch-not-forwarded-upstream
-
–
Package is not in Debian
-
–
d/copyright is in DEP5 format
Upstream Contact: Ronnie Sahlberg <ronniesahlberg@gmail.com> Licenses: LGPL-2.1+, BSD-2-Clause
Comments
-
I accidentally wiped the below comment while cleaning up lintian warnings. I'll reach out on IRC. ---- Please take a look at https://github.com/alexmyczko/autoexec.bat/blob/master/deb2itp It is easy to fix all the lintian things. You can create debian/examples Will be glad to sponsor this. Are you on IRC? Needs work Gürkan Myczko at March 29, 2024, 5:10 a.m.
Needs work Joe Mondloch at March 30, 2024, 6:26 p.m. -
once you have rfp itp number refer to it in d/changelog…
Needs work Alex Myczko at March 30, 2024, 9:21 p.m. -
d/changelog updated with ITP number
Needs work Joe Mondloch at March 30, 2024, 10:33 p.m.